-
Notifications
You must be signed in to change notification settings - Fork 12
🚀 release: 1.0.0 #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
🚀 release: 1.0.0 #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
* enable netbox_branching plugin by default in development/test docker image * include netbox-worker * add development setting defaults * don't pin branching plugin
* chore: add safe redirect to login Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * chore: gha - add missing permissions Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * chore: gha - pin actions to commit hashes Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * tidy up Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> --------- Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
* updates sdk to pick up ignored state * handle unknown states gracefully
* chore: security improvements (#53) * chore: add safe redirect to login Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * chore: gha - add missing permissions Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * chore: gha - pin actions to commit hashes Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * tidy up Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> --------- Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * update protobufs * update constants in tests --------- Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
* chore: remove reconciler sdk Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * fix: docker setup with netbox 4.1.11 for netbox-branching plugin Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * feat: remove ingestion logs view Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * chore: update CODEOWNERS Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> --------- Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
* fix: retrieve object states using concrete models Search backend/CachedValue is global and doesn't seem to be reliable with branching Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * tidy up Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * chore: bump netbox min version and netbox-docker Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * chore: bump netbox min version Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * fix tests Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * use clean_fields() and tidy up Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * fix: add backwards compatible support for mac_address field (#62) * fix: add backwards compatible support for mac_address field * feat: extract and serialize site from scope Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * feat: apply change set - handle scope site Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> --------- Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> Co-authored-by: Luke Tucker <64618+ltucker@users.noreply.github.com>
* fix: retrieving object states of tags Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * fix: skip creating objects if already exist Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * chore: refactor apply change set view complexity Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * tidy up Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> --------- Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
* fix: scope support on apply change set (#64) Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * wip diff api * set default values and missing slugs Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * tidy up setting defaults Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * remove unused imports Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * fix constructor of object type Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * set slugs (if not present) after resolving existing instances Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * emit ref_id instead of variable object_id field for new objects * improve entity field mapping coverage * fill in primary value mapping, use primary value for slug * use canonical field ordering in change dicts * first pass at certain common circular refs * remove ref id to itself Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * tidy up Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * add applier Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * fix resolve ref before lookup, use field name directly, not field attr * don't query with unresolved references * fix _build_expressions_queryset Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * resolve lint issues Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * exclude fields with GenericRelation type Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * fix sorting dict we may get ints strings etc Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * rework applier logic Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * applier with content type fields Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * fix content type related existing value Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * exclude foreign key fields with many to one rel Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * fix: support for post create updates eg (primary mac address) (#68) * fix: support for post create updates eg (primary mac address) * use serializers, fix relevent tests * linting * filter fields in the prior state * add some basic smoke tests for diff / diff+apply * Change set validation (#69) * add change set validation Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * remove redundant serializers Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * remove redundant serializers tests Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * tidy up Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * adjust tests, lighter validation of refs on diff, handle generic --------- Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> * fix: expand support for cycle breaking, add additional logical matchers (#70) * fix: fix error fingerprinting tags (#71) * fix: all noops -> no changes, show noops as only prior state (#72) --------- Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com> Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
basic support for custom fields
cleanup error messages
special transformations to format inputs the way serializers expect adds handling for date only fields, decimal (vs float) and integer range
* fix: special handling for ip address network defaulting * fix: match ips ignoring mask value, use specific matchers
* fix: fix complex vm interface update case * lint
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
…x Plugin - Added DiodeOAuth2Authentication class for handling OAuth2 token validation. - Introduced IsDiodeOAuth2Authenticated permission class to check OAuth2 authentication. - Updated GenerateDiffView and ApplyChangeSetView to use the new authentication and permission classes. Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
…s files Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
* fix: handle callable defaults, defaults with non serializable values * fix: mark circuits.provider.accounts as circular * fix: error deduplicating device types * fix: report merge errors as 400 not 500 * fix: mark device oob_ip as circular * fix: adjust fingerprint matching for complex module bay case * fix: test virtual machine with primary_ip4 errors, logical cluster matching * fix: harmonize ZoneInfo values * fix: fix logical prefix in vrf lookup * fix: handle IntegrityError nicely * fix: support cached scope for matching * fix: add additional logical matchers * fix: don't alter arrays. output prior states for other ref types * fix: add table test for create/update of various types * fix: additional fixes from testing * fix: reduce logging, guard expensive trace logging with flag * fix: linting
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
…concurrency) Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
…output handling in workflow Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
leoparente
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Major improvements and breaking changes: