Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v18.2.0 proposal #43036

Merged
merged 81 commits into from May 17, 2022
Merged

v18.2.0 proposal #43036

merged 81 commits into from May 17, 2022

Commits on May 10, 2022

  1. test: reduce impact of flaky HTTP server tests

    Refs: #42741
    
    PR-URL: #42926
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    tniessen authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    72b90fd View commit details
    Browse the repository at this point in the history
  2. doc: clarify some default values in fs.md

    PR-URL: #42892
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    LiviaMedeiros authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    924670f View commit details
    Browse the repository at this point in the history
  3. crypto: clean up parameter validation in HKDF

    PR-URL: #42924
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    tniessen authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    183bcc0 View commit details
    Browse the repository at this point in the history
  4. doc: add section regarding property definition in primordials.md

    PR-URL: #42921
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    aduh95 authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    88692d8 View commit details
    Browse the repository at this point in the history
  5. assert: make assert.fail less affected by prototype tampering

    PR-URL: #42918
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    aduh95 authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    e74a8da View commit details
    Browse the repository at this point in the history
  6. bootstrap: fix wasm_web_api external reference registration

    The external references were not actually registered.
    
    PR-URL: #42903
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    joyeecheung authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    9ee7d9e View commit details
    Browse the repository at this point in the history
  7. http2: compat support for array headers

    PR-URL: #42901
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    y1d7ng authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    bfbf965 View commit details
    Browse the repository at this point in the history
  8. test: add test for position validation in fs.read() and fs.readSync()

    PR-URL: #42837
    Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    2 people authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    68ed3c8 View commit details
    Browse the repository at this point in the history
  9. fs: add read(buffer[, options]) versions

    This adds the following:
    - `fs.read(fd, buffer[, options], callback)`.
    - `filehandle.read(buffer[, options])`.
    
    PR-URL: #42768
    Refs: #42601
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    LiviaMedeiros authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    784d84c View commit details
    Browse the repository at this point in the history
  10. doc: add additional step to security release process

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #42916
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    mhdawson authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    1237c74 View commit details
    Browse the repository at this point in the history
  11. src: fix memory leak for v8.serialize

    When Buffer::New passes in existing data,
    it cannot be garbage collected in js synchronous execution.
    
    Fixes: #40828
    Refs: #38300
    
    PR-URL: #42695
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
    liuxingbaoyu authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    cacff07 View commit details
    Browse the repository at this point in the history
  12. doc: fix examples in cluster.md

    PR-URL: #42889
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    y1d7ng authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    1fbfee2 View commit details
    Browse the repository at this point in the history
  13. doc: fix errors in Web Streams doc

    PR-URL: #42862
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    y1d7ng authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    3ab3086 View commit details
    Browse the repository at this point in the history
  14. http: added connection closing methods

    Fixes: #41578
    
    PR-URL: #42812
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ShogunPanda authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    2f192c4 View commit details
    Browse the repository at this point in the history
  15. test: use consistent timeouts

    PR-URL: #42893
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
    2 people authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    56c47b5 View commit details
    Browse the repository at this point in the history
  16. test: fix test-crypto-fips.js under shared OpenSSL

    Fixes: #42827
    
    PR-URL: #42947
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Vita Batrla authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    d746207 View commit details
    Browse the repository at this point in the history
  17. crypto: adjust minimum length in generateKey('hmac', ...)

    Also affects generateKeySync('hmac', ...)
    
    PR-URL: #42944
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    LiviaMedeiros authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    19c060f View commit details
    Browse the repository at this point in the history
  18. src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc

    Refs: #39941
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #42852
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    RaisinTen authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    8cfc18e View commit details
    Browse the repository at this point in the history
  19. deps: upgrade npm to 8.9.0

    PR-URL: #42968
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Myles Borins <myles.borins@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    npm-robot authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    2df1624 View commit details
    Browse the repository at this point in the history
  20. bootstrap: use a context snapshotted with primordials in workers

    PR-URL: #42867
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    joyeecheung authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    a20310d View commit details
    Browse the repository at this point in the history
  21. test: improve lib/internal/webstreams/readablestream.js coverage

    PR-URL: #42823
    Refs: https://coverage.nodejs.org/coverage-3a6b975981092213/lib/internal/webstreams/readablestream.js.html#L421
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    fossamagna authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    2dc7956 View commit details
    Browse the repository at this point in the history
  22. test: usemustSucceed instead of mustCall with assert.ifError

    PR-URL: #42806
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    fossamagna authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    b1c18ed View commit details
    Browse the repository at this point in the history
  23. test: validate webstream encoder/decoder inspector

    PR-URL: #42747
    Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    kuriyosh authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    d23debb View commit details
    Browse the repository at this point in the history
  24. test: improve observable ICU behaviour coverage

    PR-URL: #42683
    Refs: #42440
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    LiviaMedeiros authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    e058f47 View commit details
    Browse the repository at this point in the history
  25. bootstrap: stop delaying instantiation of maps in per-context scripts

    The linked issue, https://bugs.chromium.org/p/v8/issues/detail?id=6593,
    is marked as "Fixed", so I think we can revert this now.
    
    This reverts commit 08a9c4a.
    
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #42934
    Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9187
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    RaisinTen authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    1146806 View commit details
    Browse the repository at this point in the history
  26. test: rename handlewrap.hasref tests

    `HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename
    of related TCs has not been reflected.
    
    Refs: f31a5ec34a
    
    PR-URL: #42754
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    daeyeon authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    41d2f6e View commit details
    Browse the repository at this point in the history
  27. lib,test: enable wasm/webapi/empty-body WPT

    Refs: #42701
    Refs: nodejs/undici#1346
    Refs: #42939
    
    PR-URL: #42960
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    tniessen authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    c64b8d3 View commit details
    Browse the repository at this point in the history
  28. meta: move one or more collaborators to emeritus

    PR-URL: #42937
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    nodejs-github-bot authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    0ec32d0 View commit details
    Browse the repository at this point in the history
  29. build: fix indeterminacy of icu_locales value

    `icu_locales` is generated by joining values from `set` data structure.
    However, `set` doesn't guarantee an order, so the result of
    `icu_locales` is not determined. For example, the result value could be
    'en,root' or 'root,en'. This fix makes it deterministic.
    
    The main reason of this fix is to restore the reproducibility of the
    build because the value of `icu_locales` is embedded into `node` binary.
    
    PR-URL: #42865
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    3ap authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    48f4a71 View commit details
    Browse the repository at this point in the history
  30. doc: use serial comma in cluster docs

    Refs: #11321
    Refs: #17384
    
    PR-URL: #42989
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    tniessen authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    ba3ad7c View commit details
    Browse the repository at this point in the history
  31. doc: improve commit message example for releases

    PR-URL: #42954
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    juanarbol authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    840e61e View commit details
    Browse the repository at this point in the history
  32. build: fix various shared library build issues

    Node.js unofficially supports a shared library variant where the
    main node executable is a thin wrapper around node.dll/libnode.so.
    The key benefit of this is to support embedding Node.js in other
    applications.
    
    Since Node.js 12 there have been a number of issues preventing the
    shared library build from working correctly, primarily on Windows:
    
    * A number of functions used executables such as `mksnapshot` are
        not exported from `libnode.dll` using a `NODE_EXTERN` attribute
    * A dependency on the `Winmm` system library is missing
    * Incorrect defines on executable targets leads to `node.exe`
        claiming to export a number of functions that are actually in
        `libnode.dll`
    * Because `node.exe` attempts to export symbols, `node.lib` gets
        generated causing native extensions to try to link against
        `node.exe` not `libnode.dll`.
    * Similarly, because `node.dll` was renamed to `libnode.dll`,
        native extensions don't know to look for `libnode.lib` rather
        than `node.lib`.
    * On macOS an RPATH is added to find `libnode.dylib` relative to
        `node` in the same folder. This works fine from the
        `out/Release` folder but not from an installed prefix, where
        `node` will be in `bin/` and `libnode.dylib` will be in `lib/`.
    * Similarly on Linux, no RPATH is added so LD_LIBRARY_PATH needs
        setting correctly for `bin/node` to find `lib/libnode.so`.
    
    For the `libnode.lib` vs `node.lib` issue there are two possible
    options:
    
    1. Ensure `node.lib` from `node.exe` does not get generated, and
        instead copy `libnode.lib` to `node.lib`. This means addons
        compiled when referencing the correct `node.lib` file will
        correctly depend on `libnode.dll`. The down side is that
        native addons compiled with stock Node.js will still try to
        resolve symbols against node.exe rather than libnode.dll.
    2. After building `libnode.dll`, dump the exports using `dumpbin`,
        and process this to generate a `node.def` file to be linked into
        `node.exe` with the `/DEF:node.def` flag. The export entries
        in `node.def` will all read
        ```
        my_symbol=libnode.my_symbol
        ```
        so that `node.exe` will redirect all exported symbols back to
        `libnode.dll`. This has the benefit that addons compiled with
        stock Node.js will load correctly into `node.exe` from a shared
        library build, but means that every embedding executable also
        needs to perform this same trick.
    
    I went with the first option as it is the cleaner of the two
    solutions in my opinion. Projects wishing to generate a shared
    library variant of Node.js can now, for example,
    ```
    .\vcbuild dll package vs
    ```
    to generate a full node installation including `libnode.dll`,
    `Release\node.lib`, and all the necessary headers. Native addons
    can then be built against the shared library build easily by
    specifying the correct `nodedir` option.
    
    For example
    ```
    >npx node-gyp configure --nodedir
       C:\Users\User\node\Release\node-v18.0.0-win-x64
    ...
    >npx node-gyp build
    ...
    >dumpbin /dependents build\Release\binding.node
    Microsoft (R) COFF/PE Dumper Version 14.29.30136.0
    Copyright (C) Microsoft Corporation.  All rights reserved.
    
    Dump of file build\Release\binding.node
    
    File Type: DLL
    
      Image has the following dependencies:
    
        KERNEL32.dll
        libnode.dll
        VCRUNTIME140.dll
        api-ms-win-crt-string-l1-1-0.dll
        api-ms-win-crt-stdio-l1-1-0.dll
        api-ms-win-crt-runtime-l1-1-0.dll
    ...
    ```
    
    PR-URL: #41850
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    lux01 authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    0eb32ed View commit details
    Browse the repository at this point in the history
  33. assert: fix CallTracker wraps the function causes the length to be lost

    PR-URL: #42909
    Fixes: #40484
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    y1d7ng authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    7cac7bb View commit details
    Browse the repository at this point in the history
  34. worker: fix stream racing with terminate

    `OnStreamAfterReqFinished` uses `v8::Object::Has` to check if it needs
    to call `oncomplete`. `v8::Object::Has` needs to execute Javascript.
    However when worker threads are involved, `OnStreamAfterReqFinished` may
    be called after the worker thread termination has begun via
    `worker.terminate()`. This makes `v8::Object::Has` return `Nothing`,
    which triggers an assert.
    
    This diff fixes the issue by simply defaulting us to `false` in the case
    where `Nothing` is returned. This is sound because we can't execute
    `oncomplete` anyway as the isolate is terminating.
    
    Fixes: #38418
    
    PR-URL: #42874
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    airtable-keyhanvakil authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    5470578 View commit details
    Browse the repository at this point in the history
  35. src: always signal V8 for intercepted properties

    Closes: #42962
    
    PR-URL: #42963
    Fixes: #42962
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    targos authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    38e4c15 View commit details
    Browse the repository at this point in the history
  36. src: remove unnecessary comment

    PR-URL: #42952
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    cola119 authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    5dc7929 View commit details
    Browse the repository at this point in the history
  37. doc: use serial comma in tls docs

    Refs: #11321
    Refs: #17384
    
    PR-URL: #43001
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    65d6455 View commit details
    Browse the repository at this point in the history
  38. meta: update AUTHORS

    PR-URL: #43004
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Zeyu Yang <himself65@outlook.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    nodejs-github-bot authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    16df8ad View commit details
    Browse the repository at this point in the history
  39. tools: update lint-md-dependencies

    Update dependences to @rollup/plugin-node-resolve@13.3.0 and
    rollup@2.72.1.
    
    PR-URL: #43003
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    nodejs-github-bot authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    265ecdf View commit details
    Browse the repository at this point in the history
  40. tools: refactor lint-sh.js to esm module

    PR-URL: #42942
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    F3n67u authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    7987238 View commit details
    Browse the repository at this point in the history
  41. tools: update eslint to 8.15.0

    PR-URL: #43005
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    nodejs-github-bot authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    64daaca View commit details
    Browse the repository at this point in the history
  42. debugger: fix inconsistent inspector output of exec new Map()

    PR-URL: #42423
    Reviewed-By: Jan Krems <jan.krems@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    cola119 authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    946f57c View commit details
    Browse the repository at this point in the history
  43. lib: move WebAssembly Web API into separate file

    Refs: #42960 (comment)
    
    PR-URL: #42993
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    46a44b3 View commit details
    Browse the repository at this point in the history
  44. Revert "deps: add template for generated headers"

    This reverts commit 7fae2c9.
    
    Refs: #42976
    
    PR-URL: #42978
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    danbev authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    13c333e View commit details
    Browse the repository at this point in the history
  45. deps: regenerate OpenSSL archs files

    PR-URL: #42978
    Refs: #42976
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    danbev authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    e8121ae View commit details
    Browse the repository at this point in the history
  46. doc: rename N-API to Node-API in test/README.md

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    
    PR-URL: #42946
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Harshitha K P <harshitha014@gmail.com>
    daeyeon authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    64e0aa1 View commit details
    Browse the repository at this point in the history
  47. doc: add release key for Juan Arboleda

    PR-URL: #42961
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Adrian Estrada <edsadr@gmail.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    juanarbol authored and RafaelGSS committed May 10, 2022
    Configuration menu
    Copy the full SHA
    686c4c1 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. doc: add the preferred name for @himself65

    PR-URL: #43024
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    himself65 authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    4de918b View commit details
    Browse the repository at this point in the history
  2. doc: use serial comma in http docs

    Refs: #11321
    Refs: #17384
    
    PR-URL: #43026
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    tniessen authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    c988a0e View commit details
    Browse the repository at this point in the history
  3. wasm: add missing init reported by coverity

    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #42897
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Mestery <mestery@protonmail.com>
    mhdawson authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    55ef6e8 View commit details
    Browse the repository at this point in the history
  4. doc: add LiviaMedeiros to collaborators

    Fixes: #42828
    
    PR-URL: #43039
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Evan Lucas <evanlucas@me.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    LiviaMedeiros authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    4a3f678 View commit details
    Browse the repository at this point in the history
  5. doc: mark some node-api functions as experimental

    PR-URL: #42987
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    NickNaso authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    ef177da View commit details
    Browse the repository at this point in the history
  6. node-api: fix napi_get_all_property_names

    PR-URL: #42463
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    vmoroz authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    e2462a2 View commit details
    Browse the repository at this point in the history
  7. doc: add Rafael to the security steward for NearForm

    PR-URL: #42966
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mcollina authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    22cb710 View commit details
    Browse the repository at this point in the history
  8. meta: update .mailmap for recent README name change

    PR-URL: #43027
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Trott authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    174ff97 View commit details
    Browse the repository at this point in the history
  9. typings: fix os.cpus invalid return type

    PR-URL: #43006
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    himself65 authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    e9e1f1e View commit details
    Browse the repository at this point in the history
  10. doc: use consistent method symbol

    PR-URL: #42974
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    ShogunPanda authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    0957212 View commit details
    Browse the repository at this point in the history
  11. doc: use serial comma in buffer docs

    Refs: #11321
    Refs: #17384
    
    PR-URL: #43048
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    330e267 View commit details
    Browse the repository at this point in the history
  12. deps: upgrade openssl sources to quictls/openssl-3.0.3

    This updates all sources in deps/openssl/openssl by:
        $ git clone git@github.com:quictls/openssl.git
        $ cd openssl
        $ git checkout openssl-3.0.3+quic
        $ cd ../node/deps/openssl
        $ rm -rf openssl
        $ cp -R ../../../openssl openssl
        $ rm -rf openssl/.git* openssl/.travis*
        $ git add --all openssl
        $ git commit openssl
    
    PR-URL: #43022
    Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-May/000223.html
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    RafaelGSS authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    6365bf8 View commit details
    Browse the repository at this point in the history
  13. deps: update archs files for quictls/openssl-3.0.3+quic

    After an OpenSSL source update, all the config files need to be
    regenerated and committed by:
        $ make -C deps/openssl/config
        $ git add deps/openssl/config/archs
        $ git add deps/openssl/openssl
        $ git commit
    
    PR-URL: #43022
    Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-May/000223.html
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Beth Griggs <bgriggs@redhat.com>
    RafaelGSS authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    8e54c19 View commit details
    Browse the repository at this point in the history
  14. doc: add detail for how to update llhttp

    Add detail on how to update llhttp in deps to the
    guide for maintaining http.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #43028
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mhdawson authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    3816a97 View commit details
    Browse the repository at this point in the history
  15. deps: fix llhttp version number

    It's a bit confusing but I think that we acutally have
    llhttp version 6.0.6 in master versus 6.0.4. If I check
    out 6.0.4 from the llhttp repo and then generate a
    release it is missing changes from what we have in Node.js
    Checking out 6.0.6 seems to give the matching release
    artifacts.
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #43029
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    mhdawson authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    a4a4f71 View commit details
    Browse the repository at this point in the history
  16. doc: add maintaining info for shared libary option

    Refs: #41850
    
    I think it would be good to have some info/context
    for maintainers on the shared library option. Add that
    based on disussion in #41850
    
    Signed-off-by: Michael Dawson <mdawson@devrus.com>
    
    PR-URL: #42517
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
    mhdawson authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    eb630d7 View commit details
    Browse the repository at this point in the history
  17. doc: remove git:// protocol, adjust nits in onboarding.md

    PR-URL: #43045
    Refs: https://github.blog/2021-09-01-improving-git-protocol-security-github/
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    Reviewed-By: Richard Lau <rlau@redhat.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    LiviaMedeiros authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    1e9de0d View commit details
    Browse the repository at this point in the history
  18. doc: use serial comma in util docs

    Refs: #11321
    Refs: #17384
    
    PR-URL: #43063
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    76096c2 View commit details
    Browse the repository at this point in the history
  19. perf_hooks: add PerformanceResourceTiming

    perf_hooks: create clearResourceTimings
    
    perf_hooks: add resourcetiming test parallel
    
    perf_hooks: add markResourceTiming
    
    perf_hooks: fix observable when using resource
    
    perf_hooks: fix observable when using resource
    
    perf_hooks: add class comments
    
    perf_hooks: add PerformanceResourceTiming
    
    perf_hooks: create clearResourceTimings
    
    perf_hooks: add resourcetiming test parallel
    
    perf_hooks: add markResourceTiming
    
    perf_hooks: fix observable when using resource
    
    perf_hooks: fix observable when using resource
    
    perf_hooks: add class comments
    
    perf_hooks: add Resource Timing documentation
    
    benchmark: measure resource timing module
    
    perf_hooks: add check avoiding new PerformanceResourceTiming
    
    perf_hooks: adjust doc
    
    PR-URL: #42725
    Fixes: nodejs/undici#952
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    Reviewed-By: Paolo Insogna <paolo@cowtech.it>
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    RafaelGSS authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    c92e291 View commit details
    Browse the repository at this point in the history
  20. src: delete AllocatedBuffer

    Since all its uses are now gone, it's time to say goodbye to
    AllocatedBuffer.
    
    Refs: #39941
    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    
    PR-URL: #43008
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    RaisinTen authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    c535db1 View commit details
    Browse the repository at this point in the history
  21. node-api: explicitly set __cdecl for API functions

    PR-URL: #42780
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    vmoroz authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    037ff3d View commit details
    Browse the repository at this point in the history
  22. deps: remove opensslconf template headers

    This commit removes the header template files opensslconf.h as it is not
    a generated header anymore (configuration.h is the generated header
    now).
    
    The motivation for this is that not using opensslconf.h from the OpenSSL
    include directory means an addon that includes openssl/ssl.h will get
    the following error:
    
    ~/.cache/node-gyp/17.8.0/include/node/openssl/macros.h:148:4: error:
     compatibility level"
      148 | #  error "The requested API level higher than the configured
     API compatibility level"
    
    For more details please see #40575.
    
    PR-URL: #43035
    Fixes: #40575
    Reviewed-By: Michael Dawson <midawson@redhat.com>
    danbev authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    a9703a5 View commit details
    Browse the repository at this point in the history
  23. build: disable windows-2022 temporarily

    PR-URL: #43093
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    gengjiawen authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    7c4df42 View commit details
    Browse the repository at this point in the history
  24. doc: use serial comma in modules docs

    Refs: #11321
    Refs: #17384
    
    PR-URL: #43103
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    tniessen authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    9629c74 View commit details
    Browse the repository at this point in the history
  25. meta: add mailmap entry for ShogunPanda

    PR-URL: #43094
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    ShogunPanda authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    ddd271e View commit details
    Browse the repository at this point in the history
  26. fs: remove unnecessary ?? operator

    This was introduced in 57678e5
    
    With the `if` conditional around this statement, `options` will always
    be evaluated as truthy. That means that the nullish coalescing operator
    will always evaluate to the left side, make it unnecessary.
    
    PR-URL: #43073
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
    Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
    mroderick authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    becca06 View commit details
    Browse the repository at this point in the history
  27. build: set ASAN workaround

    PR-URL: #43085
    Refs: google/sanitizers#1322
    Refs: #43082
    Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    richardlau authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    cec678a View commit details
    Browse the repository at this point in the history
  28. deps: update undici to 5.2.0

    PR-URL: #43059
    Reviewed-By: Robert Nagy <ronagy@icloud.com>
    Reviewed-By: Filip Skokan <panva.ip@gmail.com>
    Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    nodejs-github-bot authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    d128356 View commit details
    Browse the repository at this point in the history
  29. tools: update lint-md-dependencies to rollup@2.73.0

    PR-URL: #43107
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
    nodejs-github-bot authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    531a0a9 View commit details
    Browse the repository at this point in the history
  30. test: reduce flakiness of test-fs-read-position-validation.mjs

    PR-URL: #42999
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    LiviaMedeiros authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    9eb8bf1 View commit details
    Browse the repository at this point in the history
  31. doc: use serial comma in events docs

    Refs: #11321
    Refs: #17384
    
    PR-URL: #43113
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    tniessen authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    839824a View commit details
    Browse the repository at this point in the history
  32. doc: use serial comma in fs docs

    Refs: #11321
    Refs: #17384
    
    PR-URL: #43104
    Reviewed-By: LiviaMedeiros <livia@cirno.name>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Darshan Sen <raisinten@gmail.com>
    tniessen authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    f53ed9d View commit details
    Browse the repository at this point in the history
  33. test: fix dangerous .map in test/parallel/test-http-set-trailers.js

    PR-URL: #43087
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>
    LiviaMedeiros authored and BethGriggs committed May 16, 2022
    Configuration menu
    Copy the full SHA
    0670843 View commit details
    Browse the repository at this point in the history
  34. 2022-05-17, Version 18.2.0 (Current)

    Notable changes:
    
    OpenSSL 3.0.3
    
    This update can be treated as a security release as the issues addressed
    in OpenSSL 3.0.3 slightly affect Node.js 18. See https://nodejs.org/en/blog/vulnerability/openssl-fixes-in-regular-releases-may2022/
    for more information on how the May 2022 OpenSSL releases affect other
    Node.js release lines.
    
    - deps: update archs files for quictls/openssl-3.0.3+quic
      (RafaelGSS) #43022
    - deps: upgrade openssl sources to quictls/openssl-3.0.3
      (RafaelGSS) #43022
    
    Other notable changes:
    
    - _Revert_ "deps: add template for generated headers"
      (Daniel Bevenius) #42978
    - deps: update undici to 5.2.0
      (Node.js GitHub Bot) #43059
    - deps: upgrade npm to 8.9.0
      (npm team) #42968
    - (SEMVER-MINOR) fs: add `read(buffer[, options])` versions
      (LiviaMedeiros) #42768
    - (SEMVER-MINOR) http: added connection closing methods
      (Shogun) #42812
    - doc: add LiviaMedeiros to collaborators
      (LiviaMedeiros) #43039
    - doc: add release key for Juan Arboleda
      (Juan José) #42961
    - (SEMVER-MINOR) fs: add `read(buffer[, options])` versions
      (LiviaMedeiros) #42768
    - (SEMVER-MINOR) http: added connection closing methods
      (Paolo Insogna) #42812
    - (SEMVER-MINOR) perf_hooks: add PerformanceResourceTiming
      (RafaelGSS) #42725
    
    PR-URL: #43036
    RafaelGSS committed May 16, 2022
    Configuration menu
    Copy the full SHA
    1531ef1 View commit details
    Browse the repository at this point in the history