Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6.6.0 proposal #8466

Merged
merged 113 commits into from
Sep 15, 2016
Merged

v6.6.0 proposal #8466

merged 113 commits into from
Sep 15, 2016

Conversation

Fishrock123
Copy link
Member

@Fishrock123 Fishrock123 commented Sep 9, 2016 •
edited
Loading

Moving from #8457 to fix the staging merge process.

CI: https://ci.nodejs.org/job/node-test-pull-request/3986/

Patch Notes:

  • events: Made the "max event emitters" memory leak warning more accessible. (Anna Henningsen) #8298
  • promises: Unhandled rejections now emit a process warning after the first tick. (Benjamin Gruenbaum) #8223
  • repl: Added auto alignment for .editor mode. (Prince J Wesley) #8241
  • util: Some functionality has been added to util.inspect():
    • Returning this from a custom inspect function now works. (Anna Henningsen) #8174
    • Added support for Symbol-based custom inspection methods. (Anna Henningsen) #8174

addaleax and others added 2 commits September 8, 2016 10:27
@addaleax
deps: cherry-pick 8ed65b97 from V8's upstream
f829660 
Original commit message:

    Make FieldType::None() non-nullptr value to avoid undefined behaviour

    When FieldType::None() returns a cast Smi::FromInt(0), which translates
    as nullptr, the FieldType::IsNone() check becomes equivalent to
    `this == nullptr` which is not allowed by the standard and
    therefore optimized away as a false constant by GCC 6.

    This has lead to crashes when invoking methods on FieldType::None().

    Using a different Smi constant for FieldType::None() makes the compiler
    always include a comparison against that value. The choice of these
    constants has no effect as they are effectively arbitrary.

    BUG=#8310

    Review-Url: https://codereview.chromium.org/2292953002
    Cr-Commit-Position: refs/heads/master@{#39023}

Fixes: #8310
PR-URL: #8411
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@Trott @Fishrock123
test: refactor test-util-inspect
6f269be 
* favor `assert.strictEqual()` and friends of `assert.equal()` etc.
* favor `.includes()` over `.indexOf()` for existence checks

PR-URL: #8189
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: #8437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123 Fishrock123 added meta Issues and PRs related to the general management of the project. v6.x labels Sep 9, 2016
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Sep 9, 2016
@Fishrock123 Fishrock123 changed the base branch from master to v6.x September 9, 2016 14:45
@Fishrock123 Fishrock123 mentioned this pull request Sep 9, 2016
Closed
@Fishrock123 Fishrock123 removed build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Sep 9, 2016
@Fishrock123 Fishrock123 mentioned this pull request Sep 9, 2016
Open
addaleax and others added 16 commits September 9, 2016 11:06
@addaleax @Fishrock123
util: allow symbol-based custom inspection methods
4cb55ff 
Add a `util.inspect.custom` Symbol which can be used to customize
`util.inspect()` output. Providing `obj[util.inspect.custom]`
works like providing `obj.inspect`, except that the former allows
avoiding name clashes with other `inspect()` methods.

Fixes: #8071
PR-URL: #8174
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

Refs: #8437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@addaleax @Fishrock123
util: allow returning this from custom inspect
e9c4805 
If a custom inspection function returned `this`, use that value
for further formatting instead of going into infinite recursion.

This is particularly useful when combined with `util.inspect.custom`
because returning `this` from such a method makes it easy to
have an `inspect()` function that is ignored by `util.inspect` without
actually having to provide an alternative for custom inspection.

PR-URL: #8174
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

Refs: #8437
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@imyller @Fishrock123
url: url.format() encodes all # in search
eec5d02 
This commit fixes an error where only the first occurrence of `#` in
`search` parameter is URL encoded, and subsequent occurrences are not.

Also added a test for the case.

Fixes: #8064
PR-URL: #8072
Reviewed-By: James M Snell <jasnell@gmail.com>

 Conflicts:
	test/parallel/test-url.js
@imyller @Fishrock123
url: keep auth in url.resolve() if host matches
6ae7af0 
Fixes: #8165

PR-URL: #8215
Reviewed-By: James M Snell <jasnell@gmail.com>
@thefourtheye @Fishrock123
doc: include the optional options parameter
03f5297 
`mkdtemp` functions accept an optional `options` parameter, which can
be either a String specifying encoding, or an Object with an `encoding`
property.

PR-URL: #7842
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
@hefangshi @Fishrock123
doc: fix "timout" typo in timeout
e4fcf55 
Corrected to `timeout`

PR-URL: #8231
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@mozkeeler @Fishrock123
doc: fix buf.readUIntBE, buf.readUIntLE examples
a7c2175 
The documentation describing the output from the examples for
buf.readUIntBE and buf.readUIntLE were switched in terms of what the
code would actually output. This patch addresses this by switching the
two lines of example code to be in the same order as the functions are
listed earlier in the documentation.

PR-URL: #8240
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
@rvagg @Fishrock123
doc: add Myles Borins to the CTC
260663f 
PR-URL: #8260
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@lpinca @Fishrock123
doc: add added: information for dgram
93ac875 
PR-URL: #8196
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@yorkie @Fishrock123
async_wrap: add a missing case to test-async-wrap-throw-no-init
2ecc8c4 
PR-URL: #8198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@richardlau @Fishrock123
build: add missing files to zip and 7z packages
206b105 
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.

PR-URL: #8069
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson @Fishrock123
build: fix dependencies on AIX
bc9d2fb 
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.

Fixes: #8239
PR-URL: #8272
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@mhdawson @Fishrock123
test: mark test-child-process-fork-dgram as flaky
0f977f9 
PR-URL: #8274
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@thefourtheye @Fishrock123
util: improve function signature of util._extend
d67ece2 
The function signature of `util._extend` is not intuitive and the
documentation doesn't specify the necessary second parameter. This
patch changes the parameter names in the code and the function params
in doc.

PR-URL: #8187
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@jasnell @Fishrock123
test: clean up / refactor buffer tests, remove duplication
0b0a1ce 
Remove duplication of buffer tests, separate out into separate
files, update and cleanup code, move to using strictEqual where
possible.

PR-URL: #8256
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>

 Conflicts:
	test/parallel/test-buffer-alloc.js
	test/parallel/test-buffer.js
	test/parallel/test-buffer-no-negative-allocation.js
@mscdex @Fishrock123
http: fix connection upgrade checks
fa4c4d6 
This commit fixes connection upgrade checks, specifically when headers
are passed as an array instead of a plain object to http.request()

Fixes: #8235
PR-URL: #8238
Reviewed-By: James M Snell <jasnell@gmail.com>
mhdawson and others added 12 commits September 13, 2016 17:04
@mhdawson @Fishrock123
test: skip pseudo-tty/no_dropped_stdio test
3294c2c 
We had marked it as flaky but in some failures it hangs
and does not seem to timeout, and or is reported as
an error.

Also add prefix to status file as it was missing.

Also fix name of status file in testcfg.py. It
was pointing to message.status instead of
pseudo-tty.status.

PR-URL: #8470
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@joshgav @Fishrock123
doc: add CTC meeting minutes 2016-08-31
92acff8 
PR-URL: #8424
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott @Fishrock123
test: refactor test-net-pipe-connect-errors
d2b6b66 
* var -> const
* try/catch -> assert.throws()
* assert.ok(fail) -> common.fail()
* assert.equal() -> assert.strictEqual()
* replace `exit` handler with `common.mustCall()`

PR-URL: #8473
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@HyperSprite @Fishrock123
test: swapped == and equal to === and strictEqual
1a30fe5 
Line 21 used '==' for a Number comparison, changed to '===''.
Lines 36 and 46 used 'assert.equal', changed to 'assert.strictEqual'.
Lines 2, 3 and 4 require statements used var, changed to const.

PR-URL: #8472
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@pogilvie @Fishrock123
test: modernize JS and tighten equality checking
2ce364a 
Node todo process example with the follow test-net-binary.js changes:

var --> const where applicable

==, assert.equal--> ===, assert.strictEqual for all cases

PR-URL: #8476
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott @Fishrock123
tools: fix new-parens violations
ef5cb12 
PR-URL: #8478
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott @Fishrock123
tools: update ESLint to 3.5.0
36235ac 
PR-URL: #8478
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott @Fishrock123
tools: replace custom ESLint rule with built-in
f47ce9d 
ESLint 3.5.0 introduces a `no-restricted-properties` rule. Replace our
custom `no-deepEqual` rule with this rule.

PR-URL: #8478
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott @Fishrock123
doc: update onboarding PR landing info
ce1a46c 
Clarify a few items in the onboarding doc about landing a PR. One
addition is to include the optional `Refs:` metadata.

PR-URL: #8479
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jun-oka @Fishrock123
test: refector parallel/test-http.js
3358861 
* favor ’===’ over in ’==’
* favor ’assert.strictEqual’ over ’assert.equal’
* favor ’const’ over ’var’

PR-URL: #8471
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@indutny @Fishrock123
tickprocessor: apply c++filt manually on mac
eff771f 
`/bin/sh -c` trick wasn't working for several reasons:

* `/bin/sh -c "..."` expects the first argument after `"..."` to be a
  `$0`, not a `$1`. Previously `-n` wasn't passed to `nm` because of
  this, and many symbols were ordered improperly
* `c++filt` was applied not only to the names of the functions but to
  their `nm` prefixes like `t` and `a` (`t xxx` turns into
  `unsigned char xxx`).

Instead of applying `c++filt` wide and using `sh -c`, execute `nm` as
requested by `deps/v8/tools/tickprocessor.js` and apply `c++filt` to all
matching entries manually.

Included test demonstrates where previous approach failed: all builtins
were merged into `v8::internal::Builtins::~Builtins`, because they were
prefixed by `t` in `nm` output.

PR-URL: #8480
Reviewed-By: Matthew Loring <mattloring@google.com>
@italoacasas @Fishrock123
doc: link SIGTSTP / SIGCONT events in readline doc
c48cb2d 
PR-URL: #8475
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Fishrock123
Copy link
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/4039/

Release probably tonight / tomorrow morning if all goes well.

@Fishrock123
2016-09-14, Version 6.6.0 (Current)
0a3ad92 
Notable changes:

* crypto: Added `crypto.timingSafeEqual()`. (not-an-aardvark)
#8304
* events: Made the "max event listeners" memory leak warning more
accessible. (Anna Henningsen) #8298
* promises: Unhandled rejections now emit a process warning after the
first tick. (Benjamin Gruenbaum)
#8223
* repl: Added auto alignment for `.editor` mode. (Prince J Wesley)
#8241
* util: Some functionality has been added to `util.inspect()`:
- Returning `this` from a custom inspect function now works. (Anna
Henningsen) #8174
- Added support for Symbol-based custom inspection methods. (Anna
Henningsen) #8174

Refs: #8428
Refs: #8457
PR-URL: #8466
@Fishrock123
Copy link
Member Author

Building at https://ci-release.nodejs.org/job/iojs+release/1154/ -- hopefully I did stuff correctly.

@Fishrock123
Copy link
Member Author

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/383/

@Fishrock123
Copy link
Member Author

@thealphanerd I'm getting this on ubuntu1204-64:

   51 passing (30s)
   1 failing
   1) bin/uglifyjs should produce a functional build when using --self:
      Error: timeout of 5000ms exceeded. Ensure the done() callback is being called in this test.

Any ideas? Look familiar?

@Fishrock123
Copy link
Member Author

Also two failures on OS X? https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/383/nodes=osx1010/

@MylesBorins
Copy link
Member

osx failures are time outs, the ubuntu failure timeout seem like nbd to me.

@Fishrock123 Fishrock123 merged commit 0a3ad92 into v6.x Sep 15, 2016
Fishrock123 added a commit to Fishrock123/node that referenced this pull request Sep 15, 2016
@Fishrock123
2016-09-14, Version 6.6.0 (Current)
ea2a309 
Notable changes:

* crypto: Added `crypto.timingSafeEqual()`. (not-an-aardvark)
nodejs#8304
* events: Made the "max event listeners" memory leak warning more
accessible. (Anna Henningsen) nodejs#8298
* promises: Unhandled rejections now emit a process warning after the
first tick. (Benjamin Gruenbaum)
nodejs#8223
* repl: Added auto alignment for `.editor` mode. (Prince J Wesley)
nodejs#8241
* util: Some functionality has been added to `util.inspect()`:
- Returning `this` from a custom inspect function now works. (Anna
Henningsen) nodejs#8174
- Added support for Symbol-based custom inspection methods. (Anna
Henningsen) nodejs#8174

Refs: nodejs#8428
Refs: nodejs#8457
PR-URL: nodejs#8466
Fishrock123 added a commit to nodejs/nodejs.org that referenced this pull request Sep 15, 2016
@Fishrock123
Blog: v6.6.0 release post
b13fdab 
Refs: nodejs/node#8466
Fishrock123 added a commit that referenced this pull request Sep 15, 2016
@Fishrock123
Working on v6.6.1
7d9afc7 
PR-URL: #8466
@Fishrock123 Fishrock123 deleted the v6.6.0-proposal branch September 15, 2016 21:11
@gibfahn gibfahn mentioned this pull request Sep 16, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet