Skip to content

Conversation

@DanielAlvesLABDH
Copy link
Contributor

@DanielAlvesLABDH DanielAlvesLABDH commented Jun 21, 2022

Publicar a tradução da lição Introduction to MySQL with R

Checklist

If you are having difficulty fixing build errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Build Errors". Then contact the technical team if you need further help.

Corrigir link para o dataset
Corrigir links das imagens
Incluir Python nos topics
Corrigir links para conjuntos de dados
@DanielAlvesLABDH
Copy link
Contributor Author

Hi @anisa-hawes, this PR fails because of a broken link in the lesson https://programminghistorian.org/en/lessons/extracting-illustrated-pages. The broken link is https://requests.readthedocs.io/en/master/. The main website works (https://requests.readthedocs.io/en/latest/), but I can't identify the correct or updated link. Can you help? Thanks

@anisa-hawes
Copy link
Contributor

Hello @DanielAlvesLABDH.

I wonder if https://requests.readthedocs.io/en/latest/user/install/#install would be a good substitution in this case. This page covers the steps towards Installation of Requests, which seems right for the context.

I'm happy to update the link in /en/lessons/extracting-illustrated-pages so that you can move this PR, and PR 2605 forwards.

If it doesn't cause you too much delay, I'd also like to recommend that we take this opportunity before publication to replace all external links in these two new PT lessons, with perma.cc archival links. I can do that this afternoon, and will update you when they're ready.

Thank you for your patience,
Anisa

Replace broken link, line 78.
@DanielAlvesLABDH
Copy link
Contributor Author

Hi @anisa-hawes that would be a great help, yes! Many thanks!

Add new IPP: Sussex Humanities Lab
Add new IPP: Sussex Humanities Lab
Add new IPP: Sussex Humanities Lab
Add new IPP: Sussex Humanities Lab
@anisa-hawes
Copy link
Contributor

Hello @DanielAlvesLABDH. Wonderful news! @ZoeLeBlanc has worked her magic ✨ and this PR is ready to go! Thank you again for your patience. Anisa

@DanielAlvesLABDH
Copy link
Contributor Author

Wonderful news @anisa-hawes ! Many, many thanks @ZoeLeBlanc , what a great work! Magical indeed
Anita, could you approve this? I already made the changes requested. Thanks

@DanielAlvesLABDH DanielAlvesLABDH dismissed aracele’s stale review July 27, 2022 19:24

changes are already implemented and approved

@DanielAlvesLABDH DanielAlvesLABDH merged commit eeb5ac3 into gh-pages Jul 27, 2022
@anisa-hawes anisa-hawes deleted the Publicar_introducao-mysql-r branch July 27, 2022 19:26
@anisa-hawes
Copy link
Contributor

anisa-hawes commented Jul 28, 2022

Dear @DanielAlvesLABDH, I have a question about how this lesson has been dated. It is the most recently published, yet I notice that it doesn't appear at the top of the list shown in Índice de Lições when I order the lessons by date. I note that the YAML header specifies:

date: 2018-05-03
translation_date: 2021-12-18

Do you think it would be preferable to adjust the translation_date so that it reflects the date the translation has been published (rather than when the translator completed their work, which was before the peer review and revision process began)? Let me know if this is something which has already been discussed/agreed ! But I'd be interested to better understand how other editors of translations use this field. Perhaps @rivaquiroga or @spapastamkou could share their practice?

@DanielAlvesLABDH
Copy link
Contributor Author

Hi @anisa-hawes. Thanks for the comment. I have been using the date of the creation of the revision ticket as the date of the translation. I keep that consistent, so if we agree that it should be the date of publication, we can change. If that is the date used in the other teams for me it's fine

@anisa-hawes
Copy link
Contributor

Ah, okay. Do you know if that is how the other MEs do it too?

My question is linked to the understanding that the date: field represents the date that the original lesson was published.

I'd be interested to hear how Riva, Sofia and Sarah use the date: and translation_date: fields. I could open an Issue to discuss/agree this?

@rivaquiroga
Copy link
Member

At the Spanish team we use publication date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants