This repository was archived by the owner on Aug 12, 2022. It is now read-only.
[MASTER] Release/2020 09 14 #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more analytics events, and use action as event type
update new_block event
Refactor the native interface in preparation for switching iOS to use WKWebview. * Finally rename the folder for device specific interfaces as `tablet` instead of `iPad` * Update `import` statements to use the new name * Create new `iOS.js` and `Android.js` based on previous `iPad/iOS.js` to separate the interfaces * Add new `OS.js` class to manage the class variables, initialize the device interface delegate methods to the correct interface. * refactor how `utils/lib` detects the current platform based on `navigtor.userAgent` based on https://stackoverflow.com/questions/37591279/detect-if-user-is-using-webview-for-android-ios-or-a-regular-browser. previous method relied on the Android interface being loaded or not. It can be difficult to detect the difference between in a browser and in a webview, but for now ScratchJr doesn’t need to worry about running in a browser
Android Studio added some more config files.
removing dead code that was just commented in the previous commit,
Split iOS and Android interfaces
add generic setAnalyticsPref functions for iOS and Android
Upgrade webview to WKWebView with many thanks to @yueyuzhao * Need to debug a problem saving thumbnails on iOS 9.3.5 * Needs much more testing
add support for custom options questions at app start; refactor index.js
many thanks @yueyuzhao
Don’t pass NSNulls to Firebase. Paramaters must be string or integer, so use ‘undefined’ to match current values.
at least 90% reviewed for the source file '/editions/free/src/localizations/en.json' on the 'ca' language. Manual sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
at least 90% reviewed for the source file '/editions/free/src/localizations/en.json' on the 'zh_CN' language. Manual sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
at least 90% reviewed for the source file '/editions/free/src/localizations/en.json' on the 'zh_TW' language. Manual sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
at least 90% reviewed for the source file '/editions/free/src/localizations/en.json' on the 'pl' language. Manual sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
at least 90% reviewed for the source file '/editions/free/src/localizations/en.json' on the 'pt' language. Manual sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
at least 90% reviewed for the source file '/editions/free/src/localizations/en.json' on the 'pt_BR' language. Manual sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
at least 90% reviewed for the source file '/editions/free/src/localizations/en.json' on the 'es' language. Manual sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
at least 90% reviewed for the source file '/editions/free/src/localizations/en.json' on the 'th' language. Manual sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
at least 90% reviewed for the source file '/editions/free/src/localizations/en.json' on the 'tr' language. Manual sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
at least 90% reviewed for the source file '/editions/free/src/localizations/en.json' on the 'cy' language. Manual sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format
…izations-en-json--develop_ca Translate '/editions/free/src/localizations/en.json' in 'ca' [manual sync]
…izations-en-json--develop_zh_CN Translate '/editions/free/src/localizations/en.json' in 'zh_CN' [manual sync]
…izations-en-json--develop_zh_TW Translate '/editions/free/src/localizations/en.json' in 'zh_TW' [manual sync]
…izations-en-json--develop_fr Translate '/editions/free/src/localizations/en.json' in 'fr' [manual sync]
…izations-en-json--develop_el Translate '/editions/free/src/localizations/en.json' in 'el' [manual sync]
…izations-en-json--develop_it Translate '/editions/free/src/localizations/en.json' in 'it' [manual sync]
…izations-en-json--develop_ja Translate '/editions/free/src/localizations/en.json' in 'ja' [manual sync]
…izations-en-json--develop_no Translate '/editions/free/src/localizations/en.json' in 'no' [manual sync]
…izations-en-json--develop_pl Translate '/editions/free/src/localizations/en.json' in 'pl' [manual sync]
…izations-en-json--develop_pt Translate '/editions/free/src/localizations/en.json' in 'pt' [manual sync]
…izations-en-json--develop_pt_BR Translate '/editions/free/src/localizations/en.json' in 'pt_BR' [manual sync]
…izations-en-json--develop_es Translate '/editions/free/src/localizations/en.json' in 'es' [manual sync]
…izations-en-json--develop_th Translate '/editions/free/src/localizations/en.json' in 'th' [manual sync]
…izations-en-json--develop_tr Translate '/editions/free/src/localizations/en.json' in 'tr' [manual sync]
…izations-en-json--develop_cy Translate '/editions/free/src/localizations/en.json' in 'cy' [manual sync]
Issue/274 wkwebview rebase
fix buzz bug when initialOptions missing from settings
Add new languages to menu
Pull develop into release branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
September 2020 update for ScratchJr