Conversation
…M-5665_instant-review
…M-5665_instant-review
PM-5700 Merge V9 engagements work to dev
Ai suggest button for skills
PM-5665 instant review
What was broken Members whose submissions failed screening on completed Design challenges saw an empty Screening tab instead of their result and scorecard link. Root cause The completed-challenge visibility filter returned an empty row set for non-privileged viewers below the screening threshold before the ownership filter could retain the viewer's own submission. What was changed Allow below-threshold viewers to fall through to the existing ownership filter, preserving access to their own screening result while keeping other members' rows hidden. Any added/updated tests Added a TabContentScreening regression test covering a completed challenge with owned and foreign failed submissions.
What was broken Members could not narrow My Past Challenges to challenges where they served in a reviewer role. Root cause The page had no role control, and its request service and state did not carry resource-role filters to the review API. What was changed Added an All roles/Reviewer filter backed by the eight reviewer resource-role IDs identified for PM-5471. The selection is serialized to the API, retained across sorting and pagination, and removed by Clear. Any added/updated tests Added page and hook tests for the role options, all eight IDs, pagination persistence, and clearing. Updated the review service test for comma-separated query serialization.
What was broken A task could be persisted as DRAFT while the create page continued to show NEW and the NEW-only Delete action after assignee synchronization failed for unsigned terms. Root cause The challenge status callback ran only after the separate resource assignment request completed, even though the challenge PATCH had already committed the DRAFT transition. What was changed Publish the persisted challenge status immediately after the PATCH succeeds so later assignment errors cannot leave stale header actions. Document the partial-save behavior. Any added/updated tests Added form coverage for an unsigned-assignee resource failure after a successful DRAFT PATCH, plus page coverage confirming DRAFT removes Delete.
What was broken Project Managers could see projects with billing accounts, but searching for those accounts in the Projects filter returned no options. Root cause (if identifiable) The async filter returned only Billing Accounts API matches. Project Managers can see project-assigned accounts that are intentionally absent from their direct billing-account grants, and the loader ignored options already derived from visible projects. What was changed Merged case-insensitive matches from visible project billing accounts with remote search results, retaining local matches if remote search fails. Any added/updated tests Added a ProjectsFilter regression test confirming a Project Manager can find Platform Dev - One from a visible project when the API returns no matching accounts.
PM-5471: add reviewer filter to past challenges
PM-5522: Reconcile draft status after partial save
PM-5557: Include project billing accounts in filter search
What was broken Virus-scan failures appeared as Pending in the AI-only Approval table even though the expanded reviewer details showed the Virus Scan as failed. Root cause Infected submissions do not continue to AI decision creation, and the Approval status renderer defaulted every submission without a decision to Pending. What was changed Failed file-submission virus scans now take precedence over AI decision status and render as Infected using the existing failed-status styling. Any added/updated tests Added a focused Approval table regression test covering an infected submission and preserving the normal Pending fallback.
PM-5708: Show failed screening results to submitters
PM-5609: Show infected status for failed virus scans
What was broken QA found that the Role filter was vertically lower than Challenge Name and offered only Reviewer, omitting Copilot and Submitter. Root cause The first filter row bottom-aligned controls even though the shared text input reserves space for inline errors, which pushed the Role control down. The role option configuration also included only the reviewer role group. What was changed Added Copilot and Submitter using their active resource-role IDs, and top-aligned the first filter row so its labels and controls are even. Any added/updated tests Updated the past reviews page tests to cover all four role options and verify that Copilot and Submitter selections request their respective resource-role IDs.
PM-5471: complete past challenge role filter
PM-5710 Add extra fields to engagements
PM-5700 Fix QA feedback on engagements
…w-field PM-5695 - expose workflow for runs
What was broken The Test Challenge checkbox added by the earlier PM-5802 implementation was not shown in Work Manager's Advanced Options section. Root cause The field was rendered unconditionally in Basic Information, and its tests only queried the page globally instead of checking the required section. What was changed Keep the checkbox in Basic Information before the first save so the test metadata can be sent on initial creation, then render it in Advanced Options for saved challenges. Update the challenge editor documentation to describe the two-stage placement. Any added/updated tests Update ChallengeEditorForm coverage to verify a persisted test flag is checked in Advanced Options and absent from Basic Information on edit. The focused PM-5802 tests, lint, and production build pass; the full suite retains the same pre-existing failures as origin/dev.
What was broken The edit-footer cancellation status menu extended beyond the left edge of the viewport, so QA could not see the complete menu. Root cause The previous follow-up reused the header-oriented cancellation action in the form's left footer slot. Its 280px menu remained right-aligned to the narrow trigger and expanded offscreen to the left. What was changed Added an optional start alignment for the cancellation menu and enabled it only for the edit-footer action. Header and read-only footer actions retain their existing end alignment, and the challenge editor documentation now describes the footer behavior. Any added/updated tests Extended ChallengeEditorPage coverage to verify that the edit-footer cancellation menu receives the start-alignment modifier while preserving the existing status selection, confirmation, PATCH, and refresh assertions.
What was broken Task challenge setup in the Work app displayed a Copilot Fee field, allowing project managers to bundle a copilot payment with the task. Root cause The challenge editor rendered the copilot fee input for every billable challenge without considering the resolved task challenge state. What was changed - Hide the copilot fee input and its layout column for task challenges. - Keep copilot assignment and the rest of task billing unchanged. - Preserve the copilot fee input for non-task challenges and document the task-only restriction. Any added/updated tests - Added form coverage that verifies task challenges hide the fee while retaining copilot assignment and billing. - Added coverage that verifies non-task challenges still show the fee.
PM-5802: show test flag in advanced options
PM-5757: Keep footer cancel menu visible
PM-5800: Hide copilot fee for task challenges
…-header PM-5695 - fix scorecard header
Fix icon & score for deterministic UI
PM- 5810,5809 Engagements v9 changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-5701
https://topcoder.atlassian.net/browse/PM-5702
https://topcoder.atlassian.net/browse/PM-5705
https://topcoder.atlassian.net/browse/PM-5665
https://topcoder.atlassian.net/browse/PM-5738
https://topcoder.atlassian.net/browse/PM-5710
https://topcoder.atlassian.net/browse/PM-5776
https://topcoder.atlassian.net/browse/PM-5708
https://topcoder.atlassian.net/browse/PM-5471
https://topcoder.atlassian.net/browse/PM-5522
https://topcoder.atlassian.net/browse/PM-5557
https://topcoder.atlassian.net/browse/PM-5609
https://topcoder.atlassian.net/browse/PM-5778
https://topcoder.atlassian.net/browse/PM-5711
https://topcoder.atlassian.net/browse/PM-5695
https://topcoder.atlassian.net/browse/PM-5636
https://topcoder.atlassian.net/browse/PM-5725
https://topcoder.atlassian.net/browse/PM-5722
https://topcoder.atlassian.net/browse/PM-5771
https://topcoder.atlassian.net/browse/PM-5770
https://topcoder.atlassian.net/browse/PM-5765
https://topcoder.atlassian.net/browse/PM-5757
https://topcoder.atlassian.net/browse/PM-5713
https://topcoder.atlassian.net/browse/PM-5756
https://topcoder.atlassian.net/browse/PM-5754
https://topcoder.atlassian.net/browse/PM-5750
https://topcoder.atlassian.net/browse/PM-5764
https://topcoder.atlassian.net/browse/PM-5767
https://topcoder.atlassian.net/browse/PM-5773
https://topcoder.atlassian.net/browse/PM-5775
https://topcoder.atlassian.net/browse/PM-5719
https://topcoder.atlassian.net/browse/PM-5714
https://topcoder.atlassian.net/browse/PM-5715
https://topcoder.atlassian.net/browse/PM-5784
https://topcoder.atlassian.net/browse/PM-5435
https://topcoder.atlassian.net/browse/PM-5695
https://topcoder.atlassian.net/browse/PM-5802
https://topcoder.atlassian.net/browse/PM-5800
https://topcoder.atlassian.net/browse/PM-5809
https://topcoder.atlassian.net/browse/PM-5810
https://topcoder.atlassian.net/browse/PM-5816