Skip to content

feat(core-snapshots): add support for transaction nonces#2925

Merged
faustbrian merged 13 commits intodevelopfrom
snapshots-nonce
Oct 5, 2019
Merged

feat(core-snapshots): add support for transaction nonces#2925
faustbrian merged 13 commits intodevelopfrom
snapshots-nonce

Conversation

@vasild
Copy link
Copy Markdown
Contributor

@vasild vasild commented Sep 13, 2019

A summary of what changes this PR introduces and why they were made.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@spkjp
Copy link
Copy Markdown
Contributor

spkjp commented Sep 14, 2019

I get the following error when I restore a fresh dump made on this branch:

[2019-09-13 23:58:15.022] DEBUG: Connected to database.
[2019-09-13 23:58:15.159] WARN : No block found in database
[2019-09-13 23:58:15.209] INFO : Starting to import table blocks from /home/supaiku/.local/share/ark-core/testnet/snapshots/1-1905287/blocks, skipCompression: false
100% | ETA: 0s | 1905287/1905287 | Duration: 185s
[2019-09-14 00:01:19.960] INFO : Starting to import table transactions from /home/supaiku/.local/share/ark-core/testnet/snapshots/1-1905287/transactions, skipCompression: false
100% | ETA: 0s | 463301/463301 | Duration: 74serror: invalid input syntax for integer: "{"s":1,"e":3,"c":[2158],"_isBigNumber":true}"
    at Connection.parseE (~/git/ark-core/node_modules/pg/lib/connection.js:602:11)
    at Connection.parseMessage (~/git/ark-core/node_modules/pg/lib/connection.js:399:19)
    at Socket.<anonymous> (~/git/ark-core/node_modules/pg/lib/connection.js:121:22)
[2019-09-14 00:02:34.541] INFO : Core is trying to gracefully shut down to avoid data corruption

Copy link
Copy Markdown
Contributor

@spkjp spkjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 15, 2019

Codecov Report

Merging #2925 into develop will decrease coverage by <.01%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2925      +/-   ##
===========================================
- Coverage    65.83%   65.82%   -0.01%     
===========================================
  Files          424      424              
  Lines        10167    10169       +2     
  Branches       538      540       +2     
===========================================
+ Hits          6693     6694       +1     
- Misses        3428     3429       +1     
  Partials        46       46
Impacted Files Coverage Δ
packages/core-snapshots/src/transport/codec.ts 85.45% <75%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cdb728...6c21fca. Read the comment docs.

@vasild
Copy link
Copy Markdown
Contributor Author

vasild commented Sep 16, 2019

Steps to reproduce would be useful, thanks!

spkjp and others added 11 commits September 18, 2019 05:31
…ts-nonce

* ArkEcosystem/core/develop:
  refactor(core-transaction-pool): don't accept expired v1 transactions (#2948)
  fix(core-snapshots): remove bogus skipRoundRows (#2973)
  feat(core-api): endpoints for locks/businesses/bridgechains (#2940)
  fix(core-blockchain): round deletion during rollback (#2970)
  fix: range selection in pool's getTransactions() (#2952)
  feat: expose `isValidPeer` via ajv format rule (#2960)
  chore: remove trailing whitespace (#2971)
  fix(core-transactions): update wallet nonce when applying v1 transaction (#2959)
  fix(core-blockchain): do not reset `noBlockCounter` when `downloadBlocks` succeeds (#2968)
  refactor(pool): remove unnecessary check from validateTransactions() (#2951)
  ci: temporarily disable pull_request.synchronize event (#2966)
  refactor: strengthen a nonce check in performGenericWalletChecks() (#2949)
  ci: setup github action workflow for e2e tests (#2964)
  chore: drop node 11 support (#2965)
  test(e2e): No need to run as root the chmod command when modifying own's files (#2958)
  refactor(crypto): change maximum recipients of multipayment via milestone (#2961)
  ci: split functional job into 1 job per type (#2963)
  refactor(core-p2p): make peer reply errors less verbose (#2962)
  fix(core-state): index recipient wallets during bootstrap (#2947)
  Tell git to ignore vim's temporary files (#2957)
  ci: force exit tests if there are hanging promises
  ci: use different test coverage directories for each type (#2956)
…ts-nonce

* ArkEcosystem/core/develop:
  fix(deps): update dependency @hapi/boom to v8 (#2988)
  feat(crypto): allow passing height to `configManager.isNewMilestone` (#3001)
  ci: update branch patterns to new format
  refactor: remove asset migration heuristic (#2999)
  chore(deps): update dependency typesync to ^0.6.0 (#2981)
  refactor(core): use default heap size regardless of available memory (#2998)
  chore(deps): update dependency cross-env to v6 (#2985)
  chore(deps): update dependency rimraf to v3 (#2987)
  refactor: core-magistrate-crypto export namespaces (#2980)
  feat: multiSignWif (#2979)
  fix(core-snapshots): export/import transactions' type_group (#2996)
  chore(deps): update dependency @types/newrelic to v5 (#2984)
  fix(deps): update dependency node-forge to ^0.9.0 (#2983)
  feat(core-api): find htlc unlock transactions (#2976)
  chore(deps): update dependency del-cli to v3 (#2986)
  fix(deps): update dependency cli-progress to v3 (#2990)
  fix(deps): update dependency winston-daily-rotate-file to v4 (#2992)
  fix(core-api): missing orderBy (#2974)
  feat(core): allow CLI command configurations (#2972)
  refactor(core-magistrate):  Split core-marketplace into core-magistrate-crypto and core-magistrate-transactions (#2967)
…ts-nonce

* ArkEcosystem/core/develop:
  refactor: remove `vendorFieldHex` (#3014)
  ci: run push events on master and develop, rest on PRs
  perf(crypto): memoize base58 de/encoding (#3015)
  refactor(core-transactions): bootstrap transactions in batches (#2997)
  perf(crypto): replace bignumber.js with native BigInt (#3010)
  refactor: add `round.missed` event (#3011)
@spkjp spkjp self-requested a review October 5, 2019 01:45
@faustbrian faustbrian merged commit daa830f into develop Oct 5, 2019
@ghost ghost deleted the snapshots-nonce branch October 5, 2019 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants