feat(core-snapshots): add support for transaction nonces#2925
Merged
faustbrian merged 13 commits intodevelopfrom Oct 5, 2019
Merged
feat(core-snapshots): add support for transaction nonces#2925faustbrian merged 13 commits intodevelopfrom
faustbrian merged 13 commits intodevelopfrom
Conversation
Contributor
|
I get the following error when I restore a fresh dump made on this branch: |
Codecov Report
@@ Coverage Diff @@
## develop #2925 +/- ##
===========================================
- Coverage 65.83% 65.82% -0.01%
===========================================
Files 424 424
Lines 10167 10169 +2
Branches 538 540 +2
===========================================
+ Hits 6693 6694 +1
- Misses 3428 3429 +1
Partials 46 46
Continue to review full report at Codecov.
|
Contributor
Author
|
Steps to reproduce would be useful, thanks! |
…ts-nonce * ArkEcosystem/core/develop: refactor(core-transaction-pool): don't accept expired v1 transactions (#2948) fix(core-snapshots): remove bogus skipRoundRows (#2973) feat(core-api): endpoints for locks/businesses/bridgechains (#2940) fix(core-blockchain): round deletion during rollback (#2970) fix: range selection in pool's getTransactions() (#2952) feat: expose `isValidPeer` via ajv format rule (#2960) chore: remove trailing whitespace (#2971) fix(core-transactions): update wallet nonce when applying v1 transaction (#2959) fix(core-blockchain): do not reset `noBlockCounter` when `downloadBlocks` succeeds (#2968) refactor(pool): remove unnecessary check from validateTransactions() (#2951) ci: temporarily disable pull_request.synchronize event (#2966) refactor: strengthen a nonce check in performGenericWalletChecks() (#2949) ci: setup github action workflow for e2e tests (#2964) chore: drop node 11 support (#2965) test(e2e): No need to run as root the chmod command when modifying own's files (#2958) refactor(crypto): change maximum recipients of multipayment via milestone (#2961) ci: split functional job into 1 job per type (#2963) refactor(core-p2p): make peer reply errors less verbose (#2962) fix(core-state): index recipient wallets during bootstrap (#2947) Tell git to ignore vim's temporary files (#2957) ci: force exit tests if there are hanging promises ci: use different test coverage directories for each type (#2956)
…ts-nonce * ArkEcosystem/core/develop: fix(deps): update dependency @hapi/boom to v8 (#2988) feat(crypto): allow passing height to `configManager.isNewMilestone` (#3001) ci: update branch patterns to new format refactor: remove asset migration heuristic (#2999) chore(deps): update dependency typesync to ^0.6.0 (#2981) refactor(core): use default heap size regardless of available memory (#2998) chore(deps): update dependency cross-env to v6 (#2985) chore(deps): update dependency rimraf to v3 (#2987) refactor: core-magistrate-crypto export namespaces (#2980) feat: multiSignWif (#2979) fix(core-snapshots): export/import transactions' type_group (#2996) chore(deps): update dependency @types/newrelic to v5 (#2984) fix(deps): update dependency node-forge to ^0.9.0 (#2983) feat(core-api): find htlc unlock transactions (#2976) chore(deps): update dependency del-cli to v3 (#2986) fix(deps): update dependency cli-progress to v3 (#2990) fix(deps): update dependency winston-daily-rotate-file to v4 (#2992) fix(core-api): missing orderBy (#2974) feat(core): allow CLI command configurations (#2972) refactor(core-magistrate): Split core-marketplace into core-magistrate-crypto and core-magistrate-transactions (#2967)
…ts-nonce * ArkEcosystem/core/develop: refactor: remove `vendorFieldHex` (#3014) ci: run push events on master and develop, rest on PRs perf(crypto): memoize base58 de/encoding (#3015) refactor(core-transactions): bootstrap transactions in batches (#2997) perf(crypto): replace bignumber.js with native BigInt (#3010) refactor: add `round.missed` event (#3011)
spkjp
approved these changes
Oct 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A summary of what changes this PR introduces and why they were made.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Does this PR release a new version?
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
developbranch, not themasterbranchIf adding a new feature, the PR's description includes: