refactor(taxonomic-filter): extract hogQLExpressionTaxonomicGroupsLogic#59819
Merged
pauldambra merged 2 commits intoMay 25, 2026
Merged
Conversation
Member
Author
This was referenced May 24, 2026
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
Contributor
|
Size Change: 0 B Total Size: 80 MB ℹ️ View Unchanged
|
This was referenced May 24, 2026
Member
Author
|
Note 🤖 Automated comment by QA Swarm — not written by a human QA Swarm review — verdict: APPROVEPure refactor extracting Verified preservation
Structural milestone — cap reliefThis is the first PR in the by-data-type extraction stack where the parent's XP-reviewer note (non-blocking): worth recording this milestone somewhere persistent so a future maintainer doesn't accidentally push it back over the cap. Options:
Ship as you see fit — not blocking. Security
Findings by severity
362/362 tests pass. Behaviour-identical. Approve. |
pauldambra
force-pushed
the
posthog-code/extract-cohort-taxonomic-logic
branch
from
698cdd6 to
689e986
Compare
pauldambra
force-pushed
the
posthog-code/extract-sql-expression-taxonomic-logic
branch
from
835c5db to
39e29cf
Compare
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Purely additive refactor — adds a new kea logic file that extracts existing HogQL expression group definitions from taxonomicFilterLogic.tsx. No existing files are modified, nothing imports the new logic yet, and no production behavior changes. The missing generated type file is standard kea practice (auto-generated at build time) and would be caught by CI.
Contributor
|
Reviews (1): Last reviewed commit: "refactor(taxonomic-filter): extract hogQ..." | Re-trigger Greptile |
pauldambra
force-pushed
the
posthog-code/extract-sql-expression-taxonomic-logic
branch
from
39e29cf to
ab04276
Compare
pauldambra
force-pushed
the
posthog-code/extract-cohort-taxonomic-logic
branch
from
689e986 to
0c103a7
Compare
pauldambra
force-pushed
the
posthog-code/extract-sql-expression-taxonomic-logic
branch
from
ab04276 to
7311bba
Compare
pauldambra
force-pushed
the
posthog-code/extract-cohort-taxonomic-logic
branch
from
0c103a7 to
1280bf3
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
pauldambra
force-pushed
the
posthog-code/extract-cohort-taxonomic-logic
branch
from
70755c3 to
65a07f6
Compare
pauldambra
force-pushed
the
posthog-code/extract-sql-expression-taxonomic-logic
branch
from
bdf2d4a to
01e5a4d
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Clean mechanical refactor extracting HogQL expression group logic into a dedicated kea file, exactly matching the existing cohort and group analytics patterns. The incidental hideBehavioralCohorts selector addition formalizes an already-used prop — no behavioral change.
Base automatically changed from
posthog-code/extract-cohort-taxonomic-logic
to
master
May 25, 2026 16:26
Fourth slice in the by-data-type split of `taxonomicFilterLogic`. The `SQL expression` tab and its two contributing selectors (`metadataSource`, `hogQLExpressionComponentProps`) were still inline in the parent. Both selectors are used *only* by this tab, so moving the trio together actually drops the parent's `taxonomicGroups` selector below kea's 16-input cap for the first time — net inputs go from 16 to 15. New `hogQLExpressionTaxonomicGroupsLogic.ts`: - Owns `metadataSource` and `hogQLExpressionComponentProps` selectors, both moved verbatim from the parent. - Owns a new `hogQLExpressionTaxonomicGroups` selector returning a one-element array with the `SQL expression` tab definition (using `InlineHogQLEditor` as its renderer). An array (rather than a bare group) keeps the parent integration consistent with the previous cohort and group-analytics extractions — the parent spreads the result with `...`. Parent `taxonomicFilterLogic`: - Connects to the new logic for `hogQLExpressionTaxonomicGroups`. - Removes the inline SQL expression tab and replaces it with `...hogQLExpressionTaxonomicGroups` so ordering is preserved. - Removes the local `metadataSource` and `hogQLExpressionComponentProps` selectors and drops both from the `taxonomicGroups` input tuple. One slot reused by the new connect value; net input count goes from 16 to 15. - Drops now-unused imports: `InlineHogQLEditor`, `AnyDataNode`, `NodeKind`. - Net change: parent shrinks by another 26 lines. No behaviour change. The SQL expression tab renders the same way with the same `componentProps`. This PR was written by an agent. Automated tests run: - `hogli test frontend/src/lib/components/TaxonomicFilter/` — 362/362 pass. - `pnpm exec tsc --noEmit` filtered to touched files — clean. - `pnpm format` — clean. - Kea typegen produces `hogQLExpressionTaxonomicGroupsLogicType.ts` and updates `taxonomicFilterLogicType.ts`. The agent did not manually click through the UI. Written by PostHog Code (Claude Opus 4.7). Picked next in the stack because it was the cheapest way to step out of the 16-input cap: a single tab whose extraction also retires two parent selector inputs. The rest of the stack can continue more comfortably now that the parent has one input slot to spare. Generated-By: PostHog Code Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
…parent Generated-By: PostHog Code Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
pauldambra
force-pushed
the
posthog-code/extract-sql-expression-taxonomic-logic
branch
from
01e5a4d to
473e393
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Member
Author
Merge activity
|
pauldambra
deleted the
posthog-code/extract-sql-expression-taxonomic-logic
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes
How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
Docs update
🤖 Agent context