refactor(taxonomic-filter): extract apmTaxonomicGroupsLogic#59823
Merged
Conversation
This was referenced May 24, 2026
Member
Author
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
Contributor
|
Size Change: 0 B Total Size: 80 MB ℹ️ View Unchanged
|
This was referenced May 24, 2026
pauldambra
force-pushed
the
posthog-code/extract-suggested-filters-taxonomic-logic
branch
from
2c4b3b7 to
60c0bf6
Compare
pauldambra
force-pushed
the
posthog-code/extract-apm-taxonomic-logic
branch
from
f7e45c0 to
4bb1804
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
There is an unresolved bot comment identifying a genuine copy-paste bug: the Spans localItemsSearch emits key: 'message' (copied from the Logs group) instead of key: 'name', which doesn't correspond to any span field and would silently produce wrong filter keys at runtime.
pauldambra
force-pushed
the
posthog-code/extract-suggested-filters-taxonomic-logic
branch
from
e493656 to
d9071cc
Compare
pauldambra
force-pushed
the
posthog-code/extract-apm-taxonomic-logic
branch
from
ba2589b to
4213f9e
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
pauldambra
force-pushed
the
posthog-code/extract-suggested-filters-taxonomic-logic
branch
from
d9071cc to
6ee281a
Compare
pauldambra
force-pushed
the
posthog-code/extract-apm-taxonomic-logic
branch
from
4213f9e to
d8b59d5
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pure structural extract refactor — the new file is a verbatim lift of APM taxonomic group definitions from taxonomicFilterLogic.tsx, following the identical kea sub-logic pattern already used by cohortTaxonomicGroupsLogic, groupAnalyticsTaxonomicGroupsLogic, etc. No behavioral change is introduced; the flagged key: 'message' in the Spans group is demonstrably pre-existing, visible in the removed code of this same diff.
pauldambra
force-pushed
the
posthog-code/extract-suggested-filters-taxonomic-logic
branch
from
6ee281a to
559290c
Compare
pauldambra
force-pushed
the
posthog-code/extract-apm-taxonomic-logic
branch
from
d8b59d5 to
05180f3
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure structural refactor — APM taxonomic group definitions are moved verbatim from taxonomicFilterLogic.tsx into a new sub-logic following the established kea pattern. No behavioral change; the flagged key: 'message' in Spans is demonstrably pre-existing in the removed code, and all inline bot comments were resolved.
pauldambra
force-pushed
the
posthog-code/extract-suggested-filters-taxonomic-logic
branch
from
559290c to
1297ec0
Compare
pauldambra
force-pushed
the
posthog-code/extract-apm-taxonomic-logic
branch
from
05180f3 to
1c9a1da
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure structural refactor following the established kea sub-logic pattern identical to cohortTaxonomicGroupsLogic and peers. The flagged key: 'message' in the Spans group is a pre-existing bug confirmed by the removed code in this same diff (and also present in buildTaxonomicGroups.tsx), not introduced here. All inline bot comments were resolved with accurate explanations.
pauldambra
force-pushed
the
posthog-code/extract-apm-taxonomic-logic
branch
from
1c9a1da to
85ecedf
Compare
Base automatically changed from
posthog-code/extract-suggested-filters-taxonomic-logic
to
master
May 25, 2026 21:57
Eighth slice. The six OTel observability tabs — `Logs`, `Log
attributes`, `Resource attributes`, `Spans`, `Span attributes`,
`Span resource attributes` — were a cohesive cluster all using the
parent's `endpointFilters` selector. Moving them together also
retires that selector from the parent.
New `apmTaxonomicGroupsLogic.ts`:
- Connects to `projectLogic` for `currentProjectId`.
- Owns the `endpointFilters` selector (moved from parent) and a new
`apmTaxonomicGroups` selector returning the six-element array of
observability tabs.
Parent `taxonomicFilterLogic`:
- Connects to the new logic for `apmTaxonomicGroups`.
- Removes all six inline tab definitions, replaces with the spread.
- Drops `endpointFilters` selector and signature param. Net inputs
to `taxonomicGroups` stay at 15 (slot reused by the new connect
value).
No behaviour change.
Agent-written PR. Tests:
- `hogli test frontend/src/lib/components/TaxonomicFilter/` —
362/362 pass.
- TS check on touched files — clean.
Largest single block extracted so far (±140 lines pulled out of the
parent). All six tabs share the same `endpointFilters` and the same
`/api/environments/$projectId/{logs,tracing}/` URL family, so they
cluster naturally.
Generated-By: PostHog Code
Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
Generated-By: PostHog Code Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
pauldambra
force-pushed
the
posthog-code/extract-apm-taxonomic-logic
branch
from
85ecedf to
5b59b54
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure structural extraction refactor — the new file is a verbatim lift of APM taxonomic group definitions following the exact same kea sub-logic pattern used by cohortTaxonomicGroupsLogic and peers. The key: 'message' in the Spans group is demonstrably pre-existing, visible in the removed code of this same diff, and not introduced here. No behavioral change.
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes
How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
Docs update
🤖 Agent context