refactor(taxonomic-filter): extract replayTaxonomicGroupsLogic#59825
Merged
Conversation
This was referenced May 24, 2026
Member
Author
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
Contributor
|
Size Change: 0 B Total Size: 80 MB ℹ️ View Unchanged
|
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
This was referenced May 24, 2026
pauldambra
force-pushed
the
posthog-code/extract-meta-recent-pinned-taxonomic-logic
branch
from
55777d1 to
cef85a3
Compare
pauldambra
force-pushed
the
posthog-code/extract-replay-taxonomic-logic
branch
from
0214205 to
1eaff23
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Purely additive new file extracting replay-related taxonomic groups into a dedicated kea logic. The file content is valid TypeScript matching its extension, follows established kea patterns correctly, and introduces no behavioral changes or API contract modifications.
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
frontend/src/lib/components/TaxonomicFilter/replayTaxonomicGroupsLogic.ts:18-96
**Extraction is incomplete — logic still duplicated in the parent**
`replayTaxonomicGroupsLogic` is never imported or connected anywhere in the codebase; `taxonomicFilterLogic.tsx` still carries the identical inline definitions at lines 1365–1423 and has not been updated to `connect()` this new logic. The same pattern appears in all nine prior commits in this stack (none of the extracted logics are wired into the parent yet), so this is likely intentional — but as it stands the new file is dead code and violates OnceAndOnlyOnce. If a follow-up assembly PR is planned, that intent is worth noting somewhere so reviewers and CI can track it.
Reviews (1): Last reviewed commit: "refactor(taxonomic-filter): extract repl..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
pauldambra
force-pushed
the
posthog-code/extract-replay-taxonomic-logic
branch
from
83d7e73 to
81397eb
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure mechanical extraction with no behavioral change: replay group definitions move verbatim into a new kea logic file following the established sibling pattern, and the parent logic correctly connects and spreads the selector in the same position.
pauldambra
force-pushed
the
posthog-code/extract-meta-recent-pinned-taxonomic-logic
branch
2 times, most recently
from
5aec6a2 to
6039f4e
Compare
pauldambra
force-pushed
the
posthog-code/extract-replay-taxonomic-logic
branch
from
81397eb to
8895b8c
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure mechanical extraction with no behavioral change: replay group definitions move verbatim into a new kea logic file following the established sibling pattern, and the parent logic correctly connects and spreads the selector in the same position.
pauldambra
changed the base branch from
posthog-code/extract-meta-recent-pinned-taxonomic-logic
to
graphite-base/59825
pauldambra
force-pushed
the
graphite-base/59825
branch
from
6039f4e to
baa9377
Compare
pauldambra
force-pushed
the
posthog-code/extract-replay-taxonomic-logic
branch
from
8895b8c to
ecf0fc1
Compare
pauldambra
force-pushed
the
posthog-code/extract-replay-taxonomic-logic
branch
from
ecf0fc1 to
c143a19
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure mechanical refactor: replay group definitions extracted verbatim into a new kea logic file following the established sibling pattern, and the parent logic correctly imports, connects, and spreads the selector in the same position. No behavioral changes or showstoppers.
pauldambra
force-pushed
the
posthog-code/extract-replay-taxonomic-logic
branch
from
c143a19 to
8bc2be2
Compare
Tenth slice. The `Replay` tab (recording / log-entry property keys) and the `Saved filters` tab (`session_recording_playlists` endpoint rendered via `SavedFiltersTaxonomicGroup`) are both session-replay concerns. Group them. New `replayTaxonomicGroupsLogic.ts`: - Connects to `teamLogic` (for `currentTeam`) and `projectLogic` (for `currentProjectId`). - Owns a new `replayTaxonomicGroups` selector returning the two-element array (Replay + Saved filters). Parent `taxonomicFilterLogic`: - Connects to the new logic for `replayTaxonomicGroups`. - Removes both inline tabs, replaces with the spread. - Drops now-unused `SavedFiltersTaxonomicGroup`, `SessionRecordingPlaylistType`, and `getFilterLabel` imports. No behaviour change. Agent-written. Tests: - `hogli test frontend/src/lib/components/TaxonomicFilter/` — 362/362 pass. - TS check on touched files — clean. Continuing the by-data-type stack. Generated-By: PostHog Code Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
Generated-By: PostHog Code Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
pauldambra
force-pushed
the
posthog-code/extract-replay-taxonomic-logic
branch
from
8bc2be2 to
533f0a8
Compare
Contributor
Merge activity
|
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure mechanical refactor: replay group definitions extracted verbatim into a new kea logic file following the established sibling pattern. The parent logic correctly imports, connects, and spreads the selector in the same position. The removed primaryPropertiesForContextEvents was declared but never consumed in the taxonomicGroups body, so its removal is safe.
…16-tuple limit Adding replayTaxonomicGroups would have made taxonomicGroups's input tuple 17 wide, blowing past kea's SelectorTuple type's max of 16. Combine the two groupAnalyticsTaxonomic* selectors into a single groupAnalyticsCombined wrapper that returns the concatenated array — the parent already spreads both back-to-back, so the order is preserved. Also drop eventNamesWithPrimaryProperties (no longer needed after the distinct-primary-properties util landed; the parent only ever used eventNames from it) and the now-unused primaryProperties / getDistinctPrimaryPropertiesForEvents references. Net: -2 inputs, -1 selector, -1 import, restores the type tuple to 16 entries with room for replay. Generated-By: PostHog Code Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
pauldambra
force-pushed
the
posthog-code/extract-replay-taxonomic-logic
branch
from
533f0a8 to
a148547
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure mechanical extraction of replay taxonomic group definitions into a dedicated kea logic file following the established sibling pattern. The parent correctly connects and spreads the new selector in the same position, and the removed primaryPropertiesForContextEvents was unused in the selector body. No behavioral changes or showstoppers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes
How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
Docs update
🤖 Agent context