refactor(taxonomic-filter): extract eventsTaxonomicGroupsLogic#59832
Closed
pauldambra wants to merge 2 commits into
Closed
Conversation
This was referenced May 24, 2026
Member
Author
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
Contributor
|
Size Change: +4.01 kB (0%) Total Size: 80.6 MB 📦 View Changed
ℹ️ View Unchanged
|
This was referenced May 24, 2026
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
This was referenced May 24, 2026
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
a84aec2 to
e453358
Compare
pauldambra
force-pushed
the
posthog-code/extract-shortcut-value-taxonomic-logic
branch
from
33c59c3 to
e6d1319
Compare
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
frontend/src/lib/components/TaxonomicFilter/eventsTaxonomicGroupsLogic.ts:12
The new `withKeywordShortcuts.tsx` added by this PR is an exact duplicate of the already-existing `utils/keywordShortcuts.tsx` — same function, same helper, same types. `eventsTaxonomicGroupsLogic.ts` should import from the canonical location that `utils/buildTaxonomicGroups.tsx` already uses, so the implementation lives in exactly one place.
```suggestion
import { withKeywordShortcuts } from 'lib/components/TaxonomicFilter/utils/keywordShortcuts'
```
Reviews (1): Last reviewed commit: "refactor(taxonomic-filter): extract even..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pure frontend kea refactor following the established pattern of other extracted taxonomic group logics. The extracted logic is functionally identical to the removed inline code, with the same data sources and group ordering. The withKeywordShortcuts duplication is a code-quality note only — no behavioral changes or production risk.
pauldambra
force-pushed
the
posthog-code/extract-shortcut-value-taxonomic-logic
branch
from
28fba21 to
9123baa
Compare
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
83ad856 to
2465c2c
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure frontend kea refactor with no behavioral changes: the two event group definitions are extracted to a dedicated logic and spread back into the same position in the parent selector. The withKeywordShortcuts duplication across three locations is a code-quality note only — all copies are functionally identical and no existing behavior is altered.
pauldambra
force-pushed
the
posthog-code/extract-shortcut-value-taxonomic-logic
branch
from
9123baa to
6f731fd
Compare
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
2465c2c to
4287f7b
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure frontend kea refactor extracting event taxonomic groups into a dedicated logic, following the established pattern of other extracted group logics in the same folder. The extracted logic is functionally identical to the removed inline code with the same data sources and group ordering. The withKeywordShortcuts duplication across two locations is a code-quality note only — no behavioral changes or production risk.
pauldambra
force-pushed
the
posthog-code/extract-shortcut-value-taxonomic-logic
branch
from
6f731fd to
8cdcd6d
Compare
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
4287f7b to
e4b7f7f
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure frontend kea refactor extracting event taxonomic group definitions into a dedicated logic file, following the established pattern of other group logics in the same folder. The extracted logic is functionally identical to the removed inline code, with the same data sources and group ordering. The withKeywordShortcuts triplication is a code-quality note only — no behavioral changes or production risk.
pauldambra
force-pushed
the
posthog-code/extract-shortcut-value-taxonomic-logic
branch
from
8cdcd6d to
a02bec6
Compare
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
e4b7f7f to
1539325
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure frontend kea refactor following the established pattern of other extracted taxonomic group logics in this folder; the extracted logic is functionally identical to the removed inline code with the same data sources and group ordering. The withKeywordShortcuts duplication across two files is a code-quality note only — no behavioral changes or production risk.
pauldambra
force-pushed
the
posthog-code/extract-shortcut-value-taxonomic-logic
branch
from
a02bec6 to
9a4939c
Compare
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
1539325 to
d2bdaae
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure frontend kea refactor extracting event taxonomic groups into a dedicated logic, following the established pattern of sibling files like cohortTaxonomicGroupsLogic, dataWarehouseTaxonomicGroupsLogic, etc. The extracted logic is functionally identical to the removed inline code with the same data sources and group ordering. The withKeywordShortcuts duplication is a pre-existing code quality issue (taxonomicFilterLogic already had its own local copy) and not a showstopper.
pauldambra
force-pushed
the
posthog-code/extract-shortcut-value-taxonomic-logic
branch
from
9a4939c to
95f278f
Compare
Sixteenth slice. The `Events` and `Internal Events` tabs are core
event-definition tabs and the first two entries in the parent's
`taxonomicGroups` array. They share the same `event_definitions`
endpoint pattern, both use the `eventTaxonomicGroupProps` shared
helper, and the `Events` tab wires in keyword shortcuts via the
`withKeywordShortcuts` helper that used to be defined locally in
the parent file.
New `withKeywordShortcuts.tsx` shared utility file:
- Moved `keywordShortcutValue`, the `BaseGroupFns<T>` type, and the
`withKeywordShortcuts` function out of `taxonomicFilterLogic.tsx`
so both the parent and any child logic can import them. (Exporting
them from the parent would force every child logic to depend on a
symbol from the file we're shrinking.)
New `eventsTaxonomicGroupsLogic.ts`:
- Connects to `projectLogic`.
- Owns its own `excludedProperties` selector.
- Owns `eventsTaxonomicGroups` returning the two-element array with
the `Events` tab (including `withKeywordShortcuts` wiring for
autocapture series shortcuts) and the `Internal Events` tab
(including the `getProductEventFilterOptions('activity-log')`
enumeration of internal event names).
Parent `taxonomicFilterLogic`:
- Imports `withKeywordShortcuts` from the new utility file instead
of defining it locally.
- Connects to `eventsTaxonomicGroupsLogic`, adds to
`extractedTaxonomicGroups` bundle.
- Removes the two inline tabs, replaces with the spread.
- Drops now-unused `IconCursor`, `QuickFilterItem`,
`buildAutocaptureSeriesShortcuts`, `getProductEventFilterOptions`
imports.
No behaviour change.
Agent-written. Tests:
- `hogli test frontend/src/lib/components/TaxonomicFilter/` —
362/362 pass.
- TS check on touched files — clean.
Generated-By: PostHog Code
Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
Generated-By: PostHog Code Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
d2bdaae to
aac1a57
Compare
Contributor
There was a problem hiding this comment.
Pure frontend kea refactor extracting two event taxonomic group definitions into a dedicated logic following the established pattern of sibling files. The extracted logic is functionally identical to the removed inline code, with the same projectLogic data source, same props-derived excludedProperties, and same group ordering.
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
Member
Author
|
Closing — the extraction approach hit kea's 16-dep SelectorTuple limit repeatedly and needs a different architectural strategy. The stack is being abandoned and master is being reverted back to the state right after #59816. See the upcoming revert PR for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes
How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
Docs update
🤖 Agent context