refactor(taxonomic-filter): extract customEventsTaxonomicGroupsLogic#59833
Closed
pauldambra wants to merge 2 commits into
Closed
Conversation
This was referenced May 24, 2026
Member
Author
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
Contributor
|
Size Change: 0 B Total Size: 80.6 MB ℹ️ View Unchanged
|
This was referenced May 24, 2026
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
a84aec2 to
e453358
Compare
pauldambra
force-pushed
the
posthog-code/extract-custom-events-taxonomic-logic
branch
from
dd77d58 to
42f5b66
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pure additive change: a new kea logic file that isn't imported anywhere yet. It follows existing patterns in the TaxonomicFilter directory, correctly uses eventTaxonomicGroupProps which is properly exported from taxonomicFilterLogic.tsx, and the logicType import convention matches other logic files in the same directory. No existing code is modified, so there is no production risk.
Contributor
|
Reviews (1): Last reviewed commit: "refactor(taxonomic-filter): extract cust..." | Re-trigger Greptile |
pauldambra
force-pushed
the
posthog-code/extract-custom-events-taxonomic-logic
branch
from
42f5b66 to
e254dbf
Compare
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
e453358 to
613b1f2
Compare
Contributor
There was a problem hiding this comment.
Pure mechanical refactor extracting two inline group definitions into a dedicated kea logic file, immediately wired back in with functionally identical behavior. Follows the established sibling pattern in the TaxonomicFilter directory with no production risk.
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
83ad856 to
2465c2c
Compare
pauldambra
force-pushed
the
posthog-code/extract-custom-events-taxonomic-logic
branch
from
fefd2b6 to
32e3529
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
2465c2c to
4287f7b
Compare
pauldambra
force-pushed
the
posthog-code/extract-custom-events-taxonomic-logic
branch
from
32e3529 to
90b795b
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure mechanical refactor extracting two inline group definitions into a dedicated kea logic file that is immediately wired back in at the same position with functionally identical behavior. Follows established sibling patterns throughout the TaxonomicFilter directory.
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
4287f7b to
e4b7f7f
Compare
pauldambra
force-pushed
the
posthog-code/extract-custom-events-taxonomic-logic
branch
from
90b795b to
c804380
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Pure mechanical refactor extracting two inline group definitions into a dedicated kea logic file, immediately wired back in at the same position. Functionally identical to the removed code — same endpoints, same group types, same ordering — and follows the established sibling pattern used throughout the TaxonomicFilter directory.
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
e4b7f7f to
1539325
Compare
pauldambra
force-pushed
the
posthog-code/extract-custom-events-taxonomic-logic
branch
from
c804380 to
0c80e0c
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
1539325 to
d2bdaae
Compare
pauldambra
force-pushed
the
posthog-code/extract-custom-events-taxonomic-logic
branch
from
0c80e0c to
731f858
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
pauldambra
force-pushed
the
posthog-code/extract-events-taxonomic-logic
branch
from
d2bdaae to
aac1a57
Compare
Seventeenth slice. The `Autocapture events` and `Custom Events` tabs are both event-discovery tabs that appear after the shortcut value groups. They share the parent's `teamId`/`projectId` deps. New `customEventsTaxonomicGroupsLogic.ts`: - Connects to `teamLogic` and `projectLogic`. - Owns `customEventsTaxonomicGroups` returning the two-element array. Parent `taxonomicFilterLogic`: - Connects to the new logic, added to `extractedTaxonomicGroups` bundle. - Removes both inline tabs, replaces with the spread. No behaviour change. Agent-written. Tests: - `hogli test frontend/src/lib/components/TaxonomicFilter/` — 362/362 pass. - TS check on touched files — clean. Generated-By: PostHog Code Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
Generated-By: PostHog Code Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
pauldambra
force-pushed
the
posthog-code/extract-custom-events-taxonomic-logic
branch
from
731f858 to
3d10889
Compare
Contributor
There was a problem hiding this comment.
Pure mechanical refactor extracting two inline group definitions into a dedicated kea logic file, immediately wired back in with functionally identical behavior. Follows established sibling patterns in the TaxonomicFilter directory with no behavioral or API contract changes.
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
Member
Author
|
Closing — the extraction approach hit kea's 16-dep SelectorTuple limit repeatedly and needs a different architectural strategy. The stack is being abandoned and master is being reverted back to the state right after #59816. See the upcoming revert PR for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes
How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
Docs update
🤖 Agent context