refactor(taxonomic-filter): extract eventMetadataTaxonomicGroupsLogic#59820
Merged
pauldambra merged 2 commits intoMay 25, 2026
Merged
Conversation
Member
Author
This was referenced May 24, 2026
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
Contributor
|
Size Change: 0 B Total Size: 80 MB ℹ️ View Unchanged
|
This was referenced May 24, 2026
Contributor
|
👋 Visual changes detected for this PR. Review and approve in PostHog Visual Review If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix. |
This was referenced May 24, 2026
pauldambra
force-pushed
the
posthog-code/extract-event-metadata-taxonomic-logic
branch
from
8f09244 to
66640c1
Compare
Contributor
|
Reviews (1): Last reviewed commit: "refactor(taxonomic-filter): extract even..." | Re-trigger Greptile |
pauldambra
force-pushed
the
posthog-code/extract-sql-expression-taxonomic-logic
branch
from
39e29cf to
ab04276
Compare
pauldambra
force-pushed
the
posthog-code/extract-event-metadata-taxonomic-logic
branch
from
66640c1 to
9af8d63
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
pauldambra
force-pushed
the
posthog-code/extract-sql-expression-taxonomic-logic
branch
from
ab04276 to
7311bba
Compare
pauldambra
force-pushed
the
posthog-code/extract-event-metadata-taxonomic-logic
branch
from
9af8d63 to
4cf28ea
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
pauldambra
force-pushed
the
posthog-code/extract-event-metadata-taxonomic-logic
branch
from
a8119b1 to
7aab1dd
Compare
pauldambra
force-pushed
the
posthog-code/extract-sql-expression-taxonomic-logic
branch
from
bdf2d4a to
01e5a4d
Compare
pauldambra
force-pushed
the
posthog-code/extract-event-metadata-taxonomic-logic
branch
from
7aab1dd to
dd7de30
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Clean mechanical refactor extracting event metadata group definitions into a dedicated kea logic file, following the same pattern as cohortTaxonomicGroupsLogic and groupAnalyticsTaxonomicGroupsLogic already in the same directory. Behavior is identical — the inline group object is simply moved out and spread back in.
pauldambra
force-pushed
the
posthog-code/extract-event-metadata-taxonomic-logic
branch
from
dd7de30 to
76a5b7c
Compare
pauldambra
force-pushed
the
posthog-code/extract-sql-expression-taxonomic-logic
branch
from
01e5a4d to
473e393
Compare
pauldambra
changed the base branch from
posthog-code/extract-sql-expression-taxonomic-logic
to
graphite-base/59820
Fifth slice in the by-data-type split of `taxonomicFilterLogic`. The `Event metadata` tab was the only consumer of `eventMetadataPropertyDefinitions` from `propertyDefinitionsModel`, so the singleton tab and its connect both move together. New `eventMetadataTaxonomicGroupsLogic.ts`: - Connects to `propertyDefinitionsModel` for `eventMetadataPropertyDefinitions` (this connect is no longer needed in the parent). - Owns a new `eventMetadataTaxonomicGroups` selector returning the one-element array with the `Event metadata` tab definition. Parent `taxonomicFilterLogic`: - Connects to the new logic for `eventMetadataTaxonomicGroups`. - Removes the inline tab and replaces it with the spread. - Drops `propertyDefinitionsModel.eventMetadataPropertyDefinitions` from its connect block, and drops `s.eventMetadataPropertyDefinitions` from the `taxonomicGroups` selector inputs and signature. Net selector inputs stay at 15 (slot reused by the new connect value). - Drops now-unused `getEventMetadataDefinitionIcon` import and the `propertyDefinitionsModel` value import (the `updatePropertyDefinitions` function from the same module is still imported). - Net change: parent shrinks by another 18 lines. No behaviour change. The Event metadata tab renders the same data, uses the same icon and core-definition label lookup, and hits the same `/api/event/values/` endpoint for property values. This PR was written by an agent. Automated tests run: - `hogli test frontend/src/lib/components/TaxonomicFilter/` — 362/362 pass. - `pnpm exec tsc --noEmit` filtered to touched files — clean. - `pnpm format` — clean. - Kea typegen produces `eventMetadataTaxonomicGroupsLogicType.ts` and updates `taxonomicFilterLogicType.ts`. The agent did not manually click through the UI. Written by PostHog Code (Claude Opus 4.7). Continued the by-data-type stack strategy: each PR keeps blast radius small (one tab, one connected logic), stays behaviour-identical, and bites off a tab plus any selector that was solely used to feed it. Slow and steady is the point of the stack. Generated-By: PostHog Code Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
…rent Generated-By: PostHog Code Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
pauldambra
force-pushed
the
posthog-code/extract-event-metadata-taxonomic-logic
branch
from
76a5b7c to
d04e1b3
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Member
Author
Merge activity
|
pauldambra
deleted the
posthog-code/extract-event-metadata-taxonomic-logic
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes
How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
Docs update
🤖 Agent context