refactor(taxonomic-filter): extract recentPinnedTaxonomicGroupsLogic#59824
Merged
pauldambra merged 2 commits intoMay 26, 2026
Merged
Conversation
This was referenced May 24, 2026
Member
Author
This was referenced May 24, 2026
Contributor
|
🎭 Playwright didn't run on this PR — your changes touch code that could affect E2E behavior, but Playwright is opt-in via label now to keep CI cost down. Add the Most PRs don't need this. Real regressions still get caught on master and fix-forward. |
Contributor
|
Size Change: 0 B Total Size: 80 MB ℹ️ View Unchanged
|
This was referenced May 24, 2026
pauldambra
force-pushed
the
posthog-code/extract-meta-recent-pinned-taxonomic-logic
branch
from
55777d1 to
cef85a3
Compare
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
frontend/src/lib/components/TaxonomicFilter/recentPinnedTaxonomicGroupsLogic.ts:20-53
**Definitions duplicated in `buildTaxonomicGroups.tsx`**
The `Recent` (lines 1004–1016) and `Pinned` (lines 1017–1029) group definitions extracted here are still present verbatim in `buildTaxonomicGroups.tsx`, which also retains its imports of `recentTaxonomicFiltersLogic` and `taxonomicFilterPinnedPropertiesLogic`. The new logic has no consumers yet, so both copies are active. A follow-up removing the originals from `buildTaxonomicGroups.tsx` is needed to satisfy the OnceAndOnlyOnce rule.
Reviews (1): Last reviewed commit: "refactor(taxonomic-filter): extract rece..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
pauldambra
force-pushed
the
posthog-code/extract-meta-recent-pinned-taxonomic-logic
branch
from
cef85a3 to
2cd1588
Compare
pauldambra
force-pushed
the
posthog-code/extract-apm-taxonomic-logic
branch
from
4bb1804 to
0bee93a
Compare
pauldambra
force-pushed
the
posthog-code/extract-apm-taxonomic-logic
branch
from
d8b59d5 to
05180f3
Compare
pauldambra
force-pushed
the
posthog-code/extract-meta-recent-pinned-taxonomic-logic
branch
from
0a143a3 to
25d8210
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
pauldambra
force-pushed
the
posthog-code/extract-apm-taxonomic-logic
branch
from
05180f3 to
1c9a1da
Compare
pauldambra
force-pushed
the
posthog-code/extract-meta-recent-pinned-taxonomic-logic
branch
from
25d8210 to
795bc42
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Mechanical extraction refactor with no behavioral change — the two inline group definitions are moved verbatim into a new kea logic file following identical conventions to sibling files, and spread back into the exact same selector position in the parent logic.
pauldambra
force-pushed
the
posthog-code/extract-apm-taxonomic-logic
branch
from
1c9a1da to
85ecedf
Compare
pauldambra
force-pushed
the
posthog-code/extract-meta-recent-pinned-taxonomic-logic
branch
from
795bc42 to
9607151
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Mechanical extraction refactor — the two inline group definitions are moved verbatim into a new kea logic file following identical conventions to sibling files, and spread back into the same selector position in the parent logic. No behavioral change, no API or data model impact.
pauldambra
force-pushed
the
posthog-code/extract-apm-taxonomic-logic
branch
from
85ecedf to
5b59b54
Compare
pauldambra
force-pushed
the
posthog-code/extract-meta-recent-pinned-taxonomic-logic
branch
from
9607151 to
6c2edde
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Mechanical extraction refactor — two inline group definitions are moved verbatim into a new kea logic file following identical conventions to sibling files, and spread back into the exact same selector position. No behavioral change, no API or data model impact. The resolved inline comment about duplication was satisfactorily explained as a stacked-diff artifact.
pauldambra
changed the base branch from
posthog-code/extract-apm-taxonomic-logic
to
graphite-base/59824
Ninth slice. The `Recent` and `Pinned` meta-tabs were contiguous in the parent and both follow the same `isLocalOnly: true` / `isMetaGroup: true` shape with a `logic:` reference to a sibling local-only logic (`recentTaxonomicFiltersLogic` and `taxonomicFilterPinnedPropertiesLogic`). New `recentPinnedTaxonomicGroupsLogic.ts`: - No connect needed — the tabs only carry references to the sibling logics; consumers mount/read those directly. - Owns a new `recentPinnedTaxonomicGroups` selector returning the two-element array. Parent `taxonomicFilterLogic`: - Connects to the new logic for `recentPinnedTaxonomicGroups`. - Removes the two inline meta tabs, replaces with the spread. No behaviour change. Agent-written. Tests: - `hogli test frontend/src/lib/components/TaxonomicFilter/` — 362/362 pass. - TS check on touched files — clean. This PR doesn't retire any parent selector inputs — these meta tabs were never reading from a parent selector, just from props of the tab def itself. Keeps the by-data-type stack progressing. Generated-By: PostHog Code Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
pauldambra
force-pushed
the
graphite-base/59824
branch
from
5b59b54 to
29e1418
Compare
pauldambra
force-pushed
the
posthog-code/extract-meta-recent-pinned-taxonomic-logic
branch
from
6c2edde to
5aec6a2
Compare
Generated-By: PostHog Code Task-Id: 2649f7ae-c1f7-40ae-8866-be024f3f1285
pauldambra
force-pushed
the
posthog-code/extract-meta-recent-pinned-taxonomic-logic
branch
from
5aec6a2 to
6039f4e
Compare
github-actions
Bot
dismissed
their stale review
New commits pushed (delta classified non_linear_history) — stamphog approval dismissed; re-review running automatically.
Contributor
There was a problem hiding this comment.
Clean mechanical extraction refactor: the Recent and Pinned group definitions are moved verbatim into a new dedicated kea logic file, following the same pattern as every other group logic in this directory, and spread back into the identical selector position. No behavioral change, no security or data model impact.
Member
Author
Merge activity
|
pauldambra
deleted the
posthog-code/extract-meta-recent-pinned-taxonomic-logic
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes
How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Publish to changelog?
Docs update
🤖 Agent context