Skip to content

[MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion.#862

Merged
milo-pr-merge-cc[bot] merged 14 commits intostagefrom
mwpw-183216-a11y-play-pause
Feb 2, 2026
Merged

[MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion.#862
milo-pr-merge-cc[bot] merged 14 commits intostagefrom
mwpw-183216-a11y-play-pause

Conversation

@hkuraware
Copy link
Copy Markdown
Collaborator

@hkuraware hkuraware commented Jan 21, 2026

  • Added accessible play/pause control for logo animation.
  • Built responsive support for all viewport sizes.
  • Implemented using a mobile-first approach.

Resolves: MWPW-183216

Test URLs:

Screenshots:
Screenshot 2026-01-27 at 11 23 47 AM
Screenshot 2026-01-27 at 11 23 31 AM

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Jan 21, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Jan 21, 2026

Page Scores Audits Google
📱 /drafts/himani/test-ff?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/himani/test-ff?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to failing checks

@spadmasa
Copy link
Copy Markdown
Collaborator

spadmasa commented Jan 21, 2026

Hi @hkuraware , when did play/pause able to see it as undefined , please check, do not see translated alt text like how we see in product pages

Recording.2026-01-21.195609.mp4

Uploading Recording 2026-01-21 195609.mp4…

@aem-code-sync aem-code-sync Bot temporarily deployed to mwpw-183216-a11y-play-pause January 22, 2026 09:17 Inactive
@hkuraware
Copy link
Copy Markdown
Collaborator Author

Hi @hkuraware , when did play/pause able to see it as undefined , please check, do not see translated alt text like how we see in product pages

Hi @spadmasa ,
Fixed the issue. Could you please check.

Copy link
Copy Markdown
Collaborator

@nkthakur48 nkthakur48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkuraware Could you please have a look at the review comments!

Comment thread creativecloud/blocks/showcase-marquee/showcase-marquee.css Outdated
Comment thread creativecloud/blocks/showcase-marquee/showcase-marquee.js
Comment thread creativecloud/blocks/showcase-marquee/showcase-marquee.css
Comment thread creativecloud/blocks/showcase-marquee/showcase-marquee.css
Comment thread creativecloud/blocks/showcase-marquee/showcase-marquee.js
Comment thread creativecloud/blocks/showcase-marquee/showcase-marquee.js
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to failing checks

@aem-code-sync aem-code-sync Bot temporarily deployed to mwpw-183216-a11y-play-pause January 23, 2026 11:25 Inactive
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.39%. Comparing base (f7e0f73) to head (7ee0771).
⚠️ Report is 91 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #862      +/-   ##
==========================================
+ Coverage   88.37%   88.39%   +0.02%     
==========================================
  Files          42       42              
  Lines        9145     9146       +1     
==========================================
+ Hits         8082     8085       +3     
+ Misses       1063     1061       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hkuraware hkuraware requested a review from nkthakur48 January 23, 2026 11:30
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to failing checks

Comment thread creativecloud/blocks/showcase-marquee/showcase-marquee.js Outdated
Comment thread creativecloud/blocks/showcase-marquee/showcase-marquee.js
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to failing checks

@aem-code-sync aem-code-sync Bot temporarily deployed to mwpw-183216-a11y-play-pause January 27, 2026 05:24 Inactive
@aem-code-sync aem-code-sync Bot temporarily deployed to mwpw-183216-a11y-play-pause January 27, 2026 05:42 Inactive
@spadmasa
Copy link
Copy Markdown
Collaborator

removed the label as there is tab trapping issue calledout , will reverify the pr and add the label

@aem-code-sync aem-code-sync Bot temporarily deployed to mwpw-183216-a11y-play-pause January 27, 2026 07:07 Inactive
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to missing verified label. kindly make sure that the PR has been verified

@hkuraware
Copy link
Copy Markdown
Collaborator Author

Hi team,
I’ve debugged this issue and found that we’re encountering a tab trap within the Unity autocomplete. The Unity handleTab logic is being triggered even when focus is on buttons outside the Unity block.
As a quick fix, we can add an additional scope/focus check in Unity so the Tab key handling runs only when the active element is within the Unity section and does not affect buttons or elements in other sections.
Screenshot 2026-01-27 at 5 39 51 PM
cc: @nkthakur48 @suhjainadobe @spadmasa

@aem-code-sync aem-code-sync Bot temporarily deployed to mwpw-183216-a11y-play-pause January 27, 2026 12:12 Inactive
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to missing verified label. kindly make sure that the PR has been verified

@nkthakur48
Copy link
Copy Markdown
Collaborator

@hkuraware Could you please link details for complementing Unity PR fixing this issue? Also I suppose we may need to ensure that changes for both Unity and CC should go together

@spadmasa
Copy link
Copy Markdown
Collaborator

The pr can be merged to stage and prod after the unity ticket fix is available in production https://jira.corp.adobe.com/browse/MWPW-186857

@hkuraware
Copy link
Copy Markdown
Collaborator Author

hkuraware commented Jan 29, 2026

@hkuraware Could you please link details for complementing Unity PR fixing this issue? Also I suppose we may need to ensure that changes for both Unity and CC should go together

Hi @nkthakur48 ,
As Soujanya mentioned in the comment above, this PR can be merged to stage and prod once the Unity ticket fix is available in production.

Additional details:
Unity PR merged to stage: adobecom/unity#664
Ticket number: https://jira.corp.adobe.com/browse/MWPW-186857

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to missing verified label. kindly make sure that the PR has been verified

@spadmasa
Copy link
Copy Markdown
Collaborator

changes of unity pr is merged and validation is done on below url , tab trapping is fine now
https://mwpw-183216-a11y-play-pause--cc--adobecom.aem.live/products/firefly

@milo-pr-merge-cc milo-pr-merge-cc Bot merged commit 4efdddb into stage Feb 2, 2026
9 checks passed
nkthakur48 added a commit that referenced this pull request Feb 5, 2026
nkthakur48 added a commit to adobecom/da-cc that referenced this pull request Mar 17, 2026
…ement of logo motion. (adobecom#862)

* Added play/pause button for logo motion

* Fixed undefined issue

* Minor fix

* Additional check and minor fix

* Added locale support to the button title

* Added support for reduced motion

* Minor fix

* Added additional check

* Minor fix

* Removed tab-index from the button

---------

Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
(cherry picked from commit 4efdddb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants