[MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion.#862
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
|
Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to failing checks |
|
Hi @hkuraware , when did play/pause able to see it as undefined , please check, do not see translated alt text like how we see in product pages Recording.2026-01-21.195609.mp4Uploading Recording 2026-01-21 195609.mp4… |
Hi @spadmasa , |
nkthakur48
left a comment
There was a problem hiding this comment.
@hkuraware Could you please have a look at the review comments!
|
Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to failing checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stage #862 +/- ##
==========================================
+ Coverage 88.37% 88.39% +0.02%
==========================================
Files 42 42
Lines 9145 9146 +1
==========================================
+ Hits 8082 8085 +3
+ Misses 1063 1061 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to failing checks |
|
Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to failing checks |
|
removed the label as there is tab trapping issue calledout , will reverify the pr and add the label |
|
Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to missing verified label. kindly make sure that the PR has been verified |
|
Hi team, |
|
Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to missing verified label. kindly make sure that the PR has been verified |
|
@hkuraware Could you please link details for complementing Unity PR fixing this issue? Also I suppose we may need to ensure that changes for both Unity and CC should go together |
|
The pr can be merged to stage and prod after the unity ticket fix is available in production https://jira.corp.adobe.com/browse/MWPW-186857 |
Hi @nkthakur48 , Additional details: |
|
Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to failing checks |
|
Skipped merging 862: [MWPW-183216]: [Accessibility] Added play/pause button to control movement of logo motion. due to missing verified label. kindly make sure that the PR has been verified |
|
changes of unity pr is merged and validation is done on below url , tab trapping is fine now |
…ement of logo motion. (adobecom#862) * Added play/pause button for logo motion * Fixed undefined issue * Minor fix * Additional check and minor fix * Added locale support to the button title * Added support for reduced motion * Minor fix * Added additional check * Minor fix * Removed tab-index from the button --------- Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> (cherry picked from commit 4efdddb)
- #14 - #15 - #17 - adobecom#862 - adobecom#870 - adobecom#873 - adobecom#881 - adobecom#883 - adobecom#885 - adobecom#886 - adobecom#887 - adobecom#889 - adobecom#890 - adobecom#891 - adobecom#893 - adobecom#895 - adobecom#896 - adobecom#899 - adobecom#901 - adobecom#902 - adobecom#903 - adobecom#904 - adobecom#905 - adobecom#906 - adobecom#907 - adobecom#908 - adobecom#909 - adobecom#910 - adobecom#911 - adobecom#913 - adobecom#917 - adobecom#918 - adobecom#920 - adobecom#921 - adobecom#924 - adobecom#926 - adobecom#927 - adobecom#928 - adobecom#929 - adobecom#930 - adobecom#932 - adobecom#933 - adobecom#935

Resolves: MWPW-183216
Test URLs:
Screenshots:

