[MWPW-189467][DOTCOM-179535][MWPW-189479] Upload Marquee A11y fixes#921
Merged
nkthakur48 merged 3 commits intodoodlebug-v151from Mar 11, 2026
Merged
[MWPW-189467][DOTCOM-179535][MWPW-189479] Upload Marquee A11y fixes#921nkthakur48 merged 3 commits intodoodlebug-v151from
nkthakur48 merged 3 commits intodoodlebug-v151from
Conversation
|
Skipped merging 921: [MWPW-189467][DOTCOM-179535][MWPW-189479] Upload Marquee A11y fixes due to failing checks |
nkthakur48
requested review from
drashti1712,
hkhatana26,
hkuraware,
nkthakur48 and
suhjainadobe
….js keeping a11y changes and doodlebug structure Made-with: Cursor
nkthakur48
approved these changes
Mar 11, 2026
|
Looks fine in branch URL. Focus is seen on 'Upload Image' button while tabbing |
nkthakur48
added a commit
that referenced
this pull request
Mar 12, 2026
nkthakur48
added a commit
that referenced
this pull request
Mar 13, 2026
…928) * [MWPW-189426, MWPW-189301] Changes to conditionally inject prompt bar or dropzone in upload marquee (#911) * Changes to conditionally inject prompt bar or dropzone in upload marquee * refactoring changes to avoid code duplication * nit comments * fixing merge conflicts issue * Renaing upload variant to dropzone variant * css change to center align the left col in case of prompt bar * pr comments * nit changes * removing unused vars --------- Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * [MWPW-189581] cards rendered in ipad mode is not as expected when traversed from hint mode and navigated back (#917) * fix * carousel-swipe --------- Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> * [MWPW-189676]: [ACOM] Doodlebug CSS changes in "Aside" block to support video on Desktop (#918) * Fixed aside video css on doodlebug * Minor changes * Added image class selector * MWPW-189681: Editorial card changes for doodle bug (#920) Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * [MWPW-189467][DOTCOM-179535][MWPW-189479] Upload Marquee A11y fixes (#921) * [MWPW-189467][DOTCOM-179535][MWPW-189479] Upload Marquee A11y fixes * remove aria lables from branding icons --------- Co-authored-by: vipulg <vipulg@adobe.com> * MWPW-189453 Adding text above dropzone (#903) Co-authored-by: Sanjay Saravanan <saravana@adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * [MWPW-189839] fix video controls on upload-marquee (#924) * [MWPW-189839] fix video controls on upload-marquee * show play/pause button even when reduce motion is set * revert play/pause * Revert "revert play/pause" This reverts commit 65b26d4. --------- Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * [MWPW-189798]: [Doodlebug Wave] Added border to play pause control in video (#926) * Added border on play/pause button * Minor change * Fixed marque button --------- Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com> Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> Co-authored-by: Drashti Modasara <drashti1712@gmail.com> Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com> Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> Co-authored-by: Harshad Khatana <hkhatana@adobe.com> Co-authored-by: Vipul Gupta <vipugpta@gmail.com> Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com> Co-authored-by: Sanjay Saravanan <saravana@adobe.com>
nkthakur48
added a commit
to adobecom/da-cc
that referenced
this pull request
Mar 17, 2026
- adobecom#911 - adobecom#917 - adobecom#918 - adobecom#920 - adobecom#921 - adobecom#903 - adobecom#924 - adobecom#926 (cherry picked from commit f6343b0)
nkthakur48
added a commit
to adobecom/da-cc
that referenced
this pull request
Mar 17, 2026
…dobecom#928) * [MWPW-189426, MWPW-189301] Changes to conditionally inject prompt bar or dropzone in upload marquee (adobecom#911) * Changes to conditionally inject prompt bar or dropzone in upload marquee * refactoring changes to avoid code duplication * nit comments * fixing merge conflicts issue * Renaing upload variant to dropzone variant * css change to center align the left col in case of prompt bar * pr comments * nit changes * removing unused vars --------- Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * [MWPW-189581] cards rendered in ipad mode is not as expected when traversed from hint mode and navigated back (adobecom#917) * fix * carousel-swipe --------- Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> * [MWPW-189676]: [ACOM] Doodlebug CSS changes in "Aside" block to support video on Desktop (adobecom#918) * Fixed aside video css on doodlebug * Minor changes * Added image class selector * MWPW-189681: Editorial card changes for doodle bug (adobecom#920) Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * [MWPW-189467][DOTCOM-179535][MWPW-189479] Upload Marquee A11y fixes (adobecom#921) * [MWPW-189467][DOTCOM-179535][MWPW-189479] Upload Marquee A11y fixes * remove aria lables from branding icons --------- Co-authored-by: vipulg <vipulg@adobe.com> * MWPW-189453 Adding text above dropzone (adobecom#903) Co-authored-by: Sanjay Saravanan <saravana@adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * [MWPW-189839] fix video controls on upload-marquee (adobecom#924) * [MWPW-189839] fix video controls on upload-marquee * show play/pause button even when reduce motion is set * revert play/pause * Revert "revert play/pause" This reverts commit 65b26d4. --------- Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * [MWPW-189798]: [Doodlebug Wave] Added border to play pause control in video (adobecom#926) * Added border on play/pause button * Minor change * Fixed marque button --------- Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com> Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> Co-authored-by: Drashti Modasara <drashti1712@gmail.com> Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com> Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local> Co-authored-by: Harshad Khatana <hkhatana@adobe.com> Co-authored-by: Vipul Gupta <vipugpta@gmail.com> Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com> Co-authored-by: Sanjay Saravanan <saravana@adobe.com>
nkthakur48
added a commit
to adobecom/da-cc
that referenced
this pull request
Mar 17, 2026
- #14 - #15 - #17 - adobecom#862 - adobecom#870 - adobecom#873 - adobecom#881 - adobecom#883 - adobecom#885 - adobecom#886 - adobecom#887 - adobecom#889 - adobecom#890 - adobecom#891 - adobecom#893 - adobecom#895 - adobecom#896 - adobecom#899 - adobecom#901 - adobecom#902 - adobecom#903 - adobecom#904 - adobecom#905 - adobecom#906 - adobecom#907 - adobecom#908 - adobecom#909 - adobecom#910 - adobecom#911 - adobecom#913 - adobecom#917 - adobecom#918 - adobecom#920 - adobecom#921 - adobecom#924 - adobecom#926 - adobecom#927 - adobecom#928 - adobecom#929 - adobecom#930 - adobecom#932 - adobecom#933 - adobecom#935
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: MWPW-189467
DOTCOM-179535
MWPW-189479
Test URLs: