Skip to content

[MWPW-189426, MWPW-189301] Changes to conditionally inject prompt bar or dropzone in upload marquee#911

Merged
nkthakur48 merged 12 commits intodoodlebug-v151from
db-poc-promptbar
Mar 10, 2026
Merged

[MWPW-189426, MWPW-189301] Changes to conditionally inject prompt bar or dropzone in upload marquee#911
nkthakur48 merged 12 commits intodoodlebug-v151from
db-poc-promptbar

Conversation

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Mar 6, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Mar 6, 2026

Page Scores Audits Google
📱 /drafts/arushi/firefly/doodlebug/remove-object-prompt?unitylibs=db-poc-prompt PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/arushi/firefly/doodlebug/remove-object-prompt?unitylibs=db-poc-prompt Lighthouse returned error: Something went wrong. PSI
📱 /drafts/arushi/firefly/doodlebug/remove-object?unitylibs=db-poc-prompt Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI
🖥️ /drafts/arushi/firefly/doodlebug/remove-object?unitylibs=db-poc-prompt Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI

@arugupta1992 arugupta1992 marked this pull request as draft March 6, 2026 16:13
@arugupta1992 arugupta1992 marked this pull request as ready for review March 7, 2026 13:13
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 911: [MWPW-189426, MWPW-189301] Changes to conditionally inject prompt bar or dropzone in upload marquee due to failing checks

Comment thread creativecloud/blocks/upload-marquee/upload-marquee.js Outdated
@nkthakur48
Copy link
Copy Markdown
Collaborator

@arugupta1992 Documenting the general feedback provided on Saturday:

  • Add a comment for "copy"
  • See if authoring could follow the same order of elements instead of using classes
  • Please see if functions like *collectViewport could be combined and duplications could be removed

@aem-code-sync aem-code-sync Bot temporarily deployed to db-poc-promptbar March 10, 2026 03:57 Inactive
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 911: [MWPW-189426, MWPW-189301] Changes to conditionally inject prompt bar or dropzone in upload marquee due to failing checks

Comment thread creativecloud/blocks/upload-marquee/upload-marquee.js Outdated
Comment thread creativecloud/blocks/upload-marquee/upload-marquee.js Outdated
@aem-code-sync aem-code-sync Bot temporarily deployed to db-poc-promptbar March 10, 2026 09:30 Inactive
Comment thread creativecloud/blocks/upload-marquee/upload-marquee.js
Comment thread creativecloud/blocks/upload-marquee/upload-marquee.js Outdated
Comment thread creativecloud/blocks/upload-marquee/upload-marquee.js Outdated
Comment thread creativecloud/blocks/upload-marquee/upload-marquee.js Outdated
@nkthakur48
Copy link
Copy Markdown
Collaborator

Screenshot 2026-03-10 at 5 56 42 PM @arugupta1992 The After link has some issues, could you please check?

@aem-code-sync aem-code-sync Bot temporarily deployed to db-poc-promptbar March 10, 2026 13:04 Inactive
Comment thread creativecloud/blocks/upload-marquee/upload-marquee.js Outdated
Comment thread creativecloud/blocks/upload-marquee/upload-marquee.js Outdated
Comment thread creativecloud/blocks/upload-marquee/upload-marquee.js Outdated
@arugupta1992
Copy link
Copy Markdown
Collaborator Author

Screenshot 2026-03-10 at 5 56 42 PM @arugupta1992 The After link has some issues, could you please check?

Hi @nkthakur48 , this is working fine at my end. Can you refresh and confirm if you still see this?
image

@nkthakur48 nkthakur48 changed the base branch from stage to doodlebug-v151 March 10, 2026 19:15
@nkthakur48 nkthakur48 merged commit 5d88cff into doodlebug-v151 Mar 10, 2026
8 of 9 checks passed
nkthakur48 added a commit that referenced this pull request Mar 13, 2026
…928)

* [MWPW-189426, MWPW-189301] Changes to conditionally inject prompt bar or dropzone in upload marquee (#911)

* Changes to conditionally inject prompt bar or dropzone in upload marquee

* refactoring changes to avoid code duplication

* nit comments

* fixing merge conflicts issue

* Renaing upload variant to dropzone variant

* css change to center align the left col in case of prompt bar

* pr comments

* nit changes

* removing unused vars

---------

Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>
Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>

* [MWPW-189581] cards rendered in ipad mode is not as expected when traversed from hint mode and navigated back (#917)

* fix

* carousel-swipe

---------

Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com>
Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local>

* [MWPW-189676]: [ACOM] Doodlebug CSS changes in "Aside" block to support video on Desktop (#918)

* Fixed aside video css on doodlebug

* Minor changes

* Added image class selector

* MWPW-189681: Editorial card changes for doodle bug (#920)

Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>

* [MWPW-189467][DOTCOM-179535][MWPW-189479] Upload Marquee A11y fixes (#921)

* [MWPW-189467][DOTCOM-179535][MWPW-189479] Upload Marquee A11y fixes

* remove aria lables from branding icons

---------

Co-authored-by: vipulg <vipulg@adobe.com>

* MWPW-189453 Adding text above dropzone (#903)

Co-authored-by: Sanjay Saravanan <saravana@adobe.com>
Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>

* [MWPW-189839] fix video controls on upload-marquee (#924)

* [MWPW-189839] fix video controls on upload-marquee

* show play/pause button even when reduce motion is set

* revert play/pause

* Revert "revert play/pause"

This reverts commit 65b26d4.

---------

Co-authored-by: vipulg <vipulg@adobe.com>
Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>

* [MWPW-189798]: [Doodlebug Wave] Added border to play pause control in video (#926)

* Added border on play/pause button

* Minor change

* Fixed marque button

---------

Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com>
Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>
Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
Co-authored-by: Drashti Modasara <drashti1712@gmail.com>
Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com>
Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local>
Co-authored-by: Harshad Khatana <hkhatana@adobe.com>
Co-authored-by: Vipul Gupta <vipugpta@gmail.com>
Co-authored-by: vipulg <vipulg@adobe.com>
Co-authored-by: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com>
Co-authored-by: Sanjay Saravanan <saravana@adobe.com>
nkthakur48 added a commit to adobecom/da-cc that referenced this pull request Mar 17, 2026
…dobecom#928)

* [MWPW-189426, MWPW-189301] Changes to conditionally inject prompt bar or dropzone in upload marquee (adobecom#911)

* Changes to conditionally inject prompt bar or dropzone in upload marquee

* refactoring changes to avoid code duplication

* nit comments

* fixing merge conflicts issue

* Renaing upload variant to dropzone variant

* css change to center align the left col in case of prompt bar

* pr comments

* nit changes

* removing unused vars

---------

Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>
Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>

* [MWPW-189581] cards rendered in ipad mode is not as expected when traversed from hint mode and navigated back (adobecom#917)

* fix

* carousel-swipe

---------

Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com>
Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local>

* [MWPW-189676]: [ACOM] Doodlebug CSS changes in "Aside" block to support video on Desktop (adobecom#918)

* Fixed aside video css on doodlebug

* Minor changes

* Added image class selector

* MWPW-189681: Editorial card changes for doodle bug (adobecom#920)

Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>

* [MWPW-189467][DOTCOM-179535][MWPW-189479] Upload Marquee A11y fixes (adobecom#921)

* [MWPW-189467][DOTCOM-179535][MWPW-189479] Upload Marquee A11y fixes

* remove aria lables from branding icons

---------

Co-authored-by: vipulg <vipulg@adobe.com>

* MWPW-189453 Adding text above dropzone (adobecom#903)

Co-authored-by: Sanjay Saravanan <saravana@adobe.com>
Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>

* [MWPW-189839] fix video controls on upload-marquee (adobecom#924)

* [MWPW-189839] fix video controls on upload-marquee

* show play/pause button even when reduce motion is set

* revert play/pause

* Revert "revert play/pause"

This reverts commit 65b26d4.

---------

Co-authored-by: vipulg <vipulg@adobe.com>
Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>

* [MWPW-189798]: [Doodlebug Wave] Added border to play pause control in video (adobecom#926)

* Added border on play/pause button

* Minor change

* Fixed marque button

---------

Co-authored-by: Arushi Gupta <65466846+arugupta1992@users.noreply.github.com>
Co-authored-by: Arushi Gupta <arugupta@Arushis-MacBook-Pro.local>
Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
Co-authored-by: Drashti Modasara <drashti1712@gmail.com>
Co-authored-by: Drashti Modasara <dmodasara@drashtis-mbp.corp.adobe.com>
Co-authored-by: Drashti Modasara <dmodasara@Drashtis-MacBook-Pro.local>
Co-authored-by: Harshad Khatana <hkhatana@adobe.com>
Co-authored-by: Vipul Gupta <vipugpta@gmail.com>
Co-authored-by: vipulg <vipulg@adobe.com>
Co-authored-by: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com>
Co-authored-by: Sanjay Saravanan <saravana@adobe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants