MWPW-187834: Add support for Doodlebug - I#885
Merged
nkthakur48 merged 110 commits intostagefrom Feb 27, 2026
Merged
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
nkthakur48
requested review from
drashti1712,
hkuraware,
saurabhsircar11,
suhjainadobe and
vipu0303
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| async function buildUploadActionControls(para, columnId, getAriaLabels) { | ||
| const buttonLabel = para.textContent.trim().split('|')[0].trim() || 'Upload your image'; | ||
| const { filePickerAriaSuffix } = await getAriaLabels(); | ||
| const inputId = buildScopedId('file-upload', columnId); |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'inputId' is assigned a value but never used.
suhjainadobe
approved these changes
Feb 27, 2026
saurabhsircar11
approved these changes
Feb 27, 2026
Collaborator
|
Validation done on the pr on below url on all the listed blocks , details are added in respective tickets |
nkthakur48
added a commit
that referenced
this pull request
Mar 5, 2026
nkthakur48
added a commit
to adobecom/da-cc
that referenced
this pull request
Mar 17, 2026
* firefly carousel * firefly carousel * firefly-accordion:feat: added firefly accordion * firefly-accordion:feat: resolved conflict with accordion * firefly carousel * firefly-accordion:feat: corrected font and padding bottom * firefly-accordion:fix: fixed animation issue * firefly-accordion:feat: handled link issue * firefly carousel * firefly carousel * firefly carousel * firefly carousel * firefly carousel * firefly carousel * firefly-accordion:feat: fixed link click * firefly-accordion:feat: links to open in new tab * feat: aria hidden for step span * fix: removed aria hidden * firefly-share:feat: added code for firefly share * feat: updated svg icons * firefly-share:feat: added or condition for miloLibs * firefly-share:feat: change for dark mode * firefly-share:feat: fallback to milo share * firefly carousel * firefly carousel * feat: firefly share xxl-heading * feat: reduced icon size * testcommit * initial commit * upload-marquee block * more changes * css fixes * minor css change * a11y updates * css update * css fixes * css feedback * minor css fix * remove unwanted css * code restructuring * minor updates * css updates * new doodlebug css and milo changes * new doodlebug css and milo changes * new doodlebug css and milo changes * new doodlebug css and milo changes * carousel accessibility * feat: changes to firefly howto * feat: uncommented decorate content * firefly-howto: feat: removed links * firefly-how-to:feat: added outline to whole card * hinting-tablet and hinting mobile * editorial cards gap * firefly-share:fix: fixed css issue * firefly-share: fixed font size issue * Adding aria fixes in upload-marquee (aria labels, reduced motion etc) (adobecom#881) * Adding aria fixes in upload-marquee (aria labels, reduced motion etc) * fix linting in upload-marquee --------- Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * editorial cards gap * editorial cards gap * swipping of firefly-carousel on mobile manually * reduce gap between text and icon in text prompt * firefly-share:fix: left align of heading text * reduce gap between text and icon in text prompt * firefly-howto:feat: changed gap to 20 * text:fix: updated for text style * carousel last card * grid-cta:fix: added ellipsis * firefly-howto:fix: increased font size of step indicator * carousel last card * firefly-howto:fix: fixed the padding issue * firefly-howto: fix: removed absolute for icon kept in grid * firefly-howto:fix: when for step text is long * firefly-howto:fix: when for step text is long * fix upload-marquee font family issue * aside block fallback for tablet * aside block fallback for tablet * aside block fallback for tablet * aside block fallback for tablet * firefly-share:fix: fixed letter spacing * firefly-howto:fix: increased specificity * editorial cards h3 letter-spacing to -3% * font size for editorial pixels to 20px * changed font sizes to rem * Adding focus on carousel card when tabbed * firefly-share: fix: changed icon size * firefly-howto:fix: seo results fix * grid-cta:fix: link * Add specificity to upload-marquee css (adobecom#883) * Add specificity to upload-marquee css * review comment * Revert "review comment" This reverts commit 09b5e75. --------- Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com> * grid-cta:fix:added rtl style * fix: added where to reduce specificity * firefly-howto:fix: removed section * feat: [DB] Refactored Upload Marquee block * fix: [DB] Upload Marquee CTA trigger event with correct payload * font weight for editprial cards * focus border on nav buttons * right left arrow support for firefly-carousel * firefly-share: fix: added the file in cc-shared * firefly-share:fix: file deleted from firefly-share * [DB]: Cleanup unused variable --------- Co-authored-by: Suhani <suhjain@Suhanis-MacBook-Pro.local> Co-authored-by: Saurabh Sircar <saurabhsircar11@gmail.com> Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Vipul Gupta <vipugpta@gmail.com> (cherry picked from commit edd625f)
nkthakur48
added a commit
to adobecom/da-cc
that referenced
this pull request
Mar 17, 2026
- #14 - #15 - #17 - adobecom#862 - adobecom#870 - adobecom#873 - adobecom#881 - adobecom#883 - adobecom#885 - adobecom#886 - adobecom#887 - adobecom#889 - adobecom#890 - adobecom#891 - adobecom#893 - adobecom#895 - adobecom#896 - adobecom#899 - adobecom#901 - adobecom#902 - adobecom#903 - adobecom#904 - adobecom#905 - adobecom#906 - adobecom#907 - adobecom#908 - adobecom#909 - adobecom#910 - adobecom#911 - adobecom#913 - adobecom#917 - adobecom#918 - adobecom#920 - adobecom#921 - adobecom#924 - adobecom#926 - adobecom#927 - adobecom#928 - adobecom#929 - adobecom#930 - adobecom#932 - adobecom#933 - adobecom#935
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for DoodleBug (for Summit), creating new and tweaking some of the existing blocks to achieve the desired designs.
Resolves: MWPW-187834
Test URLs: