Skip to content

[MWPW-186999 ]-Fix applied for the CTA issue on Samsung devices.#873

Merged
nkthakur48 merged 2 commits intostagefrom
mwpw-186999-cta-bug-s8
Feb 18, 2026
Merged

[MWPW-186999 ]-Fix applied for the CTA issue on Samsung devices.#873
nkthakur48 merged 2 commits intostagefrom
mwpw-186999-cta-bug-s8

Conversation

@hkhatana26
Copy link
Copy Markdown
Collaborator

@hkhatana26 hkhatana26 commented Feb 3, 2026 •
edited
Loading

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Feb 3, 2026 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Feb 3, 2026

Page Scores Audits Google
📱 /drafts/harshad/firefly-samsung Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI
🖥️ /drafts/harshad/firefly-samsung Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI

@milo-pr-merge-cc
Copy link
Copy Markdown

milo-pr-merge-cc Bot commented Feb 3, 2026

Skipped merging 873: [MWPW-186999 ]-Fix applied for the CTA issue on Samsung devices. due to failing checks

nkthakur48
nkthakur48 requested changes Feb 4, 2026
View reviewed changes
Comment thread creativecloud/blocks/firefly-model-showcase/firefly-model-showcase.css Outdated
padding: 12px;
}
}
@media screen and (max-width: 360px) and (min-width: 360px) {
Copy link
Copy Markdown
Collaborator

@nkthakur48 nkthakur48 Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean by max width and min width as 360 px? Shouldn't a range be targeted?

Copy link
Copy Markdown
Collaborator Author

@hkhatana26 hkhatana26 Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve updated the media query to use a proper range (max-width: 360px) instead of using both min-width and max-width with the same value, so it applies consistently across small screens.

@milo-pr-merge-cc
Copy link
Copy Markdown

milo-pr-merge-cc Bot commented Feb 4, 2026

Skipped merging 873: [MWPW-186999 ]-Fix applied for the CTA issue on Samsung devices. due to failing checks

@aem-code-sync aem-code-sync Bot temporarily deployed to mwpw-186999-cta-bug-s8 February 5, 2026 04:55 Inactive
@milo-pr-merge-cc
Copy link
Copy Markdown

milo-pr-merge-cc Bot commented Feb 5, 2026

Skipped merging 873: [MWPW-186999 ]-Fix applied for the CTA issue on Samsung devices. due to failing checks

@hkhatana26 hkhatana26 requested a review from nkthakur48 February 6, 2026 05:08
@milo-pr-merge-cc
Copy link
Copy Markdown

milo-pr-merge-cc Bot commented Feb 9, 2026

Skipped merging 873: [MWPW-186999 ]-Fix applied for the CTA issue on Samsung devices. due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

milo-pr-merge-cc Bot commented Feb 10, 2026

Skipped merging 873: [MWPW-186999 ]-Fix applied for the CTA issue on Samsung devices. due to failing checks

@spadmasa
Copy link
Copy Markdown
Collaborator

spadmasa commented Feb 10, 2026

Validation done on the pr on the different devices
https://mwpw-186999-cta-bug-s8--cc--adobecom.aem.live/de/products/firefly/landpa
image
image

@milo-pr-merge-cc
Copy link
Copy Markdown

milo-pr-merge-cc Bot commented Feb 11, 2026

Skipped merging 873: [MWPW-186999 ]-Fix applied for the CTA issue on Samsung devices. due to failing checks

@aem-code-sync aem-code-sync Bot temporarily deployed to mwpw-186999-cta-bug-s8 February 11, 2026 06:42 Inactive
@milo-pr-merge-cc
Copy link
Copy Markdown

milo-pr-merge-cc Bot commented Feb 12, 2026

Skipped merging 873: [MWPW-186999 ]-Fix applied for the CTA issue on Samsung devices. due to failing checks

@aem-code-sync aem-code-sync Bot temporarily deployed to mwpw-186999-cta-bug-s8 February 12, 2026 09:01 Inactive
@aem-code-sync aem-code-sync Bot temporarily deployed to mwpw-186999-cta-bug-s8 February 12, 2026 09:57 Inactive
@aem-code-sync aem-code-sync Bot temporarily deployed to mwpw-186999-cta-bug-s8 February 12, 2026 09:57 Inactive
@milo-pr-merge-cc
Copy link
Copy Markdown

milo-pr-merge-cc Bot commented Feb 16, 2026

Skipped merging 873: [MWPW-186999 ]-Fix applied for the CTA issue on Samsung devices. due to failing checks

@nkthakur48
Copy link
Copy Markdown
Collaborator

nkthakur48 commented Feb 16, 2026

@hkuraware Could you please resolve the conflicts here?

@milo-pr-merge-cc
Copy link
Copy Markdown

milo-pr-merge-cc Bot commented Feb 17, 2026

Skipped merging 873: [MWPW-186999 ]-Fix applied for the CTA issue on Samsung devices. due to failing checks

@aem-code-sync aem-code-sync Bot temporarily deployed to mwpw-186999-cta-bug-s8 February 17, 2026 07:43 Inactive
@milo-pr-merge-cc
Copy link
Copy Markdown

milo-pr-merge-cc Bot commented Feb 18, 2026

Skipped merging 873: [MWPW-186999 ]-Fix applied for the CTA issue on Samsung devices. due to failing checks

@hkhatana26 hkhatana26 force-pushed the mwpw-186999-cta-bug-s8 branch from a845722 to 3c2ac77 Compare February 18, 2026 13:46
@nkthakur48 nkthakur48 merged commit 151a32f into stage Feb 18, 2026
7 of 8 checks passed
@milo-pr-merge-cc milo-pr-merge-cc Bot mentioned this pull request Feb 26, 2026
Merged
nkthakur48 added a commit that referenced this pull request Mar 5, 2026
@nkthakur48
[Release] Stage to Main 03/05
39f3796 
- #873
- #876
- #882
- #885
- #887
- #889
- #890
- #893
- #895
- #896
nkthakur48 pushed a commit to adobecom/da-cc that referenced this pull request Mar 17, 2026
@hkhatana26 @nkthakur48
[MWPW-186999 ]-Fix applied for the CTA issue on Samsung devices. (ado…
e3c4a17 
…becom#873)

* fix for cta bug on samsung device

* resolved pr comment

(cherry picked from commit 151a32f)
@nkthakur48 nkthakur48 mentioned this pull request Mar 17, 2026
Merged
nkthakur48 added a commit to adobecom/da-cc that referenced this pull request Mar 17, 2026
@nkthakur48
[Release] Stage to Main 03/17
b6ea242 
- #14
- #15
- #17
- adobecom#862
- adobecom#870
- adobecom#873
- adobecom#881
- adobecom#883
- adobecom#885
- adobecom#886
- adobecom#887
- adobecom#889
- adobecom#890
- adobecom#891
- adobecom#893
- adobecom#895
- adobecom#896
- adobecom#899
- adobecom#901
- adobecom#902
- adobecom#903
- adobecom#904
- adobecom#905
- adobecom#906
- adobecom#907
- adobecom#908
- adobecom#909
- adobecom#910
- adobecom#911
- adobecom#913
- adobecom#917
- adobecom#918
- adobecom#920
- adobecom#921
- adobecom#924
- adobecom#926
- adobecom#927
- adobecom#928
- adobecom#929
- adobecom#930
- adobecom#932
- adobecom#933
- adobecom#935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nkthakur48 nkthakur48 nkthakur48 approved these changes

@hkuraware hkuraware hkuraware approved these changes

@suhjainadobe suhjainadobe Awaiting requested review from suhjainadobe

Assignees

@spadmasa spadmasa

Labels

ready for stage verified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hkhatana26 @spadmasa @nkthakur48 @hkuraware