fix(sqllab): inactive leftbar selector on empty state

[justinpark]

User description

SUMMARY

fixes #38482
When a new blank tab is created in SQL Lab before any saved query editors are loaded, the SqlEditorLeftBar received an empty queryEditorId, causing the database/schema selector and table explorer to be inactive/broken.

This fix introduces a stable sentinel constant TMP_QUERY_ID that acts as a placeholder identity for the unsaved/blank query editor state. Key changes:

• useQueryEditor/index.ts: Exports TMP_QUERY_ID = 'tmp_qe_id' and ensures the hook returns a valid id when the selector ID matches this sentinel.
• SqlEditorLeftBar/index.tsx: Falls back to TMP_QUERY_ID when queryEditorId is empty, so useDatabaseSelector and TableExploreTree always receive a
  valid ID.
• actions/sqlLab.ts: In addNewQueryEditor(), the active query editor lookup now falls back to { id: TMP_QUERY_ID } instead of undefined, so blank-tab
  state (dbId, catalog, schema) is correctly inherited when opening a new tab.
• reducers/sqlLab.ts: Guards alterUnsavedQueryEditorState against an empty tabHistory array to avoid a stale index lookup.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

before--sqllab-tmp-editor-state.mov

After:

after--sqllab-tmp-editor-state.mov

TESTING INSTRUCTIONS

1. Open SQL Lab with no previously saved query editors.
2. Click + to open a new blank tab.
3. Verify the left panel (database selector, schema selector, table explorer) is active and interactive.
4. Select a database/schema in the blank tab, then open another new tab — verify the new tab inherits the selected context.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

---

CodeAnt-AI Description

Keep SQL Lab controls active in blank tabs and carry over the selected database context

What Changed

• Blank SQL Lab tabs now keep the database selector, schema selector, and table browser active instead of becoming unresponsive
• New tabs opened from a blank state now inherit the selected database, catalog, and schema from the current empty tab
• The empty-tab behavior is covered by new tests to prevent regressions

Impact

✅ Active database and schema selection in blank tabs
✅ Fewer broken left-panel controls
✅ Preserved context when opening a new SQL Lab tab

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

[bito-code-review]

Code Review Agent Run #c18ac8

Actionable Suggestions - 0

Review Details

• Files reviewed - 6 · Commit Range: c2b007e..c2b007e

  • superset-frontend/src/SqlLab/actions/sqlLab.test.ts
  • superset-frontend/src/SqlLab/actions/sqlLab.ts
  • superset-frontend/src/SqlLab/components/SqlEditorLeftBar/SqlEditorLeftBar.test.tsx
  • superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
  • superset-frontend/src/SqlLab/hooks/useQueryEditor/index.ts
  • superset-frontend/src/SqlLab/reducers/sqlLab.ts
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • Eslint (Linter) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codeant-ai-for-open-source]

Sequence Diagram

This PR ensures blank SQL Lab tabs always use a stable temporary query editor id so the left panel remains interactive even before a real editor is saved. It also makes new tabs inherit database, catalog, and schema from that temporary unsaved state.

sequenceDiagram
    participant User
    participant LeftBar
    participant QueryEditorHook
    participant SqlLabState
    participant AddNewTabAction

    User->>LeftBar: Open new blank tab
    LeftBar->>LeftBar: Fallback to TMP_QUERY_ID when id is empty
    LeftBar->>QueryEditorHook: Load editor context with TMP_QUERY_ID
    QueryEditorHook-->>LeftBar: Return placeholder editor identity
    User->>LeftBar: Choose database and schema
    LeftBar->>SqlLabState: Save unsaved context under TMP_QUERY_ID
    User->>AddNewTabAction: Open another new tab
    AddNewTabAction->>SqlLabState: Read active editor or TMP_QUERY_ID context
    AddNewTabAction-->>User: Create tab with inherited database context

Loading

---

Generated by CodeAnt AI

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	c2b007e
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/69c326677be6d20008bf76cd
😎 Deploy Preview	https://deploy-preview-38833--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[michael-s-molina]

@justinpark Can't we use the immutableId which is always generated? If not, can we initialize the id with tmp_qe_id instead of keeping multiple checks? I prefer the immutableId option if possible.

[justinpark]

justinpark Can't we use the immutableId which is always generated? If not, can we initialize the id with tmp_qe_id instead of keeping multiple checks? I prefer the immutableId option if possible.

The reason we cannot use an immutable ID is because the approach stores the state in an unsaved state only when it is in an empty state, unlike the state that exists in the query editor. Therefore, we need to know that the current value was generated from the empty state, which makes it difficult to handle a value that changes every time.
If the variable name is not clear enough, how about renaming it to something like EMPTY_STATE_QE_ID?

[michael-s-molina]

If the variable name is not clear enough, how about renaming it to something like EMPTY_STATE_QE_ID?

Sounds good 👍🏼

[bito-code-review]

Code Review Agent Run #9957ec

Actionable Suggestions - 0

Review Details

• Files reviewed - 5 · Commit Range: c2b007e..3581133

  • superset-frontend/src/SqlLab/actions/sqlLab.test.ts
  • superset-frontend/src/SqlLab/actions/sqlLab.ts
  • superset-frontend/src/SqlLab/components/SqlEditorLeftBar/SqlEditorLeftBar.test.tsx
  • superset-frontend/src/SqlLab/components/SqlEditorLeftBar/index.tsx
  • superset-frontend/src/SqlLab/hooks/useQueryEditor/index.ts
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • Eslint (Linter) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by