fix(tests): improve ShareMenuItems test isolation to fix intermittent suite failure

[mistercrunch]

SUMMARY

Fixes flaky ShareMenuItems.test.tsx test suite that was intermittently crashing Jest workers in CI (sharded-jest-tests shard 3) with "Test suite failed to run" errors.

Root causes:

• window.location leaked across suites — Was deleted in beforeAll and only restored in afterAll. If the Jest worker reused the environment after a prior suite crash, window.location stayed deleted, causing setup failure.
• window.featureFlags never cleaned up — 5 tests set it but never removed it, leaking state to other suites in the same worker.
• fetchMock routes accumulated — Routes set once in beforeAll; the last test modified them without restoring. Stale route state could corrupt subsequent test runs.
• Missing await on userEvent.click() — Fire-and-forget clicks could race with async state updates.

Fixes:

• Move window.location setup/teardown to beforeEach/afterEach for per-test isolation
• Clean up window.featureFlags in afterEach
• Reset fetchMock routes and history in beforeEach/afterEach
• Add await to all userEvent.click() calls

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A — test-only change

TESTING INSTRUCTIONS

cd superset-frontend
npx jest src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx --no-coverage

All 10 tests should pass. The fix addresses non-deterministic failures that only manifest when Jest workers carry polluted state from prior test suites.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #ec5118

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 678c1b2..678c1b2

  • superset-frontend/src/dashboard/components/menu/ShareMenuItems/ShareMenuItems.test.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	678c1b2
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/69d93d07f4a4ab0008d999b5
😎 Deploy Preview	https://deploy-preview-39280--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.33%. Comparing base (aba7e6d) to head (8143b4b).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #39280   +/-   ##
=======================================
  Coverage   64.33%   64.33%           
=======================================
  Files        2553     2553           
  Lines      132461   132461           
  Branches    30720    30720           
=======================================
  Hits        85218    85218           
  Misses      45757    45757           
  Partials     1486     1486           

Flag	Coverage Δ
javascript	65.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bito-code-review]

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it