[pull] master from getsentry:master#844
Merged
pull[bot] merged 17 commits intocode-watch:masterfrom May 4, 2021
Merged
Conversation
When the light results error, this should not be emitted. Instead, it should remain in a loading state and wait for the full results to load.
* fix(ui): Dedupe suggested assignees Dedupe suggested assignees. If Team/Member is a Suggested Assignee, don't display under Teams/People. FIXES WOR-807 * refactor * refactor
…#25845) Calling `pre-commit` is noticeably slower than calling `command -v pre-commit`. This fixes it and adjusts other output suggestions. Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
Update all the tests with react-codemod to remove the now redundant imports and add destructured reports where possible.
The span duration header was right aligned which looks off compared to the visualization inside the grid cells in the rows below. This will check the column names against the list of ops breakdown options to force left alignment
Tag explorers duration header should have it's copy changed based on which column is being sorted on, but the refactor changed how the adjusted columns were getting passed. This fixes it and adds a couple test to ensure it stays fixed
* feat(trace-view): Add an event when trace has >1 project - Also add tags for projects in the trace grouped, this is cause the existing num_projects tag is the number of projects in the query
…ion summary page (#25829)
We have a new home page for the sandbox! Redirects for logged-out users should go there.
This is the first step towards removing transactions from post processing entirely. It simply groups the post processing transaction code so it can be more easily refactored later. The only functional change included here is that the metric events.processed is no longer inclusive of transactions.
Apply the import codemod to static/app.
* fix(perf): Hide related issues when key_transaction is present Passing key_transactions to the issues endpoint doesn't work and currently causes an error, so this PR will hide the issues components when that tag is present as a workaround. Refs VIS-716
…#25853) Chart labels on vital details page should respect the type of the vital. Specifically, CLS is not a duration based vital like the others and should not be formatted as a duration.
* fix(perf): Return standardized tag keys and tag values Previously we were returning values directly from snuba (eg. sentry:release instead of just release), which isn't helpful since we usually want to put a tag key and value right back into a query. This re-uses the same functions that event-facets uses to standardize the tag data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )