Add Apple's swift-format as a linter #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klaaspieter
force-pushed
the
swift-format
branch
from
08eb0f5
to
9e15e5a
Compare
|
I can't make any sense of the Travis failure. I get completely different failures locally (even on master) making it hard to fix them... It also looks like there is (yet another) failure on master. Any help debugging this would be appreciated. This is my test run locally (mac os) on master:
$ ./run-tests --linters-only
Starting Vint...
Starting Custom checks...
|
|
Anything I can do to move this forward? |
w0rp
requested changes
Apr 29, 2020
There was a problem hiding this comment.
The only issue here is the list of supported tools, which the linter job is complaining about. There are two different entries for swiftformat and swift-format. It will expect the names with minuses to come before or after other characters in the list somewhere.
klaaspieter
force-pushed
the
swift-format
branch
2 times, most recently
from
aafda3b
to
d430729
Compare
klaaspieter
force-pushed
the
swift-format
branch
from
d430729
to
2548763
Compare
|
@w0rp fixed now. 馃槃 |
|
This pull request has been automatically marked as stale because it has not been updated recently. Make sure to write tests and document your changes. See |
w0rp
approved these changes
Aug 17, 2020
|
Cheers! 馃嵒 People might be confused by there being two different tools that sound the same. I guess that's a problem for Swift. |
|
100% agree. SwiftFormat is a community project while swift-format is an Apple project. To make matters even more complicated the Apple project seems to largely be maintained by Google engineers 馃く Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds swift-format as a linter.
There are a couple of trade-offs to be aware of:
swift run swift-formatwhen inside a Swift package. Usingswift runmeans it'll build the package and then runswift-format. This can potentially take a while and I've seen it break when the build was interupted. The alternative is to look for swift-format in./build/debug/swift-formatbut it won't exist if the package hasn't been built.ale_linters#swift#swiftformat#Handlebut it doesn't seem to get called whenswift runfails.swift-formatgenerally isn't installed in$PATHwhich means most users will have to setswift_swiftformat_executable. The version ofswift-formatthat is installed by the default (outside of$PATH) is very out of date and is not compatible with this linter implementation.