add type: ignore

[paul-nechifor]

This PR enables all mypy checks and adds # type: ignore[...] for all current mypy errors (~4000).

This means that we'll get errors on code which fails type-checking from now on.

Greptile Overview

Greptile Summary

This PR enables strict mypy type checking across the entire codebase by adding # type: ignore[error-code] comments to suppress approximately 4000 existing type errors across 306 files. The changes consolidate mypy configuration from a separate mypy_strict.ini file into pyproject.toml and enable strict = true mode.

Key Changes:

• Removed mypy_strict.ini and consolidated configuration into pyproject.toml
• Enabled strict mypy checking with strict = true and python_version = "3.12"
• Added 3745 # type: ignore comments with specific error codes across the codebase
• Removed file scope restrictions - mypy now checks all files except test files and Detic models
• Minor formatting improvements (multi-line function arguments for better readability)

Impact:

• Future code changes will now require type compliance - new type errors will be caught at CI time
• Existing type errors are documented and suppressed, creating a baseline for gradual improvement
• No logic changes or behavioral modifications were introduced

Confidence Score: 5/5

• This PR is safe to merge with minimal risk - it's a mechanical change that adds type: ignore comments without altering logic
• Score reflects that this is a pure tooling/configuration change with no functional modifications. All changes are either comment additions or configuration updates. The systematic approach of suppressing existing errors while enabling strict checking going forward is a best practice for incremental type safety improvements.
• No files require special attention - all changes follow the same mechanical pattern of adding type: ignore comments

Important Files Changed

File Analysis

Filename	Score	Overview
mypy_strict.ini	5/5	Removed obsolete separate mypy config file, consolidated into pyproject.toml
pyproject.toml	5/5	Enabled strict mypy checking with python 3.12, removed limited file scope
bin/mypy-strict	5/5	Removed reference to deleted mypy_strict.ini config file
dimos/core/module.py	5/5	Added type: ignore for untyped defs, union-attr, and assignment issues
dimos/protocol/pubsub/spec.py	5/5	Added type: ignore for untyped defs, type-arg, and return type issues
dimos/core/transport.py	5/5	Added type: ignore for TypeVar, untyped defs, and transport implementation issues

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Mypy as Mypy Type Checker
    participant Config as pyproject.toml
    participant Code as Python Codebase
    
    Dev->>Config: Enable strict=true mode
    Dev->>Config: Remove file scope restrictions
    Dev->>Mypy: Run mypy with strict checks
    Mypy->>Code: Analyze all files for type errors
    Code-->>Mypy: ~4000 type errors found
    Mypy-->>Dev: Report type errors
    Dev->>Code: Add # type: ignore[error-code] comments
    Note over Code: 3745 type: ignore comments added<br/>across 306 files
    Dev->>Config: Remove mypy_strict.ini
    Dev->>Config: Consolidate config to pyproject.toml
    Dev->>Mypy: Run mypy again
    Mypy->>Code: Check all files
    Code-->>Mypy: All errors suppressed with type: ignore
    Mypy-->>Dev: Type checking passes
    Note over Dev,Code: Future code changes will now<br/>require type compliance

Loading

[spomichter]

@greptile

[greptile-apps]

_{306 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}