cli-precedence

[paul-nechifor]

No description provided.

[chatgpt-codex-connector]

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

[greptile-apps]

Greptile Overview

Greptile Summary

Changed configuration precedence to give CLI arguments highest priority over blueprint overrides. Previously, blueprint overrides via .global_config() took precedence over CLI args, which was counterintuitive.

Key Changes

• Modified ModuleBlueprintSet.build() to accept cli_config_overrides parameter instead of full GlobalConfig object
• Refactored CLI to pass overrides dict rather than instantiating GlobalConfig early
• Updated config application order: defaults → .env → blueprint overrides → CLI args (highest priority)
• Updated tests to match new build() signature
• Updated README to reflect corrected precedence order

Confidence Score: 5/5

• This PR is safe to merge with minimal risk - the changes are well-structured, logically sound, and improve the expected behavior
• Clean refactoring with clear intent, proper type handling, consistent updates across all affected files, and tests updated to match new signature
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
dimos/core/blueprints.py	5/5	Changed precedence order for config overrides to give CLI args highest priority, proper parameter naming and type handling
dimos/core/test_blueprints.py	5/5	Updated test calls to match new build() signature without GlobalConfig parameter
dimos/robot/cli/dimos.py	5/5	Refactored to pass CLI overrides dict instead of GlobalConfig object, enabling proper config precedence
dimos/robot/cli/README.md	5/5	Updated documentation to reflect CLI args now have highest precedence (after blueprint overrides)

Sequence Diagram

sequenceDiagram
    participant CLI as CLI (dimos.py)
    participant Callback as Dynamic Callback
    participant RunCmd as Run Command
    participant Blueprint as ModuleBlueprintSet
    participant GC as GlobalConfig
    participant MC as ModuleCoordinator

    CLI->>Callback: Parse CLI args (--simulation, --robot-ip, etc)
    Callback->>Callback: Filter non-None values
    Callback->>RunCmd: Store overrides dict in ctx.obj

    RunCmd->>RunCmd: Get cli_overrides from ctx.obj
    RunCmd->>Blueprint: build(cli_config_overrides=cli_overrides)
    
    Blueprint->>GC: Create default GlobalConfig()
    GC-->>Blueprint: Default config with .env values
    
    Blueprint->>Blueprint: Apply blueprint overrides first
    Blueprint->>GC: model_copy(update=self.global_config_overrides)
    GC-->>Blueprint: Config with blueprint overrides
    
    Blueprint->>Blueprint: Apply CLI overrides last (highest priority)
    Blueprint->>GC: model_copy(update=cli_config_overrides)
    GC-->>Blueprint: Final config with CLI precedence
    
    Blueprint->>MC: Create ModuleCoordinator(global_config)
    MC-->>Blueprint: Configured coordinator
    
    Blueprint-->>RunCmd: Return coordinator
    RunCmd->>MC: loop()

Loading

[greptile-apps]

_{4 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}