Fix skills

[paul-nechifor]

It was broken because I forgot to update ConnectionModule to GO2Connection in the skills module.

[greptile-apps]

Greptile Summary

This PR completes the migration from the deprecated ConnectionModule to GO2Connection for Unitree robot skills. The changes include:

• Module Migration: Removed deprecated ConnectionModule and related files (dimos/robot/unitree_webrtc/modular/)
• RPC Pattern Update: UnitreeSkillContainer now uses the get_rpc_calls() pattern to dynamically lookup GO2Connection.publish_request instead of manual RPC injection
• Interface Updates: Updated test code to use new property names (video → color_image, movecmd → cmd_vel)
• Test Improvements: Simplified test fixtures by removing manual mock injections, tests now properly mock get_rpc_calls()
• Code Cleanup: Removed unused imports across multiple files and fixed linting warnings

The migration is complete and all components are properly aligned with the new GO2Connection API.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes are well-structured refactoring that replaces deprecated code with the proper implementation. All test code has been updated to match the new patterns, unused code has been removed, and the migration is consistent across all files. The RPC pattern change is a cleaner architecture that uses dynamic lookup instead of manual injection.
• No files require special attention

Important Files Changed

Filename	Overview
dimos/robot/unitree_webrtc/unitree_skill_container.py	Updated to use RPC-based connection pattern, replacing direct RPC injection with get_rpc_calls() lookup for GO2Connection.publish_request
dimos/agents/test_mock_agent.py	Updated import and property names from ConnectionModule to GO2Connection (video→color_image, movecmd→cmd_vel)
dimos/agents/skills/test_unitree_skill_container.py	Updated test mocking strategy to use get_rpc_calls mock, removed test_show_your_love test
dimos/agents/skills/conftest.py	Simplified unitree_skills fixture by removing manual mock injections for _move and _publish_request

Sequence Diagram

sequenceDiagram
    participant Test as Test Suite
    participant USC as UnitreeSkillContainer
    participant RPC as RPC System
    participant GO2 as GO2Connection
    
    Note over Test,GO2: Old Pattern (Removed)
    Test->>USC: set_ConnectionModule_publish_request(callable)
    USC->>USC: Store _publish_request
    Test->>USC: execute_sport_command("FrontPounce")
    USC->>USC: Call _publish_request directly
    
    Note over Test,GO2: New Pattern (Current)
    Test->>USC: start()
    USC->>RPC: Register rpc_calls list
    Note right of USC: ["GO2Connection.publish_request", ...]
    Test->>USC: execute_sport_command("FrontPounce")
    USC->>RPC: get_rpc_calls("GO2Connection.publish_request")
    RPC-->>USC: Return publish_request callable
    USC->>GO2: publish_request("rt/api/sport/request", {"api_id": 1032})
    GO2-->>USC: Result
    USC-->>Test: Success message

Loading