Merged
Conversation
* Add pixi content for recommendations and success state * Update recommendation texts * Add status banner
* ♻️ Refactoring * 🚧 Display relevant recommendations from index.json * ✨ Show tags in recommendation * 💄 Add margin * 🚧 Handle recommendation results * 🐛 Fix datastructure for new recommendation aggregation * 🐛 Fix typo * Implement linter check recommendation mapping * remove debugging code Co-authored-by: Robin Van Opstal <robin.van-opstal@jvm.de>
* 🎨 Create basic check partial * 💄 Adapt loading animation * 🚧 Replace default stage * 💄 Add drop shadow section stylings * ♻️ Remove unused recommendations skeleton * 💄 Stage / intro styling
* 💄 Intro section + banner styling * 🐛 Fix banner pointer events * 💄 Add scroll animation * 📱 Work on responsive design * 📱 Fix banner width * 💄 Set stage padding * 📱 Minor padding fixes
…#4283) * 🔧 Increase disk size for thumbor instances * 🔇 Only log errors for thumbor
* Add isAmp check to linter api * Add pixi "no-amp" status
* 🚧 Implement shring ui * 🚧 Implement sharing dialog * 📱 Fix responsive design * 💄 Close btn styling * 🎨 Create component for sharing dialog * 🚧 Add sharing logic * ✨ Set sharing url * 🎨 Code cleaning * 👌 Move shareURL construction to StatusView.js * 🚨 Fix padding * 🚨 Fix lint warning
* Basic pixi status banner rules Changed AmpLinterCheck to not throw when the url could not be loaded in order to handle this case like any other check. Also added unit test for recommendations rules. The status banner rules are currently not used in the frontend.
* 🍱 Update imported documents. * 🎨 Let remote documents not break build
Co-authored-by: Shishir Malani <mshishir@google.com>
* Redirects for pixi Should we add any other? * Add vitals redirects
* feat: translated amp-audio.md * Update amp-audio-v0.1@zh_CN.md Remove redundant code * feat: translated components * Update amp-date-picker-v0.1@zh_CN.md fixed
* 🐛 Fix section z index * 🐛 Fix tablet brakpoint * 🐛 Adapt gradient position * 🐛 Fix gradient/stripes positioning for tablet bp
* 🐛 Add hyphens to wrap code snippets * 👌 Use overflow-wrap instead of hyphens
* ♻️ Code cleanings * ✨ Add next advide button markup * ✨ Add logic for next advice button * 🐛 Fix broken icon due to cloneNode * 🐛 Correctly anchor next advise below fixed header * 🐛 Fix broken icon * 🚨 Fix lint warnings * Update pixi/src/ui/recommendations/RecommendationsView.js Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * 👌 Set role="region" on item-body * 💬 Update "Next advice" text * Update pixi/src/ui/recommendations/RecommendationsView.js Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * ♻️ Remove duplicate code * ♻️ Beautify * 🐛 Add wrapping container in recommendations item to correctly set its height * 🐛 Beautify scss Co-authored-by: Matthias Rohmer <rohmer.matthias@anyvent.org> Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> Co-authored-by: Matthias Rohmer <12857772+matthiasrohmer@users.noreply.github.com>
* ♻️ Run linter check first and in blocking manner for Pixi * 🚸 Do not show Fix it now button if there is nothing to fix * 🚨 Fix linter warnings. * ✅ Adapt tests to new function signature * 🚨 Fix linter warnings * 🎨 Use simple truthyness check
* Create template URL * Use template string * Move to separate file * Use encodeURIComponent * Unobfuscate message of body * Rename url -> issueUrl
* 🔧 Enable AGGRESSIVE_BUNDLE for Pixi build * 🚨 Fix linter warnings.
* 💬 Use corrent i18n identifier for success state * ♻️ Do not rely on AMP.getState to get Pixi sharing URL
* 🤡 Update PSI data to show uses-webp-images et. al. reccommendations * ✨ Pass audit details through to recommendation engine * ✨ Render ressource hints in related recommendations * 🚨 Fix linter warnings.
* 🐛 Reset aria expanded on header * 🚨 Fix lint warning * 🎨 Reuse querySelector for recommendation header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.