feat(metrics): Register MRI for spans/count_per_root_project #78992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
obostjancic
approved these changes
Oct 11, 2024
vgrozdanic
approved these changes
Oct 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #78992 +/- ##
==========================================
- Coverage 78.30% 78.29% -0.02%
==========================================
Files 7128 7128
Lines 313605 313606 +1
Branches 51173 51173
==========================================
- Hits 245568 245536 -32
- Misses 61628 61649 +21
- Partials 6409 6421 +12 |
jan-auer
added a commit
that referenced
this pull request
Oct 21, 2024
* master: (288 commits) feat(metrics): Register MRI for spans/count_per_root_project (#78992) feat(dynamic-sampling): Settings for sample rate (#79341) Revert "feat(sentry-sdk): Enable HTTP2 transport" (#79391) fix(feedback): keep oldest date_added for duplicate user reports (#79387) chore(issue-stream): Remove tooltip for Unhandled (#79385) chore(autofix): Show banner if gen AI consent is given, even if no feature flag (#79362) chore(autofix+copilot) Allow autofix without FF if gen AI consent given (#79361) Fixes VULN-50 by enforcing option (#79384) perf(issues): improve adjacent_events query (#79365) feat(issues): Add anchor links back to issue sections (#79333) fix(issue-views): Make tab bar take up entire row (#79383) chore(issues): Add additional metrics for ownership matching (#79302) feat(insights): create screen rendering module (#79192) fix(issues): Avoid streamline issue layout rerenders (#79327) ref(performance): Add missing types to performance widgets (#79301) chore(issue-views): Add translation wrapper to aria label (#79320) chore(issue-stream): Reduce font size of title and message (#79378) feat(insights): update headers and breadcrumbs on frontend domain view (#78945) feat(insights): add view trends button to ai overview (#78611) ref(rr6): Remove unused param (#79379) ...
kneeyo1
pushed a commit
that referenced
this pull request
Oct 21, 2024
Adds a new shared string for `c:spans/count_per_root_project@none`, which is going to be used for dynamic sampling on spans. The metric is not yet emitted or used. The string must be shared because Dynamic Sampling runs a cross-org metrics query for this metric.
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
Adds a new shared string for `c:spans/count_per_root_project@none`, which is going to be used for dynamic sampling on spans. The metric is not yet emitted or used. The string must be shared because Dynamic Sampling runs a cross-org metrics query for this metric.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new shared string for
c:spans/count_per_root_project@none, which isgoing to be used for dynamic sampling on spans. The metric is not yet emitted or
used.
The string must be shared because Dynamic Sampling runs a cross-org metrics
query for this metric.
Ref https://github.com/getsentry/projects/issues/198
See also getsentry/relay#4134