ref(performance): Add missing types to performance widgets #79301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a lot of these were really similar GenericPerformanceWidgetProps components part of getsentry/frontend-tsc#79
github-actions
bot
added
the
Scope: Frontend
scttcper
commented
Oct 17, 2024
Comment on lines
+755
to
+756
| const Visualizations: GenericPerformanceWidgetProps<DataType>['Visualizations'] = | ||
| organization.features.includes('performance-new-widget-designs') |
Member
Author
There was a problem hiding this comment.
lots of the changes in this pr should be just the whitespace changes
scttcper
commented
Oct 17, 2024
| [PerformanceWidgetSetting.SLOW_SCREENS_BY_WARM_START]: | ||
| 'count_starts(measurements.app_start_warm)', | ||
| } as any | ||
| )[props.chartSetting]; |
Member
Author
There was a problem hiding this comment.
can't cast this to keyof itself
scttcper
commented
Oct 17, 2024
| <StackedAreaChart | ||
| {...provided.widgetData.chart} | ||
| {...provided} | ||
| {...(provided as any)} |
Member
Author
There was a problem hiding this comment.
the types here don't totally line up and it was previously any
gggritso
approved these changes
Oct 18, 2024
Comment on lines
+644
to
+648
| const description = listItem[SpanMetricsField.SPAN_DESCRIPTION] as string; | ||
| const group = listItem[SpanMetricsField.SPAN_GROUP] as string; | ||
| const projectID = listItem['project.id'] as number; | ||
| const timeSpentPercentage = listItem[fieldString] as number; | ||
| const totalTime = listItem[`sum(${SpanMetricsField.SPAN_SELF_TIME})`] as number; |
Member
There was a problem hiding this comment.
Out of curiosity, why the change to as here?
Member
Author
There was a problem hiding this comment.
before the type was
const totalTime: number = any which was fine. But now it's const totalTime = string | number so it has to be casted to number. I could've left the const totalTime: number i guess
harshithadurai
pushed a commit
that referenced
this pull request
Oct 19, 2024
jan-auer
added a commit
that referenced
this pull request
Oct 21, 2024
* master: (288 commits) feat(metrics): Register MRI for spans/count_per_root_project (#78992) feat(dynamic-sampling): Settings for sample rate (#79341) Revert "feat(sentry-sdk): Enable HTTP2 transport" (#79391) fix(feedback): keep oldest date_added for duplicate user reports (#79387) chore(issue-stream): Remove tooltip for Unhandled (#79385) chore(autofix): Show banner if gen AI consent is given, even if no feature flag (#79362) chore(autofix+copilot) Allow autofix without FF if gen AI consent given (#79361) Fixes VULN-50 by enforcing option (#79384) perf(issues): improve adjacent_events query (#79365) feat(issues): Add anchor links back to issue sections (#79333) fix(issue-views): Make tab bar take up entire row (#79383) chore(issues): Add additional metrics for ownership matching (#79302) feat(insights): create screen rendering module (#79192) fix(issues): Avoid streamline issue layout rerenders (#79327) ref(performance): Add missing types to performance widgets (#79301) chore(issue-views): Add translation wrapper to aria label (#79320) chore(issue-stream): Reduce font size of title and message (#79378) feat(insights): update headers and breadcrumbs on frontend domain view (#78945) feat(insights): add view trends button to ai overview (#78611) ref(rr6): Remove unused param (#79379) ...
cmanallen
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a lot of these were really similar GenericPerformanceWidgetProps components
part of https://github.com/getsentry/frontend-tsc/issues/79