feat(dynamic-sampling): Settings for sample rate #79341
Conversation
github-actions
bot
added
the
Scope: Frontend
|
The demo video shows both a period and a comma as the decimal separator in the input and in the feedback below - can we unify this somehow? |
| return api.requestPromise(endpoint, { | ||
| method: 'PUT', | ||
| data: { | ||
| targetSampleRate: Number(fields.targetSampleRate.value) / 100, |
There was a problem hiding this comment.
just a thought: do we want to make sure this is of certain precision?
@shellmayr yes, I noticed that too. Out of whatever reason the native number input insists on using |
Ah ok, gotcha - thanks! I think we should definitely take care of this before launching it widely, but I agree let's see what the conditions are under which this happens so we can make it work thoroughly. |
| <Button disabled={!formState.hasChanged || isPending} onClick={handleReset}> | ||
| {t('Reset')} | ||
| </Button> |
There was a problem hiding this comment.
should we add a tooltip informing the users why the button is disabled? It is pretty self-explanatory to me but imo it would be nice to have.
|
The 'Switch to Setup' button is overflowing the container on some viewports. Could we look into that? 
|
|
Thx for the detailed reviews! As the whole view is very much a WIP, I collected the non code feedback in a ticket and will revisit it once the rest of the UI is implemented. |
Bundle ReportChanges will increase total bundle size by 62.52kB (0.2%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #79341 +/- ##
==========================================
- Coverage 78.34% 78.31% -0.03%
==========================================
Files 7123 7136 +13
Lines 314824 315162 +338
Branches 51460 51506 +46
==========================================
+ Hits 246639 246818 +179
- Misses 61727 61880 +153
- Partials 6458 6464 +6 |
ArthurKnaus
deleted the
aknaus/feat/dynamic-sampling/settings-for-sample-rate
branch
* master: (288 commits) feat(metrics): Register MRI for spans/count_per_root_project (#78992) feat(dynamic-sampling): Settings for sample rate (#79341) Revert "feat(sentry-sdk): Enable HTTP2 transport" (#79391) fix(feedback): keep oldest date_added for duplicate user reports (#79387) chore(issue-stream): Remove tooltip for Unhandled (#79385) chore(autofix): Show banner if gen AI consent is given, even if no feature flag (#79362) chore(autofix+copilot) Allow autofix without FF if gen AI consent given (#79361) Fixes VULN-50 by enforcing option (#79384) perf(issues): improve adjacent_events query (#79365) feat(issues): Add anchor links back to issue sections (#79333) fix(issue-views): Make tab bar take up entire row (#79383) chore(issues): Add additional metrics for ownership matching (#79302) feat(insights): create screen rendering module (#79192) fix(issues): Avoid streamline issue layout rerenders (#79327) ref(performance): Add missing types to performance widgets (#79301) chore(issue-views): Add translation wrapper to aria label (#79320) chore(issue-stream): Reduce font size of title and message (#79378) feat(insights): update headers and breadcrumbs on frontend domain view (#78945) feat(insights): add view trends button to ai overview (#78611) ref(rr6): Remove unused param (#79379) ...
Add a form for setting the target sample rate. Closes https://github.com/getsentry/projects/issues/206
Add a form for setting the target sample rate. Closes getsentry/projects#206
Add a form for setting the target sample rate.
Screen.Recording.2024-10-18.at.09.50.27.mov
Closes https://github.com/getsentry/projects/issues/206