Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 "Camera View" is not Fabric compatible yet #1554

Closed
3 of 4 tasks
gokul1099 opened this issue Apr 10, 2023 · 20 comments · Fixed by #1466
Closed
3 of 4 tasks

🐛 "Camera View" is not Fabric compatible yet #1554

gokul1099 opened this issue Apr 10, 2023 · 20 comments · Fixed by #1466
Labels
🐛 bug Something isn't working

Comments

@gokul1099
Copy link

What were you trying to do?

I am using vision camera in rn 0.71.4. There I am, getting this error message. Is that possible to run the vision camera with fabric enabled?

Screenshot_1681098993

Reproduceable Code

I used the code from the demo application in this repo.

What happened instead?

Camera not opening because of this.

Relevant log output

No response

Device

Pixel 5(Android 11), Nokia 5.3(Android 12)

VisionCamera Version

2.15.4

Additional information

@gokul1099 gokul1099 added the 🐛 bug Something isn't working label Apr 10, 2023
@EazycTee
Copy link

EazycTee commented Jun 9, 2023

same issue... need help

@myselfuser1
Copy link

@robvigilleadingedje
Copy link

Same

@robvigilleadingedje
Copy link

Anyone find a solution to this? App requires new RN architecture.. Anyone know how to disable fabric but keep new architecture?

@luvnishCapgemini
Copy link

I am facing this same issue. Any workaround?

@ravindraguptacapgemini
Copy link

ravindraguptacapgemini commented Jun 27, 2023

@mrousavy please help suggest if the camera feature is not available yet for android? Getting same error "Camera View is not fabric compatible yet". Also if there is any workaround we can try to still run camera with fabric on both android and iOS. Thanks

@ace0109
Copy link

ace0109 commented Jul 8, 2023

Screenshot_1688809785
The same problem in the IOS is no problem

@ace0109
Copy link

ace0109 commented Jul 8, 2023

Screenshot_1688809785 The same problem in the IOS is no problem

newArchEnabled=false
I set this configuration to false first, because it is not compatible, when will it be compatible?

@mrousavy
Copy link
Owner

Just like all 5 of you discovered, VisionCamera is not yet fabric compatible.

I didn't work on making it Fabric compatible yet. If you want me to make it run on Fabric, either wait until I have the free time to do so, or pay me to do it: sponsor me on GitHub :)

@DominikHinc
Copy link

Hey,
I have prepared an initial support for fabric: #1684

@keremkurtulus
Copy link

keremkurtulus commented Sep 2, 2023

I overcame the issue with the help of this discussion article.
reactwg/react-native-new-architecture#135

It may not be an absolute fix but it doesn't hurt to try. This approach could work until this library supports for fabric.

I created react-native.config.js file and updated it like here; if you want to know why I use this config file find the discussion article above.

module.exports = {
  project: {
    android: {
      unstable_reactLegacyComponentNames: ['CameraView'],
    },
    ios: {
      unstable_reactLegacyComponentNames: ['CameraView'],
    },
  },
};

@ravindraguptacapgemini
Copy link

ravindraguptacapgemini commented Nov 16, 2023

module.exports = {
project: {
android: {
unstable_reactLegacyComponentNames: ['CameraView'],
},
ios: {
unstable_reactLegacyComponentNames: ['CameraView'],
},
},
};

@mrousavy Somehow I am able to build the library with this inter-op layer change with Fabric on React Native 0.72.6, but still I see few issues with Events, please check the screenshot
MicrosoftTeams-image

@turkergercik
Copy link

module.exports = {
project: {
android: {
unstable_reactLegacyComponentNames: ['CameraView'],
},
ios: {
unstable_reactLegacyComponentNames: ['CameraView'],
},
},
};

@mrousavy Somehow I am able to build the library with this inter-op layer change with Fabric on React Native 0.72.6, but still I see few issues with Events, please check the screenshot MicrosoftTeams-image

same for me

@fahadhaque007
Copy link

Any one manage to fix this issue?

@BaseMax
Copy link

BaseMax commented Jan 19, 2024

Same issue. Any updates?

image

@mrousavy
Copy link
Owner

#1554 (comment)

@luicfrr
Copy link
Contributor

luicfrr commented Jan 26, 2024

also waiting for a fix

@felansu
Copy link

felansu commented Feb 1, 2024

+1

@farwayer
Copy link
Contributor

@ravindraguptacapgemini @turkergercik
#2569

@XilinJia
Copy link

no solution for about a year?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.