Conversation
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
exec-serveralready hasFileSystemSandboxContext::from_permission_profile_with_cwd(...), and the file-system handler test was only usingSandboxPolicyto describe the two no-platform-sandbox cases. Keeping that test on the legacy enum adds noise to the remaining migration audit without exercising any legacy-specific behavior.What Changed
SandboxPolicy::DangerFullAccesswithPermissionProfile::Disabledin the no-platform-sandbox handler test.SandboxPolicy::ExternalSandboxwithPermissionProfile::Externalfor the external enforcement case.FileSystemSandboxContext::from_permission_profile_with_cwd(...), which is the canonical path for the new permissions model.SandboxPolicyimport fromexec-server/src/server/file_system_handler.rs.Verification
cargo test -p codex-exec-server no_platform_sandbox_policies_do_not_require_configured_sandbox_helperStack created with Sapling. Best reviewed with ReviewStack.