Conversation
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The full-buffer exec capture test only needs an unsandboxed/disabled permission profile. It previously constructed
SandboxPolicy::DangerFullAccesssolely to convert it toPermissionProfile::Disabled, which kept an unnecessary dependency on the legacy abstraction.What Changed
process_exec_tool_call_preserves_full_buffer_capture_policywithPermissionProfile::Disabled.SandboxPolicyuses inexec_tests.rsintact because they exercise Windows sandbox compatibility paths that still take legacy policy input.Verification
cargo test -p codex-core process_exec_tool_call_preserves_full_buffer_capture_policy -- --nocapturejust fmtjust fix -p codex-coreStack created with Sapling. Best reviewed with ReviewStack.