Skip to content

tests: copy plugin stdio server before launch#20373

Open
bolinfest wants to merge 1 commit intomainfrom
pr20373
Open

tests: copy plugin stdio server before launch#20373
bolinfest wants to merge 1 commit intomainfrom
pr20373

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Apr 30, 2026

Why

The Linux Bazel build for the permission-profile stack exposed a flaky/plugin-test-specific failure where suite::plugins::plugin_mcp_tools_are_listed resolved the test_stdio_server runfiles path successfully, but the plugin MCP subprocess later failed to spawn it with No such file or directory.

The plugin tests do not need to exercise Bazel runfiles path execution. They only need a stable stdio MCP server binary to validate that plugin-provided MCP tools are discovered and listed.

What Changed

  • Copies the resolved test_stdio_server binary into the test temp home before writing the plugin .mcp.json config.
  • Points plugin MCP startup at the copied executable so the child process launches from a stable local path rather than a runfiles path.
  • Keeps the existing local Cargo behavior of skipping these tests when test_stdio_server is not available.

Verification

  • cargo test -p codex-core plugin_mcp_tools_are_listed -- --nocapture

Stack created with Sapling. Best reviewed with ReviewStack.

@bolinfest bolinfest requested a review from a team as a code owner April 30, 2026 09:37
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant