Conversation
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Several session tests were still setting up runtime scenarios through
SandboxPolicy, even though the behavior under test is now driven byPermissionProfile: managed network proxy exposure, permission-profile updates, and split filesystem policy persistence. That made the tests noisier and kept exercising legacy conversion paths unnecessarily.What Changed
Permissions::set_permission_profileforPermissionProfile::DisabledandPermissionProfile::workspace_write().permission_profileoverride instead of a legacy sandbox override.PermissionProfile/runtime filesystem policies.TurnContext::file_system_sandbox_policy()when adding the unreadable glob used by turn-context serialization coverage.The remaining
SandboxPolicyreferences insession/tests.rsare left in tests that explicitly cover legacy projection or legacy rederivation behavior.Verification
cargo test -p codex-core managed_network_proxy -- --nocapturecargo test -p codex-core session_configuration_apply -- --nocapturecargo test -p codex-core turn_context_item_stores_split_file_system_sandbox_policy_when_different -- --nocapturejust fix -p codex-coreStack created with Sapling. Best reviewed with ReviewStack.