Conversation
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The analytics tests only need app-server response fixtures, but those fixtures still named the app-server
SandboxPolicyenum directly. That is boundary compatibility baggage: the response still has a required legacysandboxfield, but the fixture intent is that the session is using disabled permissions.What Changed
SandboxPolicyimports from analytics tests.sandboxfixture value fromCorePermissionProfile::Disabledinstead of constructingDangerFullAccessdirectly.rg '\bSandboxPolicy\b' codex-rs/analytics/srcno longer matches anything.Verification
cargo test -p codex-analytics --no-runStack created with Sapling. Best reviewed with ReviewStack.