Skip to content

sandboxing: exercise seatbelt with runtime policies#20424

Open
bolinfest wants to merge 1 commit intopr20423from
pr20424
Open

sandboxing: exercise seatbelt with runtime policies#20424
bolinfest wants to merge 1 commit intopr20423from
pr20424

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Apr 30, 2026

Summary

  • removes the test-only Seatbelt helpers that accepted legacy SandboxPolicy
  • updates macOS Seatbelt tests to pass FileSystemSandboxPolicy and NetworkSandboxPolicy directly
  • leaves the explicit legacy compatibility projection isolated in sandboxing::manager

Review Notes

  • rg '\bSandboxPolicy\b' codex-rs/sandboxing/src now only finds the compatibility helper in manager.rs; seatbelt.rs and seatbelt_tests.rs are free of legacy policy references.
  • The behavior covered by the tests is intended to stay the same: read-only, workspace-write, network proxy, unix-socket, and metadata carveout cases now construct the runtime policies they are validating instead of round-tripping through legacy policy shape.

Verification

  • cd codex-rs && just fmt
  • cd codex-rs && cargo test -p codex-sandboxing seatbelt::tests
  • cd codex-rs && just fix -p codex-sandboxing

Stack created with Sapling. Best reviewed with ReviewStack.

@bolinfest bolinfest requested a review from a team as a code owner April 30, 2026 13:34
@bolinfest bolinfest changed the base branch from main to pr20423 April 30, 2026 13:34
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant