Conversation
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This stack is migrating test and support code away from the legacy
SandboxPolicyturn override path. The app-server test client still constructed legacy sandbox payloads when exercising approval flows, which kept one more non-production caller tied tosandboxPolicyeven though v2 turn requests now support selecting permission profiles directly.Using named profiles in this harness keeps the manual/debug flows aligned with the app-server API direction: callers choose a profile such as
:read-onlyor:danger-no-sandboxinstead of synthesizing a legacy policy and asking the server to bridge it.What Changed
SandboxPolicyimports and fields incodex-rs/app-server-test-clientwithPermissionProfileSelectionParams.:read-onlythroughTurnStartParams.permissions.:danger-no-sandboxthroughTurnStartParams.permissions.Verification
cargo test -p codex-app-server-test-clientStack created with Sapling. Best reviewed with ReviewStack.