Skip to content

app-server-test-client: select permission profiles by name#20397

Open
bolinfest wants to merge 1 commit intopr20396from
pr20397
Open

app-server-test-client: select permission profiles by name#20397
bolinfest wants to merge 1 commit intopr20396from
pr20397

Conversation

@bolinfest
Copy link
Copy Markdown
Collaborator

@bolinfest bolinfest commented Apr 30, 2026

Why

This stack is migrating test and support code away from the legacy SandboxPolicy turn override path. The app-server test client still constructed legacy sandbox payloads when exercising approval flows, which kept one more non-production caller tied to sandboxPolicy even though v2 turn requests now support selecting permission profiles directly.

Using named profiles in this harness keeps the manual/debug flows aligned with the app-server API direction: callers choose a profile such as :read-only or :danger-no-sandbox instead of synthesizing a legacy policy and asking the server to bridge it.

What Changed

  • Replaced SandboxPolicy imports and fields in codex-rs/app-server-test-client with PermissionProfileSelectionParams.
  • Added a small helper for selecting built-in profiles by id.
  • Updated approval-triggering flows to request :read-only through TurnStartParams.permissions.
  • Updated the elicitation flow that needs unrestricted execution to request :danger-no-sandbox through TurnStartParams.permissions.

Verification

  • cargo test -p codex-app-server-test-client

Stack created with Sapling. Best reviewed with ReviewStack.

@bolinfest bolinfest requested a review from a team as a code owner April 30, 2026 10:53
@bolinfest bolinfest changed the base branch from main to pr20396 April 30, 2026 10:53
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant