Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only claim "package:" URLs are unsupported on Node #637

Merged
merged 4 commits into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@nex3
Copy link
Contributor

commented Apr 3, 2019

Closes #630

@nex3 nex3 requested a review from jathak Apr 3, 2019

@jathak

This comment has been minimized.

Copy link
Member

commented Apr 3, 2019

Looks like lib/src/visitor/evaluate.dart needs to be updated

nex3 added some commits Apr 3, 2019

@nex3

This comment has been minimized.

Copy link
Contributor Author

commented Apr 3, 2019

Looks like lib/src/visitor/evaluate.dart needs to be updated

Done.

@jathak

jathak approved these changes Apr 4, 2019

@nex3 nex3 merged commit 495c6f3 into master Apr 4, 2019

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nex3 nex3 deleted the package-url-error branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.