Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge and enable feature.use 馃帀 #835

Merged
merged 27 commits into from Oct 1, 2019
Merged

Merge and enable feature.use 馃帀 #835

merged 27 commits into from Oct 1, 2019

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Oct 1, 2019

nex3 added 26 commits June 26, 2019 15:04
Merge master into feature.use
Merge master into feature.use
Merge origin/master into feature.use
Merge master into feature.use
Merge master into feature.use
Merge master into feature.use
We had been using null to represent an empty configuration, but that
caused problems when an empty map snuck its way in as well. Now we
always use maps, with a const empty map for the common case.

See sass/sass#2744
@nex3 nex3 requested a review from nshahan October 1, 2019 21:56
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see this day come, congrats!

I left two comments.

migrate your stylesheets to the new module system!

[migrator blog]: https://sass-lang.com/blog/7858341-the-module-system-is-launched
[Sass migrator]: https://sass-lang.com/documentation/cli/migrator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to warn you that the link for the migrator isn't live yet.

dart_test.yaml Outdated
# Indicates tests that use the new module system, and so should only run on
# the `feature.use` branch.
module-system:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, deleted.

@nex3 nex3 merged commit b3cd44f into master Oct 1, 2019
@nex3 nex3 deleted the merge-use branch October 1, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the new module system
2 participants