Conversation
…t-file Remove unnecessary test file
* Fix unexpected borders in Table as `Table sx={{...}}` was overwriting the `sx` defined inside `Table`.
* Clean up
- Select only classes below `&` prevent styling from "bleeding" out of the component and into other components with the same class names.
…2.1.1 Update release notes to v2.1.1
# Conflicts: # CHANGELOG.md
* Toggle Normalized button in confusion matrix * % removed for not normalize * added changelog * read normalized from API rsponse * added toggle closer to plot * organized and clean up backend changes * backend test cases and added param to modules * name changes on the title description of API * name change and added default normalized value * test code clean up * Reorder query state fields alphabetically * Fix loosing normalized state when clicking top words * Fix non-normalized matrix having all numbers white * Do one check to `normalized` instead of two * Use query parameter as default value for `normalized` which is our best guess of what the `normalized` state will be. Co-authored-by: joseph.marinier <joseph.marinier@servicenow.com>
* Clean up * Offer hiding columns - Hide filter options (with handy boolean attribute) - Hide sort options since they are already available via the sorting button * Have columns flex to accommodate hiding columns. Also taking this opportunity to adjust the widths to new outcome names. * Show columns separator in headers to avoid ambiguity with which column the menu button belongs to. * Refine sorting - Show the initial sort - Disable `sortingOrder=null` as it is redundant with sorting by `utteranceCount` `desc` * Set `maxWidth` so that columns stop getting wider going under 6 columns.
…ormation in debug mode (#141)
* Fix typo in breadcrumbs * Clean up * Move confidence threshold out of `/dataset_info` and into `/bins` and `/utterances`. The idea is to remove pipeline-specific info from `/dataset_info`.
* Use `Generic`s for `PerFilterModules` * Split `ValuePerFilter` into `ValuePerDatasetFilter` and `ValuePerPipelineFilter` so that no field has to be `Optional` / `nullable`. * Generalize smart tags to strings to support dynamic smart tags in the future. * Fix tooltips preventing moving cursor down as cursor was going over the tooltip and keeping it popped. Co-authored-by: fr.branchaud-charron <fr.branchaud-charron@servicenow.com>
* Add F1 to default config. * Use outcomes' icons as headers of the Performance Overview table instead of the outcomes' full names. * Fix table "overall" row not on top at initial load, by controlling the sort model instead of trying to keep a reference to it (and setting the initial state). Co-authored-by: fr.branchaud-charron <fr.branchaud-charron@servicenow.com>
* Initial work on displaying descriptions
* rebased dev
* final code check
* added unit test cases and set default export
* Latest changes after design feedback
* resolved conflicts by rebase
* alignment fix for i icon
* added changelog
* Applied review comments
* review comments on utterance details page
* review comments on utterance details page
* Do the same in `DatasetDistribution`
* Reorder imports alphabetically
* Revert unnecessary changes
* Adjust plot right labels placement
by wrapping it inside a `<Box height={0}` to avoid hardcoding any non-zero vertical dimension (like `marginTop: -1`, `marginY: -4px` and `lineHeight: 1`).
* InsertLink to Link Icon
* Polish tests
Co-authored-by: joseph.marinier <joseph.marinier@servicenow.com>
* Regenerate frontend types * Add pipeline comparison smart tag family with `pipeline_disagreement` and `incorrect_for_all_pipelines` smart tags * Test that all smart tags have a family
* Final changes of visual bars * added a reusable module * Fixed alignment of value * some rework on visualbar width * name change to appropriate word * code cleanup and added changelog * added valuegetter back and some comments applied * modified the hardcoded color to theme in similarity column * some review changes added * some review changes added * name changed to appropriate word * some css review comments * removed unused import * CSS to align content to end * grid css work for width * text align to right considering small details * Change model-free distribution bars to `primary.main` color instead of the new very light `primary.light` color. * Revert bars in similar utterances to add it later with careful design * Tweak columns widths * Type `VisualBar["color"]` as `BoxProps["bgcolor"]` to avoiding the need for `useTheme`. Also remove `visualBarPercentage()` to make definitions more straightforward and avoid some typing. * Use flex instead of grid Co-authored-by: joseph.marinier <joseph.marinier@servicenow.com>
* Dashboard - Fix sorting numbers as strings * One-line descriptions - Shorten behavioral testing description and remove duplication - Add description to Post-processing Analysis page * Utterances table - Make proposed action selector wider in footer and narrower in column, making everything fit on a MacBook Pro 17. - The width of the selector in the table column is no longer hardcoded thanks to the `fullWidth` prop. The width in the table footer still needs to be fixed though, so I set it to the longest option "augment_with_similar".
* Add smart tag family icons * Incorporate changes from last release * Add release notes and change version * Update screenshots and change slightly wording of some one-liner * Revert change. Will be tackled in another PR. * Revert "Add smart tag family icons" This reverts commit 0558e7e. * Add smart tag family icons * Apply suggestions from code review Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com> * Tweak smart tag family icon sizes * Update CITATION.cff Co-authored-by: joseph.marinier <joseph.marinier@servicenow.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge
it.
ran
pre-commit run --all-filesat the end.Run
cd webapp && yarn typeswhile the back-end is running.our users.
READMEfiles and our wiki for any big design decisions, if relevant.