fix(android-sample): let a guest cart take the shop market - #570
Draft
kieran-osgood-shopify wants to merge 1 commit into
Draft
fix(android-sample): let a guest cart take the shop market#570kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-customer-account
branch
from
August 4, 2026 17:04
6f86347 to
7a16bc3
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/android-guest-cart-market
branch
from
August 4, 2026 17:04
70d84ed to
4ac9954
Compare
This was referenced Aug 4, 2026
Contributor
Author
11 tasks
The Android sample gave a guest cart a Canadian buyer identity. A country on the buyer identity picks the market, and the market decides the currency, the address form and its labels, so the Kotlin checkout rendered a Canadian form and totalled in CAD. The Swift and React Native samples send no buyer identity for a guest, so this one now sends none either. This is flake B4: the shared E2E fixture is a United States address, and checkout-guest failed on Kotlin Android while React Native Android passed the same test. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Assisted-By: devx/5b4b8d5b-690a-4389-841e-039723ade1da
kieran-osgood-shopify
changed the base branch from
kieran-osgood/e2e-checkout-customer-account
to
graphite-base/570
August 5, 2026 09:22
This was referenced Aug 5, 2026
kieran-osgood-shopify
force-pushed
the
graphite-base/570
branch
from
August 5, 2026 09:53
7a16bc3 to
d854029
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/android-guest-cart-market
branch
from
August 5, 2026 09:53
4ac9954 to
6643cfb
Compare
kieran-osgood-shopify
changed the base branch from
graphite-base/570
to
kieran-osgood/e2e-checkout-customer-account
August 5, 2026 09:53
kieran-osgood-shopify
changed the base branch from
kieran-osgood/e2e-checkout-customer-account
to
graphite-base/570
August 5, 2026 11:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What
The Android sample gives a guest cart a hardcoded Canadian buyer identity. This removes it, so
a guest cart takes the market of the shop, like the Swift and React Native samples already do.
Why
A country on the buyer identity picks the market. The market decides the currency, the address
form, and the labels on its fields. So the Android sample rendered a Canadian checkout, while
the shared E2E fixture types a United States address.
That is fault B4 in
e2e/FLAKES.md:checkout-guestfailed on Kotlin Android atScrolling DOWN until "Country/Region" is visible, and passed on React Native Android.Evidence from the two BrowserStack Maestro logs:
Country/RegionnodeBounds(x=34, y=336, width=1010, height=0), unchanged over 6 swipesBounds(x=34, y=1202, width=1010, height=134)React Native also skipped the country picker step, because
United Stateswas alreadyselected. The Kotlin failure screenshot shows a total in CAD.
The three samples now agree:
Storefront.CartInput(lines: lines){}Optional.AbsentScope
This changes the sample app only. It does not touch the published
com.shopify:checkout-kitlibrary, so it has no consumer impact.
The demo buyer identity and the signed-in customer paths are unchanged. Only the guest path
loses the country.
Test
Written first, and confirmed red before the fix:
dev android testdev android lint🤖 Generated with Claude Code