feat(e2e): add an E2EController to each sample app - #555
Draft
kieran-osgood-shopify wants to merge 1 commit into
Draft
feat(e2e): add an E2EController to each sample app#555kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
11 tasks
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 31, 2026
tiagocandido
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 3, 2026 12:12
fd87aa1 to
278ce30
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-controller
branch
2 times, most recently
from
August 3, 2026 14:42
c5d3696 to
fe4b7c7
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 3, 2026 14:42
278ce30 to
66ee89d
Compare
This was referenced Aug 3, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 4, 2026 17:04
66ee89d to
7c28f96
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 4, 2026 17:04
fe4b7c7 to
5034ed1
Compare
This was referenced Aug 4, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 5, 2026 11:06
7c28f96 to
a3717e8
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 5, 2026 11:06
5034ed1 to
71a2d87
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 5, 2026 11:35
a3717e8 to
9c0c058
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 5, 2026 11:35
71a2d87 to
252a4a3
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 5, 2026 11:45
9c0c058 to
babcf9e
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 5, 2026 11:45
252a4a3 to
4d1cf32
Compare
Every E2E command now enters one controller per sample. The controller composes existing primitives only, so E2E logic stays out of the cart, storefront and account code that merchants read as integration guidance. An injectable E2ECommandTarget makes the decision order testable without a network or a UI. Eight tests per platform assert an ordered list of calls, which pins the one rule that matters: selecting a buyer identity mode resets the cart, so it must run before seeding. Production code touches E2E in one named line per call site: SceneDelegate.scene(_:openURLContexts:), MainActivity, and Routes. Android needs two touch points, not one. Navigation state lives in Compose, so E2ENavigation plus one E2ENavigationEffect line lets the app self-navigate to the cart. The Maestro flow stops the app before opening the link, so a cold start delivers the intent to onCreate; both entry points route through E2EControlLinkHandler. The manifest gains a VIEW filter and singleTask. Swift gains a second URL scheme, without which openURLContexts never fires. Cart markers now match the React Native precedent on all four targets: the button carries checkout-button, the label carries cart-checkout-ready. signIn reports that it is not implemented yet. A later PR adds it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 5, 2026 12:33
4d1cf32 to
1ca5d85
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 5, 2026 12:33
babcf9e to
2c394fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.