feat(e2e): add the hardcoded buyer identity order test on all four targets - #560
Draft
kieran-osgood-shopify wants to merge 1 commit into
Conversation
This was referenced Jul 31, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 31, 2026
tiagocandido
force-pushed
the
kieran-osgood/e2e-present-and-close-checkout
branch
from
August 3, 2026 12:12
4783464 to
528c5d6
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
branch
from
August 3, 2026 12:12
4538a43 to
ec85833
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-present-and-close-checkout
branch
from
August 3, 2026 14:42
528c5d6 to
cd3c10f
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
branch
from
August 3, 2026 14:42
ec85833 to
200f651
Compare
This was referenced Aug 3, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-present-and-close-checkout
branch
from
August 4, 2026 17:04
cd3c10f to
10a2582
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
branch
from
August 4, 2026 17:04
200f651 to
06ebb2e
Compare
This was referenced Aug 4, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-present-and-close-checkout
branch
from
August 5, 2026 11:06
10a2582 to
f9b982d
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
branch
2 times, most recently
from
August 5, 2026 11:35
ccb91e5 to
40a971a
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-present-and-close-checkout
branch
from
August 5, 2026 11:35
f9b982d to
01fad00
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
branch
from
August 5, 2026 11:45
40a971a to
ef7f86e
Compare
…rgets Row 3 of the test rollout. The cart carries the contact details and the delivery address, so checkout asks only for payment. That makes this the shortest real order, and the first test to look at when checkout breaks. The test moves from tests/react-native/ to tests/shared/, so Swift iOS, Kotlin Android, React Native iOS and React Native Android all run it. The matrix drops the `full` exclude entry that kept the ordering tests off the native rows. Android supplied only email, phone and country in its cart, while Swift and React Native both supplied a delivery address. Checkout therefore showed an empty Delivery form on Android only. CartInput.delivery now carries a pre-selected one-time address there too, which matches Swift. The address fields come from the same .env values the other samples read. Two Maestro details drive the flow changes: - A `visibilityPercentage` below 100 normalizes to zero, so `scrollUntilVisible` stops without scrolling. `centerElement: true` replaces it. A tap that lands on the keyboard does nothing, and Maestro still reports it as completed. - Android `hideKeyboard` issues a Back press when no keyboard is up, which closes the checkout sheet. dismiss-active-field.yaml therefore only ever follows an inputText. Verified green on all four targets, plus dev check, the Ruby suite, the Swift package and sample targets, the Android library and sample tests, the React Native JS and iOS tests, web and protocol. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
branch
from
August 5, 2026 12:33
ef7f86e to
4927554
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-present-and-close-checkout
branch
from
August 5, 2026 12:33
53cb731 to
10ed082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.