feat(e2e): add the cart-from-control-link test on all four targets - #558
Draft
kieran-osgood-shopify wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 31, 2026
This was referenced Jul 31, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 31, 2026
tiagocandido
force-pushed
the
kieran-osgood/e2e-matrix-tags
branch
from
August 3, 2026 12:12
8947b3c to
05b95c0
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-cart-from-control-link
branch
2 times, most recently
from
August 3, 2026 14:42
893721f to
ecc30cc
Compare
This was referenced Aug 3, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-cart-from-control-link
branch
from
August 4, 2026 17:04
ecc30cc to
f3d5bf1
Compare
This was referenced Aug 4, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-matrix-tags
branch
from
August 5, 2026 11:06
275339e to
69fc2dd
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-cart-from-control-link
branch
from
August 5, 2026 11:06
f3d5bf1 to
3cb7142
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-matrix-tags
branch
from
August 5, 2026 11:35
69fc2dd to
f2eaf34
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-cart-from-control-link
branch
2 times, most recently
from
August 5, 2026 11:45
4462b86 to
67e6765
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-matrix-tags
branch
from
August 5, 2026 11:45
f2eaf34 to
1d37a2f
Compare
The first shared test that runs on Swift iOS, Kotlin Android, React Native iOS and React Native Android. It drives the `cart` control link and asserts the `cart-checkout-ready` marker, which appears only after the app parsed the link, resolved a variant, created a cart, added the line, and navigated. Adds `e2e/scripts/run_maestro`, the single Maestro invocation every local runner calls, plus `dev swift e2e` and `dev android e2e` so all four targets run locally. Verified locally: React Native iOS 23s, Swift iOS 23s, Kotlin Android 15s, React Native Android 19s. Three deliberate deviations from the plan: - `E2E_CONTROL_LINK` is derived as `<app_id>://e2e` rather than configured per application. The scheme equals the app id on all four targets, so a second copy would drift from `app_id`. - Maestro runs the workspace root, not `tests`. Maestro resolves the `flows:` glob in `config.yaml` relative to the path on the command line, so `tests` would look for `tests/tests/**` and match nothing. `tests_path` remains for tag discovery. - The flow no longer stops the app before the link. `SceneDelegate` discards a cold-start URL and Android would need launch-intent handling, so one flow line replaces native work on two platforms. The account journey needs a running app anyway. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-cart-from-control-link
branch
from
August 5, 2026 12:33
67e6765 to
4bc352b
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-matrix-tags
branch
from
August 5, 2026 12:33
1d37a2f to
03493a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.