Add the E2E control link parser to all four sample apps - #554
Draft
kieran-osgood-shopify wants to merge 1 commit into
Draft
Add the E2E control link parser to all four sample apps#554kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 31, 2026
tiagocandido
force-pushed
the
e2e-sample-test-seams
branch
from
August 3, 2026 12:12
1abe472 to
71f2515
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 3, 2026 12:12
fd87aa1 to
278ce30
Compare
tiagocandido
force-pushed
the
e2e-sample-test-seams
branch
from
August 3, 2026 14:42
71f2515 to
fc857ab
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 3, 2026 14:42
278ce30 to
66ee89d
Compare
This was referenced Aug 3, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 4, 2026 17:04
66ee89d to
7c28f96
Compare
kieran-osgood-shopify
force-pushed
the
e2e-sample-test-seams
branch
from
August 4, 2026 17:04
fc857ab to
b40215e
Compare
This was referenced Aug 4, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 5, 2026 11:06
7c28f96 to
a3717e8
Compare
kieran-osgood-shopify
force-pushed
the
e2e-sample-test-seams
branch
2 times, most recently
from
August 5, 2026 11:35
6584a19 to
eb70a16
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-control-link
branch
2 times, most recently
from
August 5, 2026 11:45
9c0c058 to
babcf9e
Compare
kieran-osgood-shopify
force-pushed
the
e2e-sample-test-seams
branch
from
August 5, 2026 11:45
eb70a16 to
ad8bafd
Compare
The E2E suite drives four apps: Swift iOS, Kotlin Android, React Native iOS and React Native Android. Only React Native could read a deep link, and only for a cart. Widen the contract to <scheme>://e2e/<command> with the commands reset, cart and signIn, and port the parser to Swift and Kotlin so one Maestro flow drives every app. Every platform rewrites the scheme to https before parsing. Neither Foundation URLComponents nor java.net.URI accepts the underscores in the Android application id, and the React Native URL polyfill parses a host only for http(s). A test per platform pins that behaviour with both app schemes. The parser stays pure and keeps three outcomes: nil when the link belongs to another feature, a parsed command, or an error that names the bad parameter. A parameter that is present must carry a valid value. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
e2e-sample-test-seams
branch
from
August 5, 2026 12:33
ad8bafd to
992ffc8
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 5, 2026 12:33
babcf9e to
2c394fc
Compare
kieran-osgood-shopify
changed the base branch from
e2e-sample-test-seams
to
graphite-base/554
August 5, 2026 14:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.