feat(e2e): select tests by Maestro tag instead of scenario flags - #556
Draft
kieran-osgood-shopify wants to merge 1 commit into
Draft
feat(e2e): select tests by Maestro tag instead of scenario flags#556kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
This was referenced Jul 31, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 31, 2026
tiagocandido
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 3, 2026 12:12
efa7be2 to
c5d3696
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-maestro-tags
branch
from
August 3, 2026 12:12
9fb7cc3 to
f6b1c17
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 3, 2026 14:42
c5d3696 to
fe4b7c7
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-maestro-tags
branch
from
August 3, 2026 14:42
f6b1c17 to
7fe2c6b
Compare
This was referenced Aug 3, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-maestro-tags
branch
from
August 4, 2026 17:04
7fe2c6b to
c92b49f
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 4, 2026 17:04
fe4b7c7 to
5034ed1
Compare
This was referenced Aug 4, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 5, 2026 11:06
5034ed1 to
71a2d87
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-maestro-tags
branch
2 times, most recently
from
August 5, 2026 11:35
06f0462 to
9df32cf
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 5, 2026 11:45
252a4a3 to
4d1cf32
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-maestro-tags
branch
from
August 5, 2026 11:45
9df32cf to
2d277f3
Compare
The two scenario flags only picked a file, and each test already carries its
scenario in its own env block. Tags scale to the tests Phase 6 adds without a
new flag per test.
Every test now declares tags from one taxonomy: one journey (launch, cart,
checkout, account), one cost tier (smoke, full), plus optional quarantine
(flaky, wip) and platform capability (ios-only, android-only) tags.
maestro_test_tags_test.rb enforces all of it, and a platform tag must name the
capability that earns it, so nobody tags an unported test.
config.yaml excludes flaky and wip, so a quarantined test stays in the tree and
out of every run.
`dev rn e2e {ios|android}` now runs the whole tests folder and takes
--tags/--exclude-tags. Both match any listed tag, because that is how Maestro
filters. The runner also supplies E2E_APP_ID and E2E_READY_MARKER so the shared
launch smoke runs locally; a later commit unifies those names.
ci.yml gates flow edits on the ruby job, so editing a test reaches the
validator.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-maestro-tags
branch
from
August 5, 2026 12:33
2d277f3 to
7f3e78b
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 5, 2026 12:33
4d1cf32 to
1ca5d85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.