feat(e2e): add the present-and-close checkout test on all four targets - #559
Draft
kieran-osgood-shopify wants to merge 1 commit into
Conversation
This was referenced Jul 31, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 31, 2026
tiagocandido
force-pushed
the
kieran-osgood/e2e-cart-from-control-link
branch
from
August 3, 2026 12:12
8a529fd to
893721f
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-present-and-close-checkout
branch
from
August 3, 2026 12:12
4783464 to
528c5d6
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-cart-from-control-link
branch
from
August 3, 2026 14:42
893721f to
ecc30cc
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-present-and-close-checkout
branch
from
August 3, 2026 14:42
528c5d6 to
cd3c10f
Compare
This was referenced Aug 3, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-cart-from-control-link
branch
from
August 4, 2026 17:04
ecc30cc to
f3d5bf1
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-present-and-close-checkout
branch
from
August 4, 2026 17:04
cd3c10f to
10a2582
Compare
This was referenced Aug 4, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-present-and-close-checkout
branch
from
August 5, 2026 11:06
10a2582 to
f9b982d
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-cart-from-control-link
branch
2 times, most recently
from
August 5, 2026 11:35
3cb7142 to
4462b86
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-present-and-close-checkout
branch
from
August 5, 2026 11:35
f9b982d to
01fad00
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-cart-from-control-link
branch
from
August 5, 2026 11:45
4462b86 to
67e6765
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-present-and-close-checkout
branch
from
August 5, 2026 11:45
01fad00 to
53cb731
Compare
Second test of the rollout. It seeds a cart through the control link, presents checkout, closes it, and asserts the sheet is gone. Swift iOS, Kotlin Android, React Native iOS and React Native Android all run it. Assert on the close control, not on checkout copy: the React Native catalog sells a product called "Email", which the checkout field pattern matches, so copy-based assertions pass on the wrong screen. Extract flows/checkout/close.yaml so the close identifier, which differs by SDK version rather than by platform, has one home. The React Native order flow now calls it instead of carrying its own platform split. The four targets return to different screens after the sheet closes, so this test asserts dismissal only. The tests that place an order assert the cart. Add the checkout tag to the CI matrix and exclude full, because the remaining full tests place a real order and live under tests/react-native/. Pass the installed device to Maestro from both native runners. Maestro otherwise picks a device itself, and it can pick one the app is missing from. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-cart-from-control-link
branch
from
August 5, 2026 12:33
67e6765 to
4bc352b
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-present-and-close-checkout
branch
from
August 5, 2026 12:33
53cb731 to
10ed082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
How to test
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.