fix(tui): keep closed tabs closed across TUIs - #41401
Open
Narwhster wants to merge 1265 commits into
Open
Conversation
This reverts commit 7814568.
Co-authored-by: Aiden Cline <rekram1-node@users.noreply.github.com>
Co-authored-by: Aiden Cline <rekram1-node@users.noreply.github.com>
Co-authored-by: Aiden Cline <63023139+rekram1-node@users.noreply.github.com>
Co-authored-by: Kit Langton <7587245+kitlangton@users.noreply.github.com>
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #41394
Type of change
What does this PR do?
When two TUIs share tab storage, closing an inactive tab in one TUI caused the other TUI to reopen it when its storage state refreshed. This separates route-driven tab opening from storage-driven metadata updates, so a closed tab is not recreated unless the route actually changes. A regression test covers the cross-TUI case.
How did you verify your code works?
bun test test/context/session-tabs.test.tsx --timeout 30000Screenshots / recordings
Not applicable. This is a behavior-only TUI bug fix with no visual changes.
Checklist
If you do not follow this template your PR will be automatically rejected.