Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sebible v0.18.1 prow #18200

Closed
wants to merge 132 commits into from
Closed

Sebible v0.18.1 prow #18200

wants to merge 132 commits into from

Commits on Mar 2, 2019

  1. build: Bump version to 0.18.0 

    Update version after branching off

Tree-SHA512: 48f2c2ecfc485f0c864d2b1748ffb382df444abdc8387886bee1be5e49bbcaa6baf0a52544abb7189d762a3f33c82a794413511580e6154c0f82e5e58bea0b0f
    @laanwj
    laanwj committed Mar 2, 2019
    1
    Copy the full SHA
    742f7dd View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2019

  1. doc: Merge release notes fragments 

    - Merge release notes fragments into release-notes.md

- Remove downgrading notes (as I understand this pertains to `<0.15`,
  this doesn't warrant mentioning anymore)

Tree-SHA512: 839e30807651ff53efa713f707ba0744c6c6c9bcb2c9c8afc0e299c93f772cc9a0ef294ba7e15f7049280556404d9b2e96b74f28e456aa36130af05bc7cfe035
    @laanwj
    laanwj committed Mar 4, 2019
    1
    Copy the full SHA
    b702e37 View commit details
    Browse the repository at this point in the history

  2. Merge bitcoin#15524: [0.18] doc: Remove ppa from linux build instruct… 

    …ions

fa3148a doc: Remove ppa from linux build instructions (MarcoFalke)

Pull request description:

  Same commit hash as bitcoin#15518

Tree-SHA512: b6ab2f84ca8efc4e71604422b427793b8b17d8d50422177f4ce967421457eee8c2f1d1e0e4fa8cad05cf42ab4343a25e4ee0404cafee978456eefe0c72b11f2b
    @laanwj
    laanwj committed Mar 4, 2019
    1
    Copy the full SHA
    7630301 View commit details
    Browse the repository at this point in the history

  3. build: set RC1 

    Tree-SHA512: 26bd0cce9eaf906a921defd7e4abdbf1056f29c6327950d766753149dde19d6af39ee827f6e02ebfede488f5afb6b4048814061c45e611ffa43f8ef4598edcdb
    @laanwj
    laanwj committed Mar 4, 2019
    3
    Copy the full SHA
    6a178e5 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2019

  1. doc: Remove pr release notes file in wrong dir 

    Github-Pull: bitcoin#15527
Rebased-From: fad76e7
Tree-SHA512: 15b8af83029b095fbe9f7163e2b82247f590831165596b67ed9acae8c11715593c57702731cfe3320e3fa645137fd90314598d1bf91e81cea01889ecc6d05d3a
    @laanwj
    MarcoFalke authored and laanwj committed Mar 5, 2019
    1
    Copy the full SHA
    71ac4eb View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. Merge bitcoin#15552: 0.18: Granular invalidateblock and RewindBlockIndex 

    519b0bc Make last disconnected block BLOCK_FAILED_VALID, even when aborted (Pieter Wuille)
8d22041 Optimization: don't add txn back to mempool after 10 invalidates (Pieter Wuille)
9ce9c37 Prevent callback overruns in InvalidateBlock and RewindBlockIndex (Pieter Wuille)
9bb32eb Release cs_main during InvalidateBlock iterations (Pieter Wuille)
9b1ff5c Call InvalidateBlock without cs_main held (Pieter Wuille)
241b2c7 Make RewindBlockIndex interruptible (Pieter Wuille)
880ce7d Call RewindBlockIndex without cs_main held (Pieter Wuille)
436f7d7 Release cs_main during RewindBlockIndex operation (Pieter Wuille)
1d34287 Merge the disconnection and erasing loops in RewindBlockIndex (Pieter Wuille)
32b2696 Move erasure of non-active blocks to a separate loop in RewindBlockIndex (Pieter Wuille)
9d6dcc5 Abstract EraseBlockData out of RewindBlockIndex (Pieter Wuille)

Pull request description:

  Same repo and branch like  "Granular invalidateblock and RewindBlockIndex bitcoin#15402 ", can be merged as is.

  This saves us all the cherry-picks and review of the backport cherry-picks.

Tree-SHA512: 20c27c5f807c3d85e0072f9e2cdefad4ad7d329d6b26658a00844d5fcf0ed729059daf765e04e6382db2b5915117b15949cd4989d864917ab105c92e2e5e9986
    @laanwj
    laanwj committed Mar 7, 2019
    1
    Copy the full SHA
    0fd3632 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2019

  1. gitian: Improve error handling 

    Github-Pull: bitcoin#15549
Rebased-From: 32da92b
Tree-SHA512: c79455ed3aa0e529821ed30c5d36244dcc9fbf9154b63dfcce4789143d8a737f83ea2aaea8993748babc4cec45ae0e88449d2a6ddc90dcf62a39cf8d6a2ace2e
    @laanwj
    laanwj committed Mar 9, 2019
    1
    Copy the full SHA
    f810f14 View commit details
    Browse the repository at this point in the history

  2. [addrman] Improve tried table collision logging 

    Github-Pull: bitcoin#15486
Rebased-From: 4d83401
Tree-SHA512: c7843191c470d8b3298d4375632ddbcfd26358d21100bcbffa8d40498782f9dfef08cfb7b3c040525ef912b27ddd593322b60f8f21e16e2ae9bae66433ce807e
    @sdaftuar @laanwj
    sdaftuar authored and laanwj committed Mar 9, 2019
    1
    Copy the full SHA
    561b00a View commit details
    Browse the repository at this point in the history

  3. [net] feeler connections can be made to outbound peers in same netgroup 

    Fixes a bug where feelers could be stuck trying to resolve a collision in the
tried table that is to an address in the same netgroup as an existing outbound peer.

Thanks to Muoi Tran for the original bug report and detailed debug logs to track
this down.

Github-Pull: bitcoin#15486
Rebased-From: 4991e3c
Tree-SHA512: 2752c9909d55ff63b9143168033d0d3952effba7f911181919eb62291edf822ec54fffbb20e35b5c5f8cb1092d75c496665da00139dbebe5ce402cbea3ad87c5
    @sdaftuar @laanwj
    sdaftuar authored and laanwj committed Mar 9, 2019
    1
    Copy the full SHA
    487f0c3 View commit details
    Browse the repository at this point in the history

  4. [addrman] Ensure collisions eventually get resolved 

    After 40 minutes, time out a test-before-evict entry and just evict without
testing. Otherwise, if we were unable to test an entry for some reason, we
might break using feelers altogether.

Github-Pull: bitcoin#15486
Rebased-From: f71fdda
Tree-SHA512: 66c61a9f030b1666e98e4fe66dd6cfc5f1d03b2a1ec01567b195903db6e4412ac778f4464ee9ef35ae6faa1ab7e4b18ef7ecb9a7ced29e6494046990aebf7b76
    @sdaftuar @laanwj
    sdaftuar authored and laanwj committed Mar 9, 2019
    1
    Copy the full SHA
    333be7a View commit details
    Browse the repository at this point in the history

  5. [addrman] Improve collision logging and address nits 

    Github-Pull: bitcoin#15486
Rebased-From: 20e6ea2
Tree-SHA512: 73b37a98cf4d9ede1d39c30d178d63a5a6865dba6cb7a9f33bd1e03445acb708b3007c7cde991b5de96a407262adda23279fe7a1d2ed31b0b5a33b2e97aaba9b
    @sdaftuar @laanwj
    sdaftuar authored and laanwj committed Mar 9, 2019
    Copy the full SHA
    b80dedb View commit details
    Browse the repository at this point in the history

  6. qt: periodic translations update 

    Tree-SHA512: a2c5818dd2fa261b86a177e846e5a58062f1ea3adf3d4fef5ac6f4a503e7f9f143189a0068847f405cc68f9900f983db5c3ab9799a4e29dd41ced09542f57175
    @laanwj
    laanwj committed Mar 9, 2019
    1
    Copy the full SHA
    936ef73 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2019

  1. build: use full version string in setup.exe 

    Github-Pull: bitcoin#15548
Rebased-From: fa55104
Tree-SHA512: 195d9d459431ae879a27e26d01962f020ddbbf648da26e52121c4fa7eb3438330f1ce34de431757e5079bf248f7129539e1d1a83c9c795ab57dc8c51545384bb
    @laanwj
    MarcoFalke authored and laanwj committed Mar 12, 2019
    1
    Copy the full SHA
    021a9ad View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. doc: correct analysepsbt rpc doc 

    Github-Pull: bitcoin#15559
Rebased-From: a4d0fd0
Tree-SHA512: 43f985ccb1af22e416230b8f351396d1fa677ee4e60f6952962ed37e842f5746df8a58ae7c35d6a7518af4b5974ee753b17ec3578394122584ca10e9ed561268
    @fanquake @laanwj
    fanquake authored and laanwj committed Mar 13, 2019
    1
    Copy the full SHA
    20fd64f View commit details
    Browse the repository at this point in the history

  2. rpc: return a number for estimated_feerate in analyzepsbt 

    Github-Pull: bitcoin#15559
Rebased-From: 335931d
Tree-SHA512: ebe460e935e33fbbbe725db403654ee65c86a606401e8519e1180551e2ccd43661eb4ad20bf065f2c0c2a8026c3bb3bce796789f8d612e9e197ceb8d541a63a9
    @fanquake @laanwj
    fanquake authored and laanwj committed Mar 13, 2019
    1
    Copy the full SHA
    2edd0c4 View commit details
    Browse the repository at this point in the history

  3. Fix overflow bug in analyzepsbt fee: CAmount instead of int 

    Github-Pull: bitcoin#15582
Rebased-From: c9963ae
Tree-SHA512: ed1dcfafb7015de5405112938b04c4009bec3349a8d4e8aca641598ccab31a34c7f16b5045670909fd2e795fc40640a79658ef6b1771e9f21abd0ca759b239b5
    @sipa @laanwj
    sipa authored and laanwj committed Mar 13, 2019
    1
    Copy the full SHA
    232ef63 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2019

  1. doc: Pre-rc2 translations update 

    Tree-SHA512: a494a9039555b24a7a4f4ecebc2a1b7c47bf8937b2ec583659e4443b49919e6ddd0e276c273ce2f89955f433de300ea0c36216e288309a7fac5b2e3d2534a604
    @laanwj
    laanwj committed Mar 14, 2019
    1
    Copy the full SHA
    a01925c View commit details
    Browse the repository at this point in the history

  2. wallet: Log and ignore errors in ListWalletDir and IsBerkeleyBtree 

    Github-Pull: bitcoin#15583
Rebased-From: 15c69b1
Tree-SHA512: edef7cafc5a2cb8d3355591a7742ef61454a5dedbb1dc22f6cc6bae42329d887f3f4a054f2aeedf31180051f50b6478d09e204066205699dabc0cb67b0ce4a96
    @promag @laanwj
    promag authored and laanwj committed Mar 14, 2019
    1
    Copy the full SHA
    ef27a06 View commit details
    Browse the repository at this point in the history

  3. build: bump to rc2 

    Tree-SHA512: 8ce284bd20cfeee8bfb9f7144c9a4239b460f83ac18df840b417b43b11e8028b649fb056c9266d01ac39a926a8f4e931d0dc3ee302d0c84f5fcb2c7d18126322
    @laanwj
    laanwj committed Mar 14, 2019
    1
    Copy the full SHA
    85f1755 View commit details
    Browse the repository at this point in the history

  4. doc: Update manpages 

    Tree-SHA512: 97a6d7193da6f9d84e35e2511d949b08be990e035ffb38a149bf45df085ea41f4c84953ddd7a38b0165574f7168419fc2bd3ad6351f5012d89cf884d055693e7
    @laanwj
    laanwj committed Mar 14, 2019
    1
    Copy the full SHA
    889af0e View commit details
    Browse the repository at this point in the history

  5. [p2p] Enable BIP 61 REJECT messages by default

    @jnewbery
    jnewbery committed Mar 14, 2019
    1
    Copy the full SHA
    da14d90 View commit details
    Browse the repository at this point in the history

  6. [docs] document BIP 61 deprecation

    @jnewbery
    jnewbery committed Mar 14, 2019
    1
    Copy the full SHA
    a756363 View commit details
    Browse the repository at this point in the history

  7. Merge bitcoin#15602: 0.18: [p2p] Enable reject messages by default 

    a756363 [docs] document BIP 61 deprecation (John Newbery)
da14d90 [p2p] Enable BIP 61 REJECT messages by default (John Newbery)

Pull request description:

  This PR reverts bitcoin#14054 following discussion on the bitcoin-dev mailing list.

  It also adds release notes to clearly document that the `enablebip61` option will be disabled by default in a future release before being removed entirely.

Tree-SHA512: 0c9162045a4fb95689a0cb2de19f98a83636c9a6fb7ffa6809773b593c6c00b14e0480683e4d1c48e9b7f90e89cf7c2dca18bff42f5d2da2a43c522039e9f1ee
    MarcoFalke committed Mar 14, 2019
    1
    Copy the full SHA
    d3a0382 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. Do not relay banned IP addresses 

    Github-Pull: bitcoin#15617
Rebased-From: 054d01d
Tree-SHA512: 2c47cf823cc51aee5a224513a0ca2fd1132f4c567d255ead661e88f009dc5d1db73da79b5e65a63b11b222e17292fdff9035a93cb2e53215d9bbb21a5bce7a41
    @sipa @laanwj
    sipa authored and laanwj committed Mar 20, 2019
    1
    Copy the full SHA
    238ef33 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. gui: Defer removeAndDeleteWallet when no modal widget is active

    @promag @jonasschnelli
    promag authored and jonasschnelli committed Mar 22, 2019
    Copy the full SHA
    98a24a2 View commit details
    Browse the repository at this point in the history

  2. Merge bitcoin#15641: Backport bitcoin#15614 to 0.18: gui: Defer remov… 

    …eAndDeleteWallet when no modal widget is active

98a24a2 gui: Defer removeAndDeleteWallet when no modal widget is active (João Barbosa)

Pull request description:

  0.18 Backport of bitcoin#15614

Tree-SHA512: 8f785705325364ecfa37045090f10ca615f457e279789b0ce0d61f2667f491bce9b44f5e5cdeeecf63d61356213d9a97a3578841295cc8480cf42e037c2decb2
    @laanwj
    laanwj committed Mar 22, 2019
    Copy the full SHA
    b022242 View commit details
    Browse the repository at this point in the history

  3. [rpc] Remove deprecated functionality message from validateaddress help 

    This functionality was removed in v0.18.
    @jnewbery
    jnewbery committed Mar 22, 2019
    Copy the full SHA
    be8b9c6 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2019

  1. Merge bitcoin#15647: [rpc] Remove deprecated functionality message fr… 

    …om validateaddress help

be8b9c6 [rpc] Remove deprecated functionality message from validateaddress help (John Newbery)

Pull request description:

  This functionality was removed in v0.18.

ACKs for commit be8b9c:
  MarcoFalke:
    utACK be8b9c6
  fanquake:
    utACK be8b9c6

Tree-SHA512: 7e30f1e56020aa3a59e736574075191155866788156d0d30eaf963c0a5015ad0de43787c6b73a765319f2dccec0117a2230a312d18ca3f9be3986ce3de4afdb3
    MarcoFalke committed Mar 23, 2019
    Copy the full SHA
    7eab2db View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2019

  1. qt: Translations update pre-rc3 

    Tree-SHA512: 52b66903e169fc3f53f8e4eccb0f765df9a6fbc149ba98fbe7f8b8e7f03e8196ebef8c19ed7412f6d09ddfa4b82e38aa357e1fca6942b0d1d7fe89ea66053556
    @laanwj
    laanwj committed Mar 28, 2019
    Copy the full SHA
    09a05e8 View commit details
    Browse the repository at this point in the history

  2. build: Bump to rc3 

    Tree-SHA512: 0d7a73946d75ac79df65dc6fb5c885353729a3401d985e2d452bf9e5964be7e169ae2cab481cba5307f5d3480d307e1c9e198090f2ede2c9c020543947d44db4
    @laanwj
    laanwj committed Mar 28, 2019
    Copy the full SHA
    f14a0aa View commit details
    Browse the repository at this point in the history

  3. release: Update the Windows Codesigning certificate 

    Github-Pull: bitcoin#15682
Rebased-From: 43ae1e9
Tree-SHA512: 10b7ef7f58b9ded4d6a446f7a03173de6d2ce5d31a09945308b32e250c9ee7550ad2d6ae3aecb0447731a98f2ddfd62a0dcfa61106b6cc1da78d9985407ecf47
    @theuni @laanwj
    theuni authored and laanwj committed Mar 28, 2019
    Copy the full SHA
    dcd96b8 View commit details
    Browse the repository at this point in the history

  4. doc: Update manpages for changes since rc2 

    Tree-SHA512: f42885f9b866b1172622c4ff2003b1abe5d26e2bfc060b141475761ddfb69b89c99ed5e9d15a23cf4581e77588f77eaecbbea5b7621c1ca22e7a2da6a788e746
    @laanwj
    laanwj committed Mar 28, 2019
    Copy the full SHA
    7bcf90c View commit details
    Browse the repository at this point in the history

  5. Simplify orphan processing in preparation for interruptibility 

    Github-Pull: bitcoin#15644
Rebased-From: 9453018
    @sipa
    sipa authored and MarcoFalke committed Mar 28, 2019
    Copy the full SHA
    6355214 View commit details
    Browse the repository at this point in the history

  6. [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx 

    Github-Pull: bitcoin#15644
Rebased-From: 6e051f3
    @sipa
    sipa authored and MarcoFalke committed Mar 28, 2019
    Copy the full SHA
    bb60121 View commit details
    Browse the repository at this point in the history

  7. Interrupt orphan processing after every transaction 

    This makes orphan processing work like handling getdata messages:
After every actual transaction validation attempt, interrupt
processing to deal with messages arriving from other peers.

Github-Pull: bitcoin#15644
Rebased-From: 866c805
    @sipa
    sipa authored and MarcoFalke committed Mar 28, 2019
    Copy the full SHA
    50c56f2 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2019

  1. [tests] Add test for wallet rebroadcasts 

    The existing wallet_resendwallettransactions.py test only tests the
resendwallettransactions RPC. It does not test whether transactions are
actually rebroadcast, or whether the rebroadcast logic is called on a
timer.

This commit updates the test to not use the resendwallettransactions RPC and
test that transactions are rebroadcast on a timer.

Github-Pull: bitcoin#15646
Rebased-From: 529c1ae
    @jnewbery
    jnewbery authored and MarcoFalke committed Apr 1, 2019
    Copy the full SHA
    a90db2f View commit details
    Browse the repository at this point in the history

  2. wallet: Move CWallet::ReacceptWalletTransactions locks to callers 

    Github-Pull: bitcoin#15652
Rebased-From: 0440481
    @promag
    promag authored and MarcoFalke committed Apr 1, 2019
    Copy the full SHA
    ebf6566 View commit details
    Browse the repository at this point in the history

  3. interfaces: Add Chain::requestMempoolTransactions 

    Github-Pull: bitcoin#15652
Rebased-From: 57908a7
    @promag
    promag authored and MarcoFalke committed Apr 1, 2019
    Copy the full SHA
    ed0498a View commit details
    Browse the repository at this point in the history

  4. wallet: Update transactions with current mempool after load 

    Github-Pull: bitcoin#15652
Rebased-From: 2ebf650
    @promag
    promag authored and MarcoFalke committed Apr 1, 2019
    Copy the full SHA
    59716ec View commit details
    Browse the repository at this point in the history

  5. qa: Check unconfirmed balance after loadwallet 

    Github-Pull: bitcoin#15652
Rebased-From: 4bf1b1c
    @promag
    promag authored and MarcoFalke committed Apr 1, 2019
    Copy the full SHA
    95faffe View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2019

  1. Merge bitcoin#15691: 0.18: rc3 backports 

    95faffe qa: Check unconfirmed balance after loadwallet (João Barbosa)
59716ec wallet: Update transactions with current mempool after load (João Barbosa)
ed0498a interfaces: Add Chain::requestMempoolTransactions (João Barbosa)
ebf6566 wallet: Move CWallet::ReacceptWalletTransactions locks to callers (João Barbosa)
a90db2f [tests] Add test for wallet rebroadcasts (John Newbery)
50c56f2 Interrupt orphan processing after every transaction (Pieter Wuille)
bb60121 [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx (Pieter Wuille)
6355214 Simplify orphan processing in preparation for interruptibility (Pieter Wuille)

Pull request description:

  Remaining backports for rc3

ACKs for commit 95faff:
  promag:
    ACK 95faffe, well done in ed0498a - verified all cherry picks.

Tree-SHA512: 597ee45493ac04e8c3149628a357c3238169d4b4f78158f22a3531e5f66289c228ecd6582f99026698883216f1ee7934d6315d19c99fc5f4f33dd1bed4300186
    @laanwj
    laanwj committed Apr 2, 2019
    Copy the full SHA
    32ec900 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. Update bips.md for 0.18.0 

    Github-Pull: bitcoin#15763
Rebased-From: 65d2f5d
    @sipa @fanquake
    sipa authored and fanquake committed Apr 9, 2019
    1
    Copy the full SHA
    538fef6 View commit details
    Browse the repository at this point in the history

  2. doc: correct bitcoinconsensus_version in shared-libraries 

    Github-Pull: bitcoin#15765
Rebased-From: 8ae6d02
    @fanquake
    fanquake committed Apr 9, 2019
    1
    Copy the full SHA
    956c0aa View commit details
    Browse the repository at this point in the history

  3. Mention new PSBT RPCs in psbt.md 

    Github-Pull: bitcoin#15757
Rebased-From: 28d78de
    @sipa @fanquake
    sipa authored and fanquake committed Apr 9, 2019
    1
    Copy the full SHA
    1b0752a View commit details
    Browse the repository at this point in the history

  4. Mention new descriptor RPCs in descriptors.md 

    Github-Pull: bitcoin#15757
Rebased-From: 9b085f4
    @sipa @fanquake
    sipa authored and fanquake committed Apr 9, 2019
    1
    Copy the full SHA
    bf32bc4 View commit details
    Browse the repository at this point in the history

  5. Merge bitcoin#15775: [0.18] Doc Backports 

    bf32bc4 Mention new descriptor RPCs in descriptors.md (Pieter Wuille)
1b0752a Mention new PSBT RPCs in psbt.md (Pieter Wuille)
956c0aa doc: correct bitcoinconsensus_version in shared-libraries (fanquake)
538fef6 Update bips.md for 0.18.0 (Pieter Wuille)

Pull request description:

  Can be bumped to 0.18.1 if `rc3` ends up being final.

ACKs for commit bf32bc:
  MarcoFalke:
    ACK bf32bc4

Tree-SHA512: 60ad8f0ca53b9fbf6f2a4941bd10971cfece192032d1feff3b25e1b8572caf72cd63c5b8507c376a8bdfb57da6551ac9c2c32dc1f8dc2658a3ea4abf75b0fd9a
    MarcoFalke committed Apr 9, 2019
    1
    Copy the full SHA
    164082c View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2019

  1. rpc: getrpcinfo docs 

    Github-Pull: bitcoin#15754
Rebased-From: f4b7a2f
    @benthecarman
    benthecarman committed Apr 11, 2019
    1
    Copy the full SHA
    60d4621 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2019

  1. Merge bitcoin#15790: [0.18] backport bitcoin#15754 

    60d4621 rpc: getrpcinfo docs (Ben Carman)

Pull request description:

  Backports bitcoin#15754 to the 0.18 branch

  bitcoin#15754 added the help message for `getrpcinfo`

ACKs for commit 60d462:
  promag:
    utACK 60d4621.
  fanquake:
    utACK 60d4621

Tree-SHA512: 3c0f0aded2dbd300b1cb5e3a3abb1d84852a165aa6ebb337833f06ba135730192a6e86b58323e4c5eb3a7636268125bea7be05925b5b316220bfa5ac1de4a5f4
    @laanwj
    laanwj committed Apr 15, 2019
    1
    Copy the full SHA
    f42ed14 View commit details
    Browse the repository at this point in the history

  2. [rpc] Remove the addresses field from the getaddressinfo return object 

    The "addresses" field was confusing because it refered to public keys
using their P2PKH address.  It was included in the return object when
needed for backward compatibility. Remove that compatibility now that
the -deprecatedrpc=validateaddress option has been removed.

New applications should use the 'embedded'->'address' field for P2SH or
P2WSH wrapped addresses, and 'pubkeys' for inspecting multisig
participants.

Github-Pull: 15750
Rebased-From: b4338c1
    @jnewbery
    jnewbery committed Apr 15, 2019
    1
    Copy the full SHA
    b3a04c9 View commit details
    Browse the repository at this point in the history

  3. Merge bitcoin#15800: Backport: [rpc] Remove the addresses field from … 

    …the getaddressinfo return object

b3a04c9 [rpc] Remove the addresses field from the getaddressinfo return object (John Newbery)

Pull request description:

  Backport bitcoin#15750

ACKs for commit b3a04c:
  MarcoFalke:
    ACK b3a04c9 (checked cherry-pick)

Tree-SHA512: d6e586fb6e22b9825267d6c45dd3090b7f8dc1a06804ca238103d1c665b178f8c2b3004f67aae67ea51c2c3df97561894f3f2e85d45400c760c3b7f057ff4bb8
    MarcoFalke committed Apr 15, 2019
    1
    Copy the full SHA
    fa3993b View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2019

  1. gitignore: add *.dat 

    Github-Pull: bitcoin#15809
Rebased-From: e7acf44
    @jamesob @fanquake
    jamesob authored and fanquake committed Apr 16, 2019
    1
    Copy the full SHA
    8f7cfb0 View commit details
    Browse the repository at this point in the history

  2. gitignore: add *.plist (clang-check) 

    Github-Pull: bitcoin#15809
Rebased-From: 17be9e0
    @jamesob @fanquake
    jamesob authored and fanquake committed Apr 16, 2019
    1
    Copy the full SHA
    c69138a View commit details
    Browse the repository at this point in the history

  3. doc: mention creating application support bitcoin folder on OSX 

    Github-Pull: bitcoin#15802
Rebased-From: 8dfbb5c
    @fanquake
    Jack Mallers authored and fanquake committed Apr 16, 2019
    1
    Copy the full SHA
    9c572e3 View commit details
    Browse the repository at this point in the history

  4. doc/dependencies: Fix typo libsrvg->librsvg 

    Github-Pull: bitcoin#15684
Rebased-From: 7d01b5c
    @luke-jr @fanquake
    luke-jr authored and fanquake committed Apr 16, 2019
    1
    Copy the full SHA
    6d2448c View commit details
    Browse the repository at this point in the history

  5. doc: describe onlynet option in doc/tor.md 

    as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-04-11.html#l-102.

Description adapted from https://github.com/bitcoin/bitcoin/blob/master/src/init.cpp#L429.

Also fixes a typo in doc/dependencies.md.

Github-Pull: bitcoin#15792
Rebased-From: 140bbee
    @jonatack @fanquake
    jonatack authored and fanquake committed Apr 16, 2019
    1
    Copy the full SHA
    194226f View commit details
    Browse the repository at this point in the history

  6. doc: Clarify RPC versioning 

    Github-Pull: bitcoin#15799
Rebased-From: fa74749
    @fanquake
    MarcoFalke authored and fanquake committed Apr 16, 2019
    1
    Copy the full SHA
    a644780 View commit details
    Browse the repository at this point in the history

  7. Keep full pubkeys in FlatSigningProvider::origins 

    Github-Pull: bitcoin#15749
Rebased-From: 9a93c91
    @sipa @meshcollider
    sipa authored and meshcollider committed Apr 16, 2019
    1
    Copy the full SHA
    7fcbe7d View commit details
    Browse the repository at this point in the history

  8. Import all origin info in importmulti; even for non-importing pubkeys 

    Github-Pull: bitcoin#15749
Rebased-From: 6e59700
    @sipa @meshcollider
    sipa authored and meshcollider committed Apr 16, 2019
    1
    Copy the full SHA
    802dcd3 View commit details
    Browse the repository at this point in the history

  9. Take non-importing keys into account for spendability warning in desc… 

    …riptor import

Github-Pull: bitcoin#15749
Rebased-From: b5d3987
    @sipa @meshcollider
    sipa authored and meshcollider committed Apr 16, 2019
    1
    Copy the full SHA
    235550d View commit details
    Browse the repository at this point in the history

  10. Merge bitcoin#15803: [0.18] Backport 15749: importmulti only imports … 

    …origin info for PKH outputs

235550d Take non-importing keys into account for spendability warning in descriptor import (Pieter Wuille)
802dcd3 Import all origin info in importmulti; even for non-importing pubkeys (Pieter Wuille)
7fcbe7d Keep full pubkeys in FlatSigningProvider::origins (Pieter Wuille)

Pull request description:

  Clean backport of bitcoin#15749 by sipa to 0.18

ACKs for commit 235550:
  fanquake:
    utACK 235550d
  MarcoFalke:
    ACK 235550d (Checked that they are clean cherry-picks)

Tree-SHA512: 1ccc19f51137ac4ef971c0bcca4c87ab2383610aa51c5d02680c485b9ce6abd698dddd7f4a45946d56b1aa741cc3fd94b4180ff15901824d20eeba89b4f12853
    MarcoFalke committed Apr 16, 2019
    1
    Copy the full SHA
    e57462c View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2019

  1. Revert "Change in transaction pull scheduling to prevent InvBlock-rel… 

    …ated attacks"

This reverts commit 1cff3d6.
    @sdaftuar
    sdaftuar committed Apr 17, 2019
    1
    Copy the full SHA
    8602d8b View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2019

  1. Merge bitcoin#15818: [0.18] doc backports 

    a644780 doc: Clarify RPC versioning (MarcoFalke)
194226f doc: describe onlynet option in doc/tor.md (Jon Atack)
6d2448c doc/dependencies: Fix typo libsrvg->librsvg (Luke Dashjr)
9c572e3 doc: mention creating application support bitcoin folder on OSX (Jack Mallers)
c69138a gitignore: add *.plist (clang-check) (James O'Beirne)
8f7cfb0 gitignore: add *.dat (James O'Beirne)

Pull request description:

  Backports bitcoin#15684, bitcoin#15792, bitcoin#15802,  bitcoin#15809 to the `0.18` branch.

ACKs for commit a64478:

Tree-SHA512: 6ed524a7b94242f8a738710d4321b98b9e80d6625d384fd83280b38fcb6bb8c468bcec1d980789ad2f4c91a5629ffe5c5314a7353181f08884c5a081840431cc
    @laanwj
    laanwj committed Apr 18, 2019
    1
    Copy the full SHA
    e753cbd View commit details
    Browse the repository at this point in the history

  2. GUI: Options: Set the range of pruning size before loading its value 

    Without this, an out-of-default-range value gets limited to the range

Github-Pull: bitcoin#15801
Rebased-From: 4ddeb2f
Tree-SHA512: 64c18c8be6756fc0130d3fe934edb1ea7758877d4049c5729fa2adb05abb3af4e4bbe1d5f910224e16070aada5470637a35ed14b12391efd48cf035e8a22a949
    @luke-jr @laanwj
    luke-jr authored and laanwj committed Apr 18, 2019
    1
    Copy the full SHA
    5546207 View commit details
    Browse the repository at this point in the history

  3. GUI: Options: Remove the upper-bound limit from pruning size setting 

    Hypothetically, someone may wish to begin pruning at a future blockchain size, and there's no reason to limit it lower

Github-Pull: bitcoin#15801
Rebased-From: 8a33f4d
Tree-SHA512: 814dc5f004c3418216a12f8e0ef1a8db2c586d98b515d48b31a8ccd7f4e0deb12b9f2b6110bf702576a32802ca1d30e518df5ad7c28046deb4d0e9be46a6e7b8
    @luke-jr @laanwj
    luke-jr authored and laanwj committed Apr 18, 2019
    1
    Copy the full SHA
    a58d80d View commit details
    Browse the repository at this point in the history

  4. Merge bitcoin#15839: [0.18] Revert GetData randomization change (bitc… 

    …oin#14897)

8602d8b Revert "Change in transaction pull scheduling to prevent InvBlock-related attacks" (Suhas Daftuar)

Pull request description:

  This is for 0.18, not master -- I propose we revert the getdata change for the 0.18 release, rather than try to continue patching it up.  It seems like we've turned up several additional bugs that slipped through initial review (see bitcoin#15776, bitcoin#15834), and given the potential severe consequences of these bugs I think it'd make more sense for us to delay releasing this code until 0.19.

  Since the bugfix PRs are getting review, I think we can leave bitcoin#14897 in master, but we can separately discuss if it should be reverted in master as well if anyone thinks that would be more appropriate.

ACKs for commit 8602d8:

Tree-SHA512: 0389cefc1bc74ac47f87866cf3a4dcfe202740a1baa3db074137e0aa5859672d74a50a34ccdb7cf43b3a3c99ce91e4ba1fb512d04d1d383d4cc184a8ada5543f
    MarcoFalke committed Apr 18, 2019
    1
    Copy the full SHA
    607b1b7 View commit details
    Browse the repository at this point in the history

  5. gui: Pre-rc4 translations update 

    Tree-SHA512: f3a7c9e0c935c869a85e3bc93a4bd33999270ffc13d35de34c46e9dab19229af19fb9c1a61a99264e8411c0966bf8b02a5ee94bf20a07f66b92234473f0e0801
    @laanwj
    laanwj committed Apr 18, 2019
    1
    Copy the full SHA
    a4fc2fb View commit details
    Browse the repository at this point in the history

  6. doc: Move release notes from wiki 

    Tree-SHA512: 59b8d913d56081ac73f3777ae4017b2f416da531e8c47ab854ff277f714f58e238215e89caa7c5973899dc3114cb5bdbaf7f7ca26a22a4062d6029d30d3c1156
    @laanwj
    laanwj committed Apr 18, 2019
    1
    Copy the full SHA
    4384839 View commit details
    Browse the repository at this point in the history

  7. build: Bump version to rc4 

    Tree-SHA512: 5a4b6c0f38402c289ecb0abb59d45ef87a9dfb0bc135baf0512bc4e566c92fb28da519da3aec006594c8ecde38eb8ab4997f899bcd2301f506c4d5633e84391a
    @laanwj
    laanwj committed Apr 18, 2019
    1
    Copy the full SHA
    379f71e View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2019

  1. doc: 0.18: Remove TODO from release notes

    MarcoFalke committed Apr 19, 2019
    1
    Copy the full SHA
    fad9eb1 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2019

  1. Merge bitcoin#15852: doc: 0.18: Remove TODO from release notes 

    fad9eb1 doc: 0.18: Remove TODO from release notes (MarcoFalke)

Pull request description:

  Also, remove section that no longer applies after bitcoin#15839

ACKs for commit fad9eb:

Tree-SHA512: 259cbaa313cd6cce0f83a577527612314b484e77c7001fe56a21553dc0e446d9aa2bdf1129e546f9c4c142fa3cf4479d72d4561ee553a8a6e9d5453061813a3c
    MarcoFalke committed Apr 26, 2019
    1
    Copy the full SHA
    825ecb5 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2019

  1. build: Bump version to -final 

    Tree-SHA512: 94e3c6149ba6a8c49ffc64f3f0a642950ebfc722fdd6c6a30c21b989f49f8c8be827212e65a0f367332bd38a56fe4b248ccf2147f019aed06224f7975a21fff6
    @laanwj
    laanwj committed Apr 30, 2019
    Copy the full SHA
    2472733 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2019

  1. doc: Clean out release notes post-0.18.0 

    Tree-SHA512: c1076f844d7b083e1637aeed51b05a638b8d8068a58cf1f24be9af811c071d11d71552d1b1ebfc7ba14a53aa2534288d12039c1a00270a316d528244144a74ad
    @laanwj
    laanwj committed May 2, 2019
    Copy the full SHA
    be92be5 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2019

  1. build with -fstack-reuse=none 

    Github-Pull: bitcoin#15983
Rebased-From: faf38bc
    MarcoFalke committed May 16, 2019
    Copy the full SHA
    5935f01 View commit details
    Browse the repository at this point in the history

  2. net: Rename ::fRelayTxes to ::g_relay_txes 

    This helps to distinguish it from CNode::fRelayTxes and avoid bugs like
425278d

Github-Pull: bitcoin#15990
Rebased-From: fa1dce7
    MarcoFalke committed May 16, 2019
    Copy the full SHA
    9c1a607 View commit details
    Browse the repository at this point in the history

  3. test: Format predicate source as multiline on error 

    Github-Pull: bitcoin#15990
Rebased-From: fa3872e
    MarcoFalke committed May 16, 2019
    Copy the full SHA
    8f215c7 View commit details
    Browse the repository at this point in the history

  4. test: Add test for p2p_blocksonly 

    Github-Pull: bitcoin#15990
Rebased-From: fa320de
    MarcoFalke committed May 16, 2019
    Copy the full SHA
    3460555 View commit details
    Browse the repository at this point in the history

  5. doc: Mention blocksonly in reduce-traffic.md, unhide option 

    Github-Pull: bitcoin#15990
Rebased-From: fa8ced3
    MarcoFalke committed May 16, 2019
    Copy the full SHA
    890a92e View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. Doc: remove text about txes always relayed from -whitelist 

    Updates text since -whitelistforcerelay was set to false by default in
PR bitcoin#15193.

Github-Pull: bitcoin#15890
Rebased-From: e0bb279
    @harding
    harding authored and MarcoFalke committed May 17, 2019
    Copy the full SHA
    eb85ee6 View commit details
    Browse the repository at this point in the history

  2. Install bitcoin-wallet manpage. 

    This change marks the already-existing bitcoin-wallet.1 manpage file for
installation together with the others.  Previously, only bitcoind.1,
bitcoin-cli.1, bitcoin-tx.1 and bitcoin-qt.1 would be installed.

Github-Pull: bitcoin#15947
Rebased-From: 00d1104
    @domob1812
    domob1812 authored and MarcoFalke committed May 17, 2019
    Copy the full SHA
    a635377 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2019

  1. Show loaded wallets as disabled in open menu instead of nothing 

    Github-Pull: bitcoin#15957
Rebased-From: c3ef63a
    @meshcollider
    meshcollider authored and MarcoFalke committed May 18, 2019
    Copy the full SHA
    3dbc7de View commit details
    Browse the repository at this point in the history

Commits on May 20, 2019

  1. Disallow extended encoding for non-witness transactions 

    Github-Pull: bitcoin#14039
Rebased-From: bb530ef
    @sipa
    sipa authored and MarcoFalke committed May 20, 2019
    Copy the full SHA
    206f5ee View commit details
    Browse the repository at this point in the history

  2. Fix missing input template by making minimal tx 

    Github-Pull: bitcoin#15893
Rebased-From: 25b0786
    @instagibbs
    instagibbs authored and MarcoFalke committed May 20, 2019
    Copy the full SHA
    5a58ddb View commit details
    Browse the repository at this point in the history

  3. Add test for superfluous witness record in deserialization 

    Github-Pull: bitcoin#15893
Rebased-From: cc556e4
    @instagibbs
    instagibbs authored and MarcoFalke committed May 20, 2019
    Copy the full SHA
    8603108 View commit details
    Browse the repository at this point in the history

  4. Disallow extended encoding for non-witness transactions (take 3) 

    Github-Pull: bitcoin#16021
Rebased-From: fa2b52a
    MarcoFalke committed May 20, 2019
    Copy the full SHA
    b6c1f94 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2019

  1. qt: fix opening bitcoin.conf via Preferences on macOS; see bitcoin#15409 

    

Github-Pull: bitcoin#16044
Rebased-From: 6e6494b
    @web3shannon
    web3shannon authored and MarcoFalke committed Jun 7, 2019
    Copy the full SHA
    b55cbe8 View commit details
    Browse the repository at this point in the history

  2. gui: Enable console line edit on setClientModel 

    Github-Pull: bitcoin#16122
Rebased-From: 2d8ad2f
    @promag
    promag authored and MarcoFalke committed Jun 7, 2019
    Copy the full SHA
    7ed1a60 View commit details
    Browse the repository at this point in the history

  3. gui: Set progressDialog to nullptr 

    Github-Pull: bitcoin#16135
Rebased-From: d2ae6be
    @promag
    promag authored and MarcoFalke committed Jun 7, 2019
    Copy the full SHA
    d80c558 View commit details
    Browse the repository at this point in the history

  4. Add test for GCC bug 90348 

    Github-Pull: bitcoin#15985
Rebased-From: 58e291c
    @sipa
    sipa authored and MarcoFalke committed Jun 7, 2019
    Copy the full SHA
    d1f2611 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2019

  1. dummywallet: Reformat ignored wallet options list

    MarcoFalke committed Jun 11, 2019
    Copy the full SHA
    206c30f View commit details
    Browse the repository at this point in the history

  2. Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wall… 

    …et options

Github-Pull: bitcoin#15913
Rebased-From: 765d589
    @luke-jr
    luke-jr authored and MarcoFalke committed Jun 11, 2019
    Copy the full SHA
    106471d View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2019

  1. Merge bitcoin#16189: 0.18: Backport "Add -ignorepartialspends to list… 

    … of ignored wallet options"

106471d Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options (Luke Dashjr)
206c30f dummywallet: Reformat ignored wallet options list (MarcoFalke)

Pull request description:

  First run clang-format on the wallet options list (review with `--word-diff-regex=.`). This is not a backport.

  Then backport Github-Pull: bitcoin#15913

ACKs for commit 106471:
  promag:
    ACK 106471d.
  laanwj:
    ACK 106471d

Tree-SHA512: 3e6eb7997aa32ef7385842614bac8cac56f86b6dde949cfbbd33b4387e713bf5f65e40ee3e4228ac43dfe50829169175b80ddeaac8a714ad8a38175638123f5d
    @laanwj
    laanwj committed Jun 13, 2019
    1
    Copy the full SHA
    9c29bc7 View commit details
    Browse the repository at this point in the history

  2. gui: Enable open wallet menu on setWalletController 

    Github-Pull: bitcoin#16118
Rebased-From: 75485ef
    @promag
    promag authored and MarcoFalke committed Jun 13, 2019
    Copy the full SHA
    b239824 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2019

  1. Fix RPC/pruneblockchain returned prune height 

    Github-Pull: bitcoin#15991
Rebased-From: 97f517d
    @jonasschnelli
    jonasschnelli authored and MarcoFalke committed Jun 14, 2019
    Copy the full SHA
    c80a498 View commit details
    Browse the repository at this point in the history

  2. fixup: Fix prunning test 

    Github-Pull: bitcoin#15991
Rebased-From: f402012
    @promag
    promag authored and MarcoFalke committed Jun 14, 2019
    Copy the full SHA
    592016b View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2019

  1. Add example 2nd arg to signrawtransactionwithkey 

    The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.

Github-Pull: bitcoin#16210
Rebased-From: 71fd628
    @dooglus
    dooglus authored and MarcoFalke committed Jun 17, 2019
    Copy the full SHA
    d24d0ec View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2019

  1. rpc: Switch touched RPCs to IsValidNumArgs 

    Github-Pull: bitcoin#15899
Rebased-From: fa5c5cd
    MarcoFalke committed Jun 18, 2019
    Copy the full SHA
    bb36ac8 View commit details
    Browse the repository at this point in the history

  2. Bugfix: test/functional/rpc_psbt: Remove check for specific error mes… 

    …sage that depends on uncertain assumptions

When converttopsbt is called with a signed transaction, it either fails with "TX decode failed" if one or more inputs were segwit, or "Inputs must not have scriptSigs and scriptWitnesses" otherwise.
Since no effort is made by the test to ensure the inputs are segwit or not, avoid checking the exact message used.
The error code is still checked to ensure it is of the correct kind of failure.

Github-Pull: bitcoin#14818
Rebased-From: 097c4aa
    @luke-jr
    luke-jr authored and MarcoFalke committed Jun 18, 2019
    Copy the full SHA
    966d8d0 View commit details
    Browse the repository at this point in the history

  3. Bugfix: test/functional/rpc_psbt: Correct test description comment 

    Github-Pull: bitcoin#14818
Rebased-From: c87fc71
    @luke-jr
    luke-jr authored and MarcoFalke committed Jun 18, 2019
    Copy the full SHA
    832eb4f View commit details
    Browse the repository at this point in the history

  4. rpc: bugfix: Properly use iswitness in converttopsbt 

    Also explain the param in all RPCs

Github-Pull: bitcoin#15899
Rebased-From: fa499b5
    MarcoFalke committed Jun 18, 2019
    Copy the full SHA
    0023c97 View commit details
    Browse the repository at this point in the history

  5. tinyformat: Add doc to Bitcoin Core specific strprintf 

    Github-Pull: bitcoin#16205
Rebased-From: fa72a64
    MarcoFalke committed Jun 18, 2019
    Copy the full SHA
    f88959b View commit details
    Browse the repository at this point in the history

  6. Exceptions should be caught by reference, not by value. 

    Github-Pull: bitcoin#16095
Rebased-From: ae7faf2
    @kristapsk
    kristapsk authored and MarcoFalke committed Jun 18, 2019
    Copy the full SHA
    e29aa6e View commit details
    Browse the repository at this point in the history

  7. scripted-diff: Replace fprintf with tfm::format 

    -BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e 's/fprintf\(std(err|out), /tfm::format(std::c\1, /g' $(git grep -l 'fprintf(' -- ':(exclude)src/crypto' ':(exclude)src/leveldb' ':(exclude)src/univalue' ':(exclude)src/secp256k1')
-END VERIFY SCRIPT-

fixup! scripted-diff: Replace fprintf with tfm::format

Github-Pull: bitcoin#16205
Rebased-From: fac03ec
    MarcoFalke committed Jun 18, 2019
    Copy the full SHA
    beb09f0 View commit details
    Browse the repository at this point in the history

  8. Replace remaining fprintf with tfm::format manually 

    Github-Pull: bitcoin#16205
Rebased-From: fa8f195
    MarcoFalke committed Jun 18, 2019
    Copy the full SHA
    79745d1 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2019

  1. test: Fixup creatmultisig documentation and whitespace 

    Github-Pull: bitcoin#15831
Rebased-From: fad81d8
    MarcoFalke committed Jun 21, 2019
    Copy the full SHA
    13b3bb5 View commit details
    Browse the repository at this point in the history

  2. test: Add test that addmultisigaddress fails for watchonly addresses 

    Github-Pull: bitcoin#15831
Rebased-From: fab6a0a
    MarcoFalke committed Jun 21, 2019
    Copy the full SHA
    23ba460 View commit details
    Browse the repository at this point in the history

  3. Pure python EC 

    This removes the dependency on OpenSSL for the interaction tests, by providing a pure-Python
toy implementation of secp256k1.

Github-Pull: bitcoin#15826
Rebased-From: 8c7b932
    @sipa
    sipa authored and MarcoFalke committed Jun 21, 2019
    Copy the full SHA
    d9fc969 View commit details
    Browse the repository at this point in the history

  4. Make and get the multisig redeemscript and destination in one functio… 

    …n instead of two

Instead of creating a redeemScript with CreateMultisigRedeemscript and
then getting the destination with AddAndGetDestinationForScript, do
both in the same function.

CreateMultisigRedeemscript is changed to AddAndGetMultisigDestination.
It creates the redeemScript and returns it via an output parameter. Then
it calls AddAndGetDestinationForScript to add the destination to the
keystore and get the proper destination.

This allows us to inspect the public keys in the redeemScript before creating
the destination so that the correct destination is used when uncompressed
pubkeys are in the multisig.

Github-Pull: bitcoin#16026
Rebased-From: a495034
    @achow101
    achow101 authored and MarcoFalke committed Jun 21, 2019
    Copy the full SHA
    e78007f View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2019

  1. gui: Fix open wallet menu initialization order 

    The menu must be created before connecting to aboutToShow signal.

Github-Pull: bitcoin#16231
Rebased-From: 5224be5
    @promag
    promag authored and MarcoFalke committed Jun 23, 2019
    Copy the full SHA
    2800b3d View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2019

  1. Set AA_EnableHighDpiScaling attribute early 

    Qt docs: This attribute must be set before QGuiApplication is
constructed.

Github-Pull: bitcoin#16254
Rebased-From: 099e4b9
    @hebasto
    hebasto authored and MarcoFalke committed Jun 24, 2019
    Copy the full SHA
    715da91 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Add comments to Python ECDSA implementation 

    Github-Pull: bitcoin#15826
Rebased-From: b679785
    @jnewbery
    jnewbery authored and MarcoFalke committed Jun 26, 2019
    Copy the full SHA
    af25a75 View commit details
    Browse the repository at this point in the history

  2. .python-version: Bump to 3.5.6 

    See also: dddd1d0
    MarcoFalke committed Jun 26, 2019
    Copy the full SHA
    bcb27d7 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2019

  1. Merge bitcoin#16035: 0.18.1: Backports 

    bcb27d7 .python-version: Bump to 3.5.6 (MarcoFalke)
af25a75 Add comments to Python ECDSA implementation (John Newbery)
715da91 Set AA_EnableHighDpiScaling attribute early (Hennadii Stepanov)
2800b3d gui: Fix open wallet menu initialization order (João Barbosa)
e78007f Make and get the multisig redeemscript and destination in one function instead of two (Andrew Chow)
d9fc969 Pure python EC (Pieter Wuille)
23ba460 test: Add test that addmultisigaddress fails for watchonly addresses (MarcoFalke)
13b3bb5 test: Fixup creatmultisig documentation and whitespace (MarcoFalke)
79745d1 Replace remaining fprintf with tfm::format manually (MarcoFalke)
beb09f0 scripted-diff: Replace fprintf with tfm::format (MarcoFalke)
e29aa6e Exceptions should be caught by reference, not by value. (Kristaps Kaupe)
f88959b tinyformat: Add doc to Bitcoin Core specific strprintf (MarcoFalke)
0023c97 rpc: bugfix: Properly use iswitness in converttopsbt (MarcoFalke)
832eb4f Bugfix: test/functional/rpc_psbt: Correct test description comment (Luke Dashjr)
966d8d0 Bugfix: test/functional/rpc_psbt: Remove check for specific error message that depends on uncertain assumptions (Luke Dashjr)
bb36ac8 rpc: Switch touched RPCs to IsValidNumArgs (MarcoFalke)
d24d0ec Add example 2nd arg to signrawtransactionwithkey (Chris Moore)
592016b fixup: Fix prunning test (João Barbosa)
c80a498 Fix RPC/pruneblockchain returned prune height (Jonas Schnelli)
b239824 gui: Enable open wallet menu on setWalletController (João Barbosa)
d1f2611 Add test for GCC bug 90348 (Pieter Wuille)
d80c558 gui: Set progressDialog to nullptr (João Barbosa)
7ed1a60 gui: Enable console line edit on setClientModel (João Barbosa)
b55cbe8 qt: fix opening bitcoin.conf via Preferences on macOS; see bitcoin#15409 (shannon1916)
b6c1f94 Disallow extended encoding for non-witness transactions (take 3) (MarcoFalke)
8603108 Add test for superfluous witness record in deserialization (Gregory Sanders)
5a58ddb Fix missing input template by making minimal tx (Gregory Sanders)
206f5ee Disallow extended encoding for non-witness transactions (Pieter Wuille)
3dbc7de Show loaded wallets as disabled in open menu instead of nothing (MeshCollider)
a635377 Install bitcoin-wallet manpage. (Daniel Kraft)
eb85ee6 Doc: remove text about txes always relayed from -whitelist (David A. Harding)
890a92e doc: Mention blocksonly in reduce-traffic.md, unhide option (MarcoFalke)
3460555 test: Add test for p2p_blocksonly (MarcoFalke)
8f215c7 test: Format predicate source as multiline on error (MarcoFalke)
9c1a607 net: Rename ::fRelayTxes to ::g_relay_txes (MarcoFalke)
5935f01 build with -fstack-reuse=none (MarcoFalke)

Pull request description:

Tree-SHA512: 5cd73a4319cb69c92b528239cf97c0ed5fcf2b9e8c7fe154e4679eeec95db433a0223d8dc574e4cdc96c1913cfdf160b10c42dcdbcb5bbc8fb743c07930ef9da
    @fanquake
    fanquake committed Jul 4, 2019
    Copy the full SHA
    629c7b0 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2019

  1. signrawtransactionwithkey: report error when missing redeemScript/wit… 

    …nessScript param

Github-Pull: bitcoin#16250
Rebased-From: 0117459
    @ajtowns
    ajtowns committed Jul 5, 2019
    1
    Copy the full SHA
    1dc357d View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2019

  1. Merge bitcoin#16342: 0.18 backport: report error when missing redeemS… 

    …cript/witnessScript

1dc357d signrawtransactionwithkey: report error when missing redeemScript/witnessScript param (Anthony Towns)

Pull request description:

  Backport of bitcoin#16250 which fixes regression introduced in 0.18 in relation to signrawtransactionwithkey error handling (see bitcoin#16249).

Tree-SHA512: 0d75fa2aa578b886ace3bda92a02e25993f9f51d41db8c0eb3013bd77d266c45ad8b67dd0ed11c66533724f892be4e254edeb59fa70585ff762f522791fcca36
    @fanquake
    fanquake committed Jul 7, 2019
    1
    Copy the full SHA
    1fb747a View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. gui: Fix missing qRegisterMetaType(WalletModel*) 

    Github-Pull: bitcoin#16348
Rebased-From: f27bd96
    @promag
    promag committed Jul 9, 2019
    Copy the full SHA
    e2f7677 View commit details
    Browse the repository at this point in the history

  2. qt: Assert QMetaObject::invokeMethod result 

    Github-Pull: bitcoin#16348
Rebased-From: 64fee48
    @promag
    promag committed Jul 9, 2019
    Copy the full SHA
    df695db View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2019

  1. Merge bitcoin#16359: 0.18: Backport "qt: Assert QMetaObject::invokeMe… 

    …thod result"

df695db qt: Assert QMetaObject::invokeMethod result (João Barbosa)
e2f7677 gui: Fix missing qRegisterMetaType(WalletModel*) (João Barbosa)

Pull request description:

ACKs for top commit:
  hebasto:
    ACK df695db, I have not tested the code, but I have reviewed it and it looks OK, I agree it can be merged.
  laanwj:
    ACK df695db

Tree-SHA512: 5ce162e59331f6da8ae9ba41eff809881442fab93d65362b5f67aba19da76a72362f0daba9ad1f909478bf26f2daf53b110a0486d7b29b23b3716a7cd7177922
    @laanwj
    laanwj committed Jul 10, 2019
    Copy the full SHA
    410774a View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2019

  1. fix: tor: Call event_base_loopbreak from the event's callback 

    Github-Pull: bitcoin#16405
Rebased-From: a981e74
    @promag
    promag committed Jul 17, 2019
    Copy the full SHA
    b2711b9 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. Merge bitcoin#16406: 0.18: fix: tor: Call event_base_loopbreak from t… 

    …he event's callback

b2711b9 fix: tor: Call event_base_loopbreak from the event's callback (João Barbosa)

Pull request description:

  Github-Pull: bitcoin#16405
  Rebased-From: a981e74

ACKs for top commit:
  laanwj:
    ACK b2711b9, code change is the same as for master
  fanquake:
    ACK b2711b9

Tree-SHA512: 9f225e505c0241be422ed897f56aef6ebad57e15d3bfe5154c7fe4f874df342e0df287871cd737eb777d0f45865a6d129cd5d1a4c036ea0a4e5d4f36520ab174
    @fanquake
    fanquake committed Jul 18, 2019
    Copy the full SHA
    3f76160 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. net: Make poll in InterruptibleRecv only filter for POLLIN events. 

    poll should block until there is data to be read or the timeout expires.

Filtering for the POLLOUT event causes poll to return immediately which leads to high CPU usage when trying to connect to non-responding peers through tor.

Removing POLLOUT matches how select is used when USE_POLL isn't defined.

Github-Pull: bitcoin#16412
Rebased-From: a52818c
Tree-SHA512: eaf466630ba9d2a2a7443c9679c83c2cb13e779a5948f409cddb4c48cf32126ac68f3de48e394f9302e99858efa17cdb14650751a1b55c3b79e8a7507cab352d
    @tecnovert @laanwj
    tecnovert authored and laanwj committed Jul 19, 2019
    Copy the full SHA
    063c8ce View commit details
    Browse the repository at this point in the history

  2. qt: pre-rc1 translations update 

    Tree-SHA512: b97fd91b7ab1eb2297007a9821def31c065a2a33f12cf51fd5e5be5dff1e8afb4f5b001d220c3873d72ca5b06484ad2d1e2c8df5300770145de0dfebe56db303
    @laanwj
    laanwj committed Jul 19, 2019
    Copy the full SHA
    641b2ff View commit details
    Browse the repository at this point in the history

  3. build: Bump version to 0.18.1rc1 

    Tree-SHA512: f746d4cfda1eb433c4c99b8d80392ac2e905c1f39591eb5579a708129e3b1b36479a2da45221594713cf20069bde78c29a31cb10d39c7bc96544694d9832cda0
    @laanwj
    laanwj committed Jul 19, 2019
    Copy the full SHA
    aa2d12a View commit details
    Browse the repository at this point in the history

  4. doc: Update manpages for rc1 

    Tree-SHA512: 805a6931e2bd059ee2da42634f687828a50b2ccd3a1ac0071cd626e9a2f52b7afc79af3c8f3d5b013a853d5e59068314e744a4694dceef598710f0694babbd99
    @laanwj
    laanwj committed Jul 19, 2019
    Copy the full SHA
    a6cba19 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. doc: Update release notes for rc1 

    Tree-SHA512: e5422eaed5339327b600bfe07e5cdb1517bf6f3d9a39d27c9c59a68ceadbef398960c69630bc727f3f8d7330353e7823905f5107dba6d8827965565157cdeca1
    @laanwj
    laanwj committed Jul 24, 2019
    Copy the full SHA
    784e218 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. Doc: remove old release notes about systemd and riscv changes

    @harding
    harding committed Aug 2, 2019
    Copy the full SHA
    5f5b444 View commit details
    Browse the repository at this point in the history

  2. Merge bitcoin#16532: [0.18] Doc: remove old release notes about syste… 

    …md and riscv changes

5f5b444 Doc: remove old release notes about systemd and riscv changes (David A. Harding)

Pull request description:

  Removes these two paragraphs that were part of the 0.18.0 release notes but which I don't think need to be repeated for the 0.18.1 release notes.  The systemd release note in particular links to a section that isn't part of the document.

ACKs for top commit:
  practicalswift:
    ACK 5f5b444
  laanwj:
    ACK 5f5b444
  fanquake:
    ACK 5f5b444 - this should be fine.

Tree-SHA512: 3930b832eeed1f938cd6423dd9ac1e02ab7bb4fc218f433551fa995f40b84e8f2af5755ca4bf56caccdc742b6884bc79b381c9bdb3ad90e99ca90011d9e12665
    @laanwj
    laanwj committed Aug 2, 2019
    Copy the full SHA
    673919c View commit details
    Browse the repository at this point in the history

  3. build: set CLIENT_VERSION_RC to 0 pre-final 

    Tree-SHA512: b74ff824278e6a4c4781c904e3f68295c76d9de79cc174a6e7127273295ef3fddb87de89143ceb76805e33b8c2dec77b3e6ae4bec97a3128d9908c065c7f95de
    @laanwj
    laanwj committed Aug 2, 2019
    Copy the full SHA
    bfa7183 View commit details
    Browse the repository at this point in the history

  4. doc: Bump manpages pre-final 

    No changes, only the month changed from July to August.

Tree-SHA512: c8f672f3a6e570ea1feda2c2f17d30da8a04b705d990bf5aec8e09da5937f3f9a608f4f50941f183c536a4158001b13d149bd0c873a24eae48ae57d96cd274c8
    @laanwj
    laanwj committed Aug 2, 2019
    Copy the full SHA
    fa27a07 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2020

  1. Add a new rpc api to get part of a transaction

    @ledzep2
    dploop authored and ledzep2 committed Feb 22, 2020
    Copy the full SHA
    50dad6f View commit details
    Browse the repository at this point in the history

  2. Add two apis to get full block and full transactions

    @ledzep2
    dploop authored and ledzep2 committed Feb 22, 2020
    Copy the full SHA
    d919514 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2020

  1. chore: rebase to v0.18.1

    @ledzep2
    ledzep2 committed Feb 23, 2020
    Copy the full SHA
    938d948 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. chore: build docker image

    @zengyiheng
    zengyiheng committed Feb 24, 2020
    Copy the full SHA
    1f384fa View commit details
    Browse the repository at this point in the history